Gradle build error when nativescript-google-maps-sdk is added #250

Author: EddyVerbruggen

README.md

@@ -187,16 +187,32 @@ placing `google-services.json` to `platforms/android/google-services.json` (see
 the changes to `build.gradle` which are mentioned above as well.
 
 #### Could not find com.google...
-And there's this one: "Could not find com.google.firebase:firebase-auth:9.4.0". That means
+And there's this one: "Could not find com.google.firebase:firebase-auth:10.0.+". That means
 making sure you have the latest `Google Repository` bits installed.
 Just run `android` from a command prompt and install any pending updates.
 
-Also, an error like "Could not find com.google.firebase:firebase-core:9.0.0" can be caused by having
+Also, an error like "Could not find com.google.firebase:firebase-core:10.0.0" can be caused by having
 more than one version of the Android SDK installed. Make sure ANDROID_HOME is set to the Android SDK directory
 that is being updated otherwise it will seem as though your updates have no effect.
 
-#### Found play-services:9.0.0, but version 9.X.Y is needed..
+#### Found play-services:9.0.0, but version 10.X.Y is needed..
 Update your Android bits like the issue above and reinstall the android platform in your project.
 
+#### `include.gradle`: Failed to apply plugin .. For input string: "+"
+You probably have another plugin depending on Google Play Services (Google Maps, perhaps).
+We need to pin to a specific play services version to play nice with others, so open `app/App_Resources/Android/app.gradle` and add:
+
+```
+android {  
+  // other stuff here
+
+  project.ext {
+    googlePlayServicesVersion = "10.0.+"
+  }
+}
+```
+
+Where `"10.0.+"` is best set to the same value as the version on [this line](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/blob/master/platforms/android/include.gradle#L23).
+
 ## Credits
 The starting point for this plugin was [this great Gist](https://gist.github.com/jbristowe/c89a7bcae7fc9a035ee7) by [John Bristowe](https://github.com/jbristowe).

platforms/android/include.gradle

@@ -36,7 +36,7 @@ dependencies {
 //    compile "com.facebook.android:facebook-android-sdk:4.+"
 
     // Uncomment if you need Google Sign-In Authentication
-//    compile "com.google.android.gms:play-services-auth:10.0.+"
+//    compile "com.google.android.gms:play-services-auth:$googlePlayServicesVersion"
 
 }
 

scripts/installer.js

@@ -267,7 +267,7 @@ dependencies {
     ` + (isSelected(result.facebook_auth) ? `` : `//`) + ` compile "com.facebook.android:facebook-android-sdk:4.+"
 
     // Uncomment if you need Google Sign-In Authentication
-    ` + (isSelected(result.google_auth) ? `` : `//`) + ` compile "com.google.android.gms:play-services-auth:10.0.+"
+    ` + (isSelected(result.google_auth) ? `` : `//`) + ` compile "com.google.android.gms:play-services-auth:$googlePlayServicesVersion"
 
 }
 

scripts/postinstall.js

@@ -3063,7 +3063,7 @@ dependencies {
     ` + (isSelected(result.facebook_auth) ? `` : `//`) + ` compile "com.facebook.android:facebook-android-sdk:4.+"
 
     // Uncomment if you need Google Sign-In Authentication
-    ` + (isSelected(result.google_auth) ? `` : `//`) + ` compile "com.google.android.gms:play-services-auth:10.0.+"
+    ` + (isSelected(result.google_auth) ? `` : `//`) + ` compile "com.google.android.gms:play-services-auth:$googlePlayServicesVersion"
 
 }