Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit b7280d5

Browse files
error TS1036: Statements are not allowed in ambient contexts #685
1 parent 4914c00 commit b7280d5

File tree

5 files changed

+65
-30
lines changed

5 files changed

+65
-30
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@
44
[Firebase Android SDK Changelog](https://firebase.google.com/support/release-notes/android)
55

66

7+
## 5.3.1 (2018, April 26)
8+
9+
### Fixes
10+
- [#685](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/685) error TS1036: Statements are not allowed in ambient contexts
11+
12+
713
## 5.3.0 (2018, April 25)
814

915
### New

demo/app/main-view-model.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -377,6 +377,7 @@ export class HelloWorldModel extends Observable {
377377
}]
378378
}).then(
379379
() => {
380+
console.log("Analytics event logged");
380381
alert({
381382
title: "Analytics event pushed",
382383
okButtonText: "Awesome :)"

demo/package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
"nativescript-plugin-firebase": "^5.0.0",
1313
"nativescript-theme-core": "^1.0.4",
1414
"nativescript-unit-test-runner": "^0.3.4",
15-
"tns-core-modules": "~4.0.0"
15+
"tns-core-modules": "~4.0.0",
16+
"tns-ios": "4.0.1"
1617
},
1718
"devDependencies": {
1819
"@types/jasmine": "~2.8.0",
@@ -37,7 +38,7 @@
3738
"resolve-url-loader": "~2.1.0",
3839
"tns-platform-declarations": "^3.4.0",
3940
"tslint": "~5.4.3",
40-
"typescript": "~2.6.0",
41+
"typescript": "~2.8.0",
4142
"webpack": "~3.8.1",
4243
"webpack-bundle-analyzer": "^2.8.2",
4344
"webpack-sources": "~1.0.1",

src/firebase-common.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { prompt } from "tns-core-modules/ui/dialogs";
22
import { firestore } from "./firebase";
3-
import * as analytics from "./analytics";
3+
import * as analytics from "./analytics/analytics";
44
import * as applicationSettings from "tns-core-modules/application-settings";
55

66
export const firebase: any = {

src/package-lock.json

Lines changed: 54 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)