Firestore anytime soon? #507 (offline persistence)

Author: EddyVerbruggen

demo-ng/app/app.css

@@ -11,10 +11,15 @@ refer to http://docs.nativescript.org/ui/theme.
 */
 @import 'nativescript-theme-core/css/core.light.css';
 
+label {
+  padding: 6;
+  font-size: 14;
+  text-align: center;
+}
+
 .h2 {
-  font-size: 16;
+  font-size: 17;
   font-weight: bold;
-  text-align: center;
   margin: 22 0 0 0;
 }
 

demo-ng/app/item/items.component.html

@@ -1,8 +1,9 @@
-<ActionBar title="My App" class="action-bar">
+<ActionBar title="Firestore demo" class="action-bar" flat="true">
 </ActionBar>
 
 <ScrollView>
   <StackLayout class="page">
+    <Label text="After pressing those buttons, check the console log" textWrap="true"></Label>
     <Label text="Authentication" class="h2"></Label>
     <Button text="login anonymously" (tap)="loginAnonymously()" class="button button-user"></Button>
     <Label text="Firestore" class="h2"></Label>

demo-ng/app/item/items.component.ts

@@ -1,7 +1,5 @@
 import { Component, OnInit } from "@angular/core";
 import { firestore } from "nativescript-plugin-firebase";
-// import { firestore } from "nativescript-plugin-firebase/app/firestore";
-
 const firebase = require("nativescript-plugin-firebase/app");
 
 @Component({
@@ -15,7 +13,9 @@ export class ItemsComponent implements OnInit {
   }
 
   ngOnInit(): void {
-    firebase.initializeApp();
+    firebase.initializeApp({
+      persist: false
+    }).then(() => console.log("Firebase initialized"));
   }
 
   public loginAnonymously(): void {

src/app/index.ts

@@ -8,11 +8,8 @@ import { auth as firebaseAuthModule } from "./auth";
 import { database as firebaseDatabaseModule } from "./database";
 import { firestore as firebaseFirestoreModule } from "./firestore";
 
-export function initializeApp(options?: Object, name?: string): any /* TODO App object.. doesn't look too useful though */ {
-  firebase.init().then(
-      () => console.log("Firebase is ready"),
-      error => console.log("firebase.init error: " + error)
-  );
+export function initializeApp(options?: firebase.InitOptions, name? /* ignored */: string): Promise<any> {
+  return firebase.init(options);
 }
 
 let authCache;

src/firebase.android.ts

@@ -1,10 +1,10 @@
 import { firebase, QuerySnapshot } from "./firebase-common";
 import * as appModule from "tns-core-modules/application";
+import { AndroidActivityResultEventData } from "tns-core-modules/application";
 import * as utils from "tns-core-modules/utils/utils";
 import lazy from "tns-core-modules/utils/lazy";
 import * as frame from "tns-core-modules/ui/frame";
 import * as fs from "tns-core-modules/file-system";
-import { AndroidActivityResultEventData } from "tns-core-modules/application";
 import { firestore } from "./firebase";
 
 declare const com, org: any;
@@ -200,18 +200,25 @@ firebase.init = arg => {
 
       arg = arg || {};
 
-      firebase.ServerValue = {
-        TIMESTAMP: firebase.toJsObject(com.google.firebase.database.ServerValue.TIMESTAMP)
-      };
+      if (typeof(com.google.firebase.firestore) === "undefined") {
+        firebase.ServerValue = {
+          TIMESTAMP: firebase.toJsObject(com.google.firebase.database.ServerValue.TIMESTAMP)
+        };
 
-      const fDatabase = com.google.firebase.database.FirebaseDatabase;
-      if (arg.persist) {
-        fDatabase.getInstance().setPersistenceEnabled(true);
+        const fDatabase = com.google.firebase.database.FirebaseDatabase;
+        if (arg.persist) {
+          fDatabase.getInstance().setPersistenceEnabled(true);
+        }
+        firebase.instance = fDatabase.getInstance().getReference();
+      } else {
+        // Firestore has offline persistence enabled by default
+        if (!arg.persist) {
+          com.google.firebase.firestore.FirebaseFirestore.getInstance().setFirestoreSettings(
+              new com.google.firebase.firestore.FirebaseFirestoreSettings.Builder()
+                  .setPersistenceEnabled(false)
+                  .build());
+        }
       }
-      // the URL is picked up from google-services.json, so you can use it like this:
-      firebase.instance = fDatabase.getInstance().getReference();
-      // it is however still possible to pass the URL programmatically (which we'll do for now):
-      // firebase.instance = fDatabase.getInstance().getReferenceFromUrl(arg.url);
 
       const firebaseAuth = com.google.firebase.auth.FirebaseAuth.getInstance();
 

src/firebase.d.ts

@@ -75,7 +75,7 @@ export enum ServerValue {
  */
 export interface InitOptions {
   /**
-   * Allow disk persistence. Default false.
+   * Allow disk persistence. Default true for Firestore, false for regular Firebase DB.
    */
   persist?: boolean;
   /**

src/firebase.ios.ts

@@ -632,13 +632,19 @@ firebase.init = arg => {
 
       firebase._configure();
 
-      // TODO something for Firestore?
       if (typeof(FIRDatabase) !== "undefined") {
         if (arg.persist) {
           FIRDatabase.database().persistenceEnabled = true;
         }
 
         firebase.instance = FIRDatabase.database().reference();
+      } else if (typeof(FIRStorage) !== "undefined") {
+        // Firestore has offline persistence enabled by default
+        if (arg.persist === false) {
+          const fIRFirestoreSettings = FIRFirestoreSettings.new();
+          fIRFirestoreSettings.persistenceEnabled = false;
+          FIRFirestore.firestore().settings = fIRFirestoreSettings;
+        }
       }
 
       if (arg.iOSEmulatorFlush) {