Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit d6cc3cc

Browse files
Merge pull request #1050 from EddyVerbruggen/remote-config-fix-1048
fix(remote-config): resume event subscription not terminated
2 parents efb6cdb + 6a219c5 commit d6cc3cc

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/firebase.android.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -517,8 +517,6 @@ firebase.getRemoteConfig = arg => {
517517
}
518518

519519
const runGetRemoteConfig = () => {
520-
appModule.off(appModule.resumeEvent, runGetRemoteConfig);
521-
522520
if (!firebase._isGooglePlayServicesAvailable()) {
523521
reject("Google Play services is required for this feature, but not available on this device");
524522
return;
@@ -586,7 +584,11 @@ firebase.getRemoteConfig = arg => {
586584
runGetRemoteConfig();
587585
} else {
588586
// if this is called before application.start(), wait for the event to fire
589-
appModule.on(appModule.resumeEvent, runGetRemoteConfig);
587+
const callback = () => {
588+
runGetRemoteConfig();
589+
appModule.off(appModule.resumeEvent, callback);
590+
};
591+
appModule.on(appModule.resumeEvent, callback);
590592
}
591593
} catch (ex) {
592594
console.log("Error in firebase.getRemoteConfig: " + ex);

0 commit comments

Comments
 (0)