Merge pull request #734 from NathanWalker/ios-10-google-login-compat

fix(iOS): google auth issue for iOS 10 and below

Author: EddyVerbruggen

docs/AUTHENTICATION.md

@@ -536,6 +536,32 @@ Make sure the URL Scheme for `REVERSED_CLIENT_ID` is in `app/App_Resources/iOS/I
 	</array>
 ```
 
+*NOTE:* iOS 10 and below issue for Google Auth when opening from a modal.
+
+If you are planning to open Google Auth from a modal view you may encounter this error resulting in nothing happening (no google auth dialog) on iOS 10 and below:
+
+```
+Warning: Attempt to present <SFSafariViewController: 0x7fa575968470> on <UILayoutViewController: 0x7fa575e3d710> whose view is not in the window hierarchy!
+```
+
+To solve, you will want to pass in the appropriate iOS controller of the active view. This can be accomplished as follows:
+
+```js
+  firebase.login({
+    type: firebase.LoginType.GOOGLE,
+    ios: {
+      controller: topmost().ios.controller
+    }
+  }).then(
+      function (result) {
+        JSON.stringify(result);
+      },
+      function (errorMessage) {
+        console.log(errorMessage);
+      }
+  );
+```
+
 #### Android
 
 1. If you didn't choose this feature during installation you can uncomment `google-services-auth` in `node_modules\nativescript-plugin-firebase\platforms\android\include.gradle`

src/firebase.d.ts

@@ -236,6 +236,10 @@ export interface FirebaseCustomLoginOptions {
   tokenProviderFn?: () => Promise<String>;
 }
 
+export interface LoginIOSOptions {
+  controller?: any;
+}
+
 /**
  * The options object passed into the login function.
  */
@@ -247,6 +251,7 @@ export interface LoginOptions {
   googleOptions?: FirebaseGoogleLoginOptions;
   facebookOptions?: FirebaseFacebookLoginOptions;
   customOptions?: FirebaseCustomLoginOptions;
+  ios?: LoginIOSOptions;
 
   /**
    * @deprecated Please use the 'passwordOptions?: FirebasePasswordLoginOptions' object instead.

src/firebase.ios.ts

@@ -1367,7 +1367,8 @@ firebase.login = arg => {
         }
 
         const sIn = GIDSignIn.sharedInstance();
-        sIn.uiDelegate = application.ios.rootController;
+        // allow custom controller for variety of use cases
+        sIn.uiDelegate = arg.ios && arg.ios.controller ? arg.ios.controller : application.ios.rootController;
         sIn.clientID = FIRApp.defaultApp().options.clientID;
 
         if (arg.googleOptions && arg.googleOptions.hostedDomain) {