Feature Request: Support crash log API #307

Author: EddyVerbruggen

CHANGELOG.md

@@ -1,6 +1,29 @@
 <img src="docs/images/firebase-logo.png" width="116px" height="32px" alt="Firebase"/>
 
 
+## 3.10.2 (2017, March 12)
+
+[Full changelog](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/compare/3.10.1...3.10.2)
+
+### SDK versions
+
+If version numbers __changed__, clean your platform folders to avoid build errors.
+Also, for Android update your Google Repository in the Android SDK manager (type `android` on the command prompt),
+and for iOS do a `pod repo update` to fetch the latest versions from Cocoapods.
+
+- iOS: 3.13.x
+- Android: 10.2.x
+
+### New
+- [#307](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/307) Feature Request: Support crash log API
+
+### Fixes
+- [#272](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/272) Unusual error message when retrieving data set and binding to layout
+- [#292](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/292) Nativescript app is not running with Firebase in IOS. 
+
+
+
+
 ## 3.10.1 (2017, February 22)
 
 [Full changelog](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/compare/3.10.0...3.10.1)

firebase.android.js

@@ -1729,7 +1729,6 @@ firebase.unsubscribeFromTopic = function(topicName){
   }); 
 };
 
-/*
 firebase.sendCrashLog = function (arg) {
   return new Promise(function (resolve, reject) {
     try {
@@ -1739,19 +1738,18 @@ firebase.sendCrashLog = function (arg) {
         return;
       }
 
-      if (!arg.log) {
-        reject("The mandatory 'log' argument is missing");
+      if (!arg.message) {
+        reject("The mandatory 'message' argument is missing");
         return;
       }
 
-      com.google.firebase.crash.FirebaseCrash.log(arg.log);
+      com.google.firebase.crash.FirebaseCrash.log(arg.message);
       resolve();
     } catch (ex) {
       console.log("Error in firebase.sendCrashLog: " + ex);
       reject(ex);
     }
   });
 };
-*/
 
 module.exports = firebase;

firebase.d.ts

@@ -459,7 +459,12 @@ export interface SendCrashLogOptions {
     /**
      * Any custom logging you want to send to Firebase.
      */
-    log: string;
+    message: string;
+
+    /**
+     * Also log to the device console. Default false.
+     */
+    showInConsole: boolean;
 }
 
 export function init(options?: InitOptions): Promise<any>;
@@ -665,5 +670,6 @@ export function deleteFile(options: DeleteFileOptions): Promise<any>;
 export function subscribeToTopic(topicName): Promise<any>;
 
 export function unsubscribeFromTopic(topicName): Promise<any>;
+
 // crash logging
-// export function sendCrashLog(options: SendCrashLogOptions): Promise<any>;
+export function sendCrashLog(options: SendCrashLogOptions): Promise<any>;

firebase.ios.js

@@ -1742,37 +1742,34 @@ firebase.unsubscribeFromTopic = function(topicName){
       reject(ex);
     }
   });
-}
+};
+
+firebase.sendCrashLog = function (arg) {
+  return new Promise(function (resolve, reject) {
+    try {
+      if (typeof(FIRCrashLog) === "undefined") {
+        reject("Make sure 'Firebase/Crash' is in the plugin's Podfile - and if it is there's currently a problem with this Pod which is outside out span of control :(");
+        return;
+      }
+
+      if (!arg.message) {
+        reject("The mandatory 'message' argument is missing");
+        return;
+      }
 
-/*
- firebase.sendCrashLog = function (arg) {
- return new Promise(function (resolve, reject) {
- try {
-
- if (typeof(FIRCrashLog) === "undefined") {
- reject("Make sure 'Firebase/Crash' is in the plugin's Podfile");
- return;
- }
-
- if (!arg.log) {
- reject("The mandatory 'log' argument is missing");
- return;
- }
-
- if (showInConsole) {
- FIRCrashNSLog(arg.log);
- } else {
- FIRCrashLog(arg.log);
- }
-
- resolve();
- } catch (ex) {
- console.log("Error in firebase.sendCrashLog: " + ex);
- reject(ex);
- }
- });
- };
- */
+      if (arg.showInConsole) {
+        FIRCrashNSLog(arg.message);
+      } else {
+        FIRCrashLog(arg.message);
+      }
+
+      resolve();
+    } catch (ex) {
+      console.log("Error in firebase.sendCrashLog: " + ex);
+      reject(ex);
+    }
+  });
+};
 
 var GADBannerViewDelegateImpl = (function (_super) {
   __extends(GADBannerViewDelegateImpl, _super);