Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit ea4b26e

Browse files
Merge pull request #501 from derTuca/add-null-callback-option
Added null check for updateCallback on query
2 parents 948f4b3 + 44ac2a9 commit ea4b26e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

firebase.android.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1677,12 +1677,12 @@ firebase.query = function (updateCallback, path, options) {
16771677
var listener = new com.google.firebase.database.ValueEventListener({
16781678
onDataChange: function (snapshot) {
16791679
var data = firebase.getCallbackData('ValueChanged', snapshot);
1680-
updateCallback(data);
1680+
if(updateCallback) updateCallback(data);
16811681
// resolve promise with data in case of single event, see https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/126
16821682
resolve(data);
16831683
},
16841684
onCancelled: function (databaseError) {
1685-
updateCallback({
1685+
if(updateCallback) updateCallback({
16861686
error: databaseError.getMessage()
16871687
});
16881688
// see comment at 'onDataChange'

firebase.ios.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1728,7 +1728,7 @@ firebase.query = function (updateCallback, path, options) {
17281728

17291729
if (options.singleEvent) {
17301730
query.observeSingleEventOfTypeWithBlock(FIRDataEventType.FIRDataEventTypeValue, function (snapshot) {
1731-
updateCallback(firebase.getCallbackData('ValueChanged', snapshot));
1731+
if(updateCallback) updateCallback(firebase.getCallbackData('ValueChanged', snapshot));
17321732
// resolve promise with data in case of single event, see https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/126
17331733
resolve(firebase.getCallbackData('ValueChanged', snapshot));
17341734
});

0 commit comments

Comments
 (0)