Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit f782266

Browse files
App won't launch due to version mismatch between Google Analytics and Google App Measurement #1061
1 parent 9a4b732 commit f782266

File tree

7 files changed

+32
-26
lines changed

7 files changed

+32
-26
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
- [Firebase iOS SDK Changelog](https://firebase.google.com/support/release-notes/ios)
44
- [Firebase Android SDK Changelog](https://firebase.google.com/support/release-notes/android)
55

6+
## 7.4.4 (2018, December 8)
7+
[Fixes & Enhancements](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/milestone/85?closed=1)
8+
9+
610
## 7.4.3 (2018, December 3)
711
[Fixes & Enhancements](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/milestone/84?closed=1)
812

demo-ng/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"nativescript-angular": "^6.1.0",
2626
"nativescript-camera": "^4.0.2",
2727
"nativescript-imagepicker": "~6.0.4",
28-
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-7.4.3.tgz",
28+
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-7.4.4.tgz",
2929
"nativescript-theme-core": "~1.0.4",
3030
"reflect-metadata": "~0.1.10",
3131
"rxjs": "~6.0.0 || >=6.1.0",

demo-push/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,4 @@
4343
"build.plugin": "cd ../src && npm run build",
4444
"ci.tslint": "npm i && tslint --config '../tslint.json' 'app/**/*.ts' --exclude '**/node_modules/**' --exclude '**/typings/**'"
4545
}
46-
}
46+
}

demo/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
},
1111
"dependencies": {
1212
"firebase-functions": "^2.0.5",
13-
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-7.4.3.tgz",
13+
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-7.4.4.tgz",
1414
"nativescript-theme-core": "^1.0.4",
1515
"nativescript-unit-test-runner": "^0.3.4",
1616
"tns-core-modules": "~5.0.5"

publish/scripts/installer.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,7 @@ function writePodFile(result) {
333333
(isPresent(result.ml_kit) ? `` : `#`) + `platform :ios, '9.0'
334334
335335
pod 'Firebase/Core', '~> 5.12.0'
336+
pod 'GoogleAppMeasurement', '5.3' # temp fix for https://github.com/firebase/firebase-ios-sdk/issues/2151 (remove when bumping 'Firebase/Core')
336337
337338
# Authentication
338339
` + (!isPresent(result.authentication) || isSelected(result.authentication) ? `` : `#`) + `pod 'Firebase/Auth'

src/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nativescript-plugin-firebase",
3-
"version": "7.4.3",
3+
"version": "7.4.4",
44
"description": "Fire. Base. Firebase!",
55
"main": "firebase",
66
"typings": "index.d.ts",

src/scripts/postinstall.js

Lines changed: 23 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -2730,28 +2730,28 @@ function read (opts, cb) {
27302730
\***********************************/
27312731
/***/ (function(module, exports) {
27322732

2733-
module.exports = function(module) {
2734-
if(!module.webpackPolyfill) {
2735-
module.deprecate = function() {};
2736-
module.paths = [];
2737-
// module.parent = undefined by default
2738-
if(!module.children) module.children = [];
2739-
Object.defineProperty(module, "loaded", {
2740-
enumerable: true,
2741-
get: function() {
2742-
return module.l;
2743-
}
2744-
});
2745-
Object.defineProperty(module, "id", {
2746-
enumerable: true,
2747-
get: function() {
2748-
return module.i;
2749-
}
2750-
});
2751-
module.webpackPolyfill = 1;
2752-
}
2753-
return module;
2754-
};
2733+
module.exports = function(module) {
2734+
if(!module.webpackPolyfill) {
2735+
module.deprecate = function() {};
2736+
module.paths = [];
2737+
// module.parent = undefined by default
2738+
if(!module.children) module.children = [];
2739+
Object.defineProperty(module, "loaded", {
2740+
enumerable: true,
2741+
get: function() {
2742+
return module.l;
2743+
}
2744+
});
2745+
Object.defineProperty(module, "id", {
2746+
enumerable: true,
2747+
get: function() {
2748+
return module.i;
2749+
}
2750+
});
2751+
module.webpackPolyfill = 1;
2752+
}
2753+
return module;
2754+
};
27552755

27562756

27572757
/***/ }),
@@ -3131,6 +3131,7 @@ function writePodFile(result) {
31313131
(isPresent(result.ml_kit) ? `` : `#`) + `platform :ios, '9.0'
31323132
31333133
pod 'Firebase/Core', '~> 5.12.0'
3134+
pod 'GoogleAppMeasurement', '5.3' # temp fix for https://github.com/firebase/firebase-ios-sdk/issues/2151 (remove when bumping 'Firebase/Core')
31343135
31353136
# Authentication
31363137
` + (!isPresent(result.authentication) || isSelected(result.authentication) ? `` : `#`) + `pod 'Firebase/Auth'

0 commit comments

Comments
 (0)