[BUG] Reference Error with version 4.2.0 #531

Author: EddyVerbruggen

CHANGELOG.md

@@ -4,6 +4,12 @@
 [Firebase Android SDK Changelog](https://firebase.google.com/support/release-notes/android)
 
 
+## 4.2.1 (2017, October 24)
+
+### Fixes
+- [#531](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/531) [BUG] Reference Error with version 4.2.0
+
+
 ## 4.2.0 (2017, October 24)
 
 ### New

demo/references.d.ts

@@ -1,18 +1,2 @@
 /// <reference path="./node_modules/tns-platform-declarations/ios.d.ts" />
-/// <reference path="./node_modules/tns-platform-declarations/android.d.ts" />
-
-/// <reference path="../src/platforms/ios/typings/objc!FBSDKCoreKit.d.ts" />
-/// <reference path="../src/platforms/ios/typings/objc!FBSDKLoginKit.d.ts" />
-/// <reference path="../src/platforms/ios/typings/objc!FirebaseAnalytics.d.ts" />
-/// <reference path="../src/platforms/ios/typings/objc!FirebaseAuth.d.ts" />
-/// <reference path="../src/platforms/ios/typings/objc!FirebaseCore.d.ts" />
-/// <reference path="../src/platforms/ios/typings/objc!FirebaseCrash.d.ts" />
-/// <reference path="../src/platforms/ios/typings/objc!FirebaseDatabase.d.ts" />
-/// <reference path="../src/platforms/ios/typings/objc!FirebaseDynamicLinks.d.ts" />
-/// <reference path="../src/platforms/ios/typings/objc!FirebaseInstanceID.d.ts" />
-/// <reference path="../src/platforms/ios/typings/objc!FirebaseInvites.d.ts" />
-/// <reference path="../src/platforms/ios/typings/objc!FirebaseMessaging.d.ts" />
-/// <reference path="../src/platforms/ios/typings/objc!FirebaseRemoteConfig.d.ts" />
-/// <reference path="../src/platforms/ios/typings/objc!FirebaseStorage.d.ts" />
-/// <reference path="../src/platforms/ios/typings/objc!GoogleMobileAds.d.ts" />
-/// <reference path="../src/platforms/ios/typings/objc!GoogleSignIn.d.ts" />
+/// <reference path="./node_modules/tns-platform-declarations/android.d.ts" />

src/firebase.ios.ts

@@ -474,7 +474,6 @@ firebase._registerForRemoteNotifications = function () {
   }
 };
 
-// TODO test & fix
 function getAppDelegate() {
   // Play nice with other plugins by not completely ignoring anything already added to the appdelegate
   if (application.ios.delegate === undefined) {
@@ -2193,9 +2192,12 @@ firebase.invites.getInvitation = function () {
 
 // see https://developer.apple.com/reference/usernotifications/unusernotificationcenterdelegate?language=objc
 class UNUserNotificationCenterDelegateImpl extends NSObject implements UNUserNotificationCenterDelegate {
-  public static ObjCProtocols = [UNUserNotificationCenterDelegate];
+  public static ObjCProtocols = [];
 
   static new(): UNUserNotificationCenterDelegateImpl {
+    if (UNUserNotificationCenterDelegateImpl.ObjCProtocols.length === 0 && typeof(UNUserNotificationCenterDelegate) !== "undefined") {
+      UNUserNotificationCenterDelegateImpl.ObjCProtocols.push(UNUserNotificationCenterDelegate);
+    }
     return <UNUserNotificationCenterDelegateImpl>super.new();
   }
 
@@ -2212,9 +2214,12 @@ class UNUserNotificationCenterDelegateImpl extends NSObject implements UNUserNot
 }
 
 class FIRInviteDelegateImpl extends NSObject implements FIRInviteDelegate {
-  public static ObjCProtocols = [FIRInviteDelegate];
+  public static ObjCProtocols = [];
 
   static new(): FIRInviteDelegateImpl {
+    if (FIRInviteDelegateImpl.ObjCProtocols.length === 0 && typeof(FIRInviteDelegate) !== "undefined") {
+      FIRInviteDelegateImpl.ObjCProtocols.push(FIRInviteDelegate);
+    }
     return <FIRInviteDelegateImpl>super.new();
   }
 
@@ -2231,9 +2236,12 @@ class FIRInviteDelegateImpl extends NSObject implements FIRInviteDelegate {
 }
 
 class FIRMessagingDelegateImpl extends NSObject implements FIRMessagingDelegate {
-  public static ObjCProtocols = [FIRMessagingDelegate];
+  public static ObjCProtocols = [];
 
   static new(): FIRMessagingDelegateImpl {
+    if (FIRMessagingDelegateImpl.ObjCProtocols.length === 0 && typeof(FIRMessagingDelegate) !== "undefined") {
+      FIRMessagingDelegateImpl.ObjCProtocols.push(FIRMessagingDelegate);
+    }
     return <FIRMessagingDelegateImpl>super.new();
   }
 
@@ -2259,9 +2267,12 @@ class FIRMessagingDelegateImpl extends NSObject implements FIRMessagingDelegate
 }
 
 class GADInterstitialDelegateImpl extends NSObject implements GADInterstitialDelegate {
-  public static ObjCProtocols = [GADInterstitialDelegate];
+  public static ObjCProtocols = [];
 
   static new(): GADInterstitialDelegateImpl {
+    if (GADInterstitialDelegateImpl.ObjCProtocols.length === 0 && typeof(GADInterstitialDelegate) !== "undefined") {
+      GADInterstitialDelegateImpl.ObjCProtocols.push(GADInterstitialDelegate);
+    }
     return <GADInterstitialDelegateImpl>super.new();
   }
 
@@ -2282,9 +2293,12 @@ class GADInterstitialDelegateImpl extends NSObject implements GADInterstitialDel
 }
 
 class GIDSignInDelegateImpl extends NSObject implements GIDSignInDelegate {
-  public static ObjCProtocols = [GIDSignInDelegate];
+  public static ObjCProtocols = [];
 
   static new(): GIDSignInDelegateImpl {
+    if (GIDSignInDelegateImpl.ObjCProtocols.length === 0 && typeof(GIDSignInDelegate) !== "undefined") {
+      GIDSignInDelegateImpl.ObjCProtocols.push(GIDSignInDelegate);
+    }
     return <GIDSignInDelegateImpl>super.new();
   }
 

src/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nativescript-plugin-firebase",
-  "version": "4.2.0",
+  "version": "4.2.1",
   "description": "Fire. Base. Firebase!",
   "main": "firebase",
   "typings": "index.d.ts",