Sync skills and rules from ~/.cursor

- typescript-standards: Add generic-component-fc-exception pattern,
  update no-deprecated NavigationBase pointer to /fix-eslint skill
- im/SKILL.md: Document update-eslint-warnings.ts graduation mechanism
- fix-eslint/SKILL.md: Updated navigation-base pattern (from prior session)

TODO: lint-warnings.sh only reads patterns from typescript-standards.mdc.
It should also load patterns from /fix-eslint SKILL.md (or a shared
patterns file) so detailed fix guidance is front-loaded in terminal output.

Author: j0ntz

.cursor/rules/typescript-standards.mdc

@@ -183,7 +183,7 @@ Fix: Add return type annotation. Common types:
 
 <pattern id="no-deprecated" rule="@typescript-eslint/no-deprecated">Using deprecated API.
 Fix: Check the deprecation message for the replacement API. Common replacements:
-- `NavigationBase` → `EdgeAppSceneProps<'routeName'>['navigation']`
+- `NavigationBase` → Read `/fix-eslint` skill `navigation-base` pattern for category-based fix guidance
 - `uniqueIdentifier` → `EdgeSpendInfo.memos`
 - `memo` → `EdgeSpendInfo.memos`
 - `networkFee` / `parentNetworkFee` → `networkFees`
@@ -203,6 +203,13 @@ Fix: Rename handler to match the prop pattern.
 ✅ `export const Component: React.FC<Props> = props => {`
 </pattern>
 
+<pattern id="generic-component-fc-exception" rule="edge/react-fc-component-definition">Generic components cannot use `React.FC` because it does not support type parameters.
+If the generic is not essential (type param only used internally, can be collapsed into a concrete type), remove the generic and convert to `React.FC<Props>`.
+If the generic is essential (callers rely on type inference, e.g. `<EdgeCarousel<MyItem> ...>`), keep the function declaration form with an explicit return type. The warning is accepted.
+✅ `export function MyComponent<T>(props: Props<T>): React.ReactElement {`
+❌ Converting an essential generic to `React.FC` — this loses type safety for callers.
+</pattern>
+
 <pattern id="no-styled" rule="no-restricted-syntax">Avoid `styled()` wrapper components.
 Fix: Convert to regular component using `useTheme()` and `cacheStyles()`.
 ❌ `const StyledView = styled(View)(theme => ({ ... }))`

.cursor/skills/chat-audit/SKILL.md

@@ -6,7 +6,7 @@ metadata:
   author: j0ntz
 ---
 
-<goal>Analyze a Cursor chat export to identify inefficiencies, rule violations, and wasted tool calls against the invoked command's workflow.</goal>
+<goal>Analyze current chat or provided Cursor chat export to identify inefficiencies, rule violations, and wasted tool calls against the invoked command's workflow.</goal>
 
 <rules description="Non-negotiable constraints.">
 <rule id="use-companion-script">Use `scripts/cursor-chat-extract.js` to parse the export. Do NOT parse the raw JSON inline — it is deeply nested and will consume excessive context.</rule>

.cursor/skills/fix-eslint/SKILL.md

@@ -7,42 +7,81 @@ description: Fix ESLint warnings by applying documented patterns. Use when addre
 
 <rules description="Non-negotiable constraints.">
 <rule id="tsc-after-fix">Run `npx tsc --noEmit` after every type change to verify no new type errors are introduced.</rule>
-<rule id="no-suppress">Do not suppress deprecation warnings with `eslint-disable` comments. Fix the underlying type reference.</rule>
+<rule id="no-suppress">Do not suppress deprecation warnings with `eslint-disable` comments. Fix the underlying type reference.
+Exception: `NavigationBase` deprecation in shared cross-navigator code (Categories C, D, F below) is accepted — not suppressed, genuinely not fixable without a broader v7 navigation migration. When the fix scope is too broad, add a TODO comment documenting the required migration pattern and accept the warning.</rule>
 <rule id="scope-control">Only modify files with deprecation warnings. Do not refactor downstream declarations unless required for the fix to compile.</rule>
 </rules>
 
 <patterns>
 
 <pattern id="navigation-base" rule="@typescript-eslint/no-deprecated" symbol="NavigationBase">
-`NavigationBase` is a flat navigation type that predates react-navigation's composite `XyzSceneProps` types. It cannot be replaced with scene-specific types in shared code due to variance constraints in composite navigation props.
+`NavigationBase` is a flat navigation type hack in `routerTypes.tsx` that unions all navigator param lists (`RootParamList & DrawerParamList & EdgeAppStackParamList & ...`) to pretend the app is flat. It is deprecated because it tracks **react-navigation v7 breaking changes**:
 
-**In scene components** (call sites):
-Replace `navigation as NavigationBase` casts with `navigation as AppNavigation`:
+1. `navigate()` no longer crosses nested navigator boundaries at runtime.
+2. `navigate()` no longer goes back to an existing screen to update params — use `popTo()` or `navigate(screen, params, { pop: true })` instead.
 
+v7 provides `navigateDeprecated()` and `navigationInChildEnabled` as temporary bridges, both removed in v8. **Do NOT create non-deprecated aliases** (like `AppNavigation`) — this hides a real migration requirement.
+
+Fix `NavigationBase` deprecation by identifying which category the usage falls into:
+
+**Category A — Pass-through props** (component accepts `NavigationBase` only to forward it to children or actions):
+- Fix: Remove the `navigation` prop. Callers already have navigation in scope. If the child needs navigation, it should use `useNavigation()` or accept specific callbacks.
 ```typescript
-// Before
-import type { NavigationBase } from '../../types/routerTypes'
-activateWalletTokens(navigation as NavigationBase, wallet, [tokenId])
+// Before — CancellableProcessingScene accepts navigation to forward to onError
+interface Props { navigation: NavigationBase; onError: (nav: NavigationBase, err: unknown) => void }
 
-// After
-import type { AppNavigation } from '../../types/routerTypes'
-activateWalletTokens(navigation as AppNavigation, wallet, [tokenId])
+// After — remove navigation prop, callers handle navigation in callbacks
+interface Props { onError: (err: unknown) => Promise<void> }
 ```
 
-**In shared actions/utilities** (declaration sites):
-Replace `NavigationBase` parameter types with `AppNavigation`:
-
+**Category B — Direct navigation in non-scene components** (component accepts `NavigationBase`, calls `navigate()`/`push()` directly):
+- Fix: Replace `navigation: NavigationBase` prop with `useNavigation()` hook typed to the navigator context the component lives in. Or replace with specific navigation callbacks from the parent scene.
 ```typescript
-// Before
-import type { NavigationBase } from '../types/routerTypes'
-export function myAction(navigation: NavigationBase): ThunkAction<...> {
+// Before — BalanceCard accepts NavigationBase, calls navigate directly
+interface Props { navigation: NavigationBase }
+const BalanceCard: React.FC<Props> = props => {
+  props.navigation.push('send2', { walletId, tokenId })
+}
+
+// After (option 1) — useNavigation hook
+const BalanceCard: React.FC<Props> = props => {
+  const navigation = useNavigation<EdgeAppSceneProps<'home'>['navigation']>()
+  navigation.push('send2', { walletId, tokenId })
+}
+
+// After (option 2) — navigation callbacks
+interface Props { onSend: (walletId: string, tokenId: EdgeTokenId) => void }
+```
+- If the fix would cascade to many callers or require determining the correct navigator context across multiple usages, add a `// TODO: Replace NavigationBase with useNavigation() or callbacks. Requires v7 navigation migration.` comment and move on.
 
-// After
-import type { AppNavigation } from '../types/routerTypes'
-export function myAction(navigation: AppNavigation): ThunkAction<...> {
+**Category C — Shared action/thunk functions** (functions in `src/actions/` accept `NavigationBase`):
+- Fix: Invert control. Replace the `navigation: NavigationBase` parameter with a callback for the navigation action the function needs.
+```typescript
+// Before — function navigates internally
+function activateWalletTokens(navigation: NavigationBase, wallet, tokenIds): ThunkAction<Promise<void>> {
+  // ... calls navigation.navigate('editToken', ...) internally
+}
+
+// After — caller provides the navigate action
+function activateWalletTokens(wallet, tokenIds, onNavigate: (route: string, params: object) => void): ThunkAction<Promise<void>> {
+  // ... calls onNavigate('editToken', ...) instead
+}
 ```
+- Simpler alternative for single-navigate functions: Return the target route + params instead of navigating; let the caller dispatch.
+- If the function has many navigate calls to different screens or the refactoring would touch many callers, add a `// TODO: Remove NavigationBase dependency. Requires inversion of navigation control for v7 migration.` comment and move on.
+
+**Category D — Shared modal components** (modals accept `NavigationBase`, navigate after user interaction):
+- Fix: Modal returns a result via Airship bridge resolve; caller handles navigation based on the result. Or modal accepts navigation callbacks.
+- If the modal's navigation logic is complex (multiple paths), add a comment and move on.
+
+**Category E — Scene component casts** (`navigation as NavigationBase`):
+- These casts exist because the scene passes navigation to a Category A-D consumer.
+- Fix: No direct fix needed — casts disappear automatically when the consumer is migrated.
+- If the scene has its own `NavigationBase` usage unrelated to shared code, apply Category B fix.
 
-**Why `as` casts are still required**: Composite scene navigation types (e.g. `WalletsTabSceneProps<'transactionList'>['navigation']`) are not structurally assignable to flat navigation types due to `PrivateValueStore` phantom types and contravariance in `dispatch`. The cast is the intended escape hatch.
+**Category F — Service components** (non-scene services: `DeepLinkingManager`, `AccountCallbackManager`, etc.):
+- These are the broadest migration cases. Always add: `// TODO: Remove NavigationBase dependency. Requires broader v7 navigation migration for service-level navigation.`
+- Do not attempt to fix these incrementally — they are cross-cutting and require dedicated migration work.
 </pattern>
 
 <pattern id="route-prop" rule="@typescript-eslint/no-deprecated" symbol="RouteProp">

.cursor/skills/im/SKILL.md

@@ -81,6 +81,8 @@ If the script auto-fixes files or remaining findings exist:
 `lint-commit.sh` treats passed file arguments as the primary commit scope, auto-includes generated companion files like `src/locales/strings`, `eslint.config.mjs`, and snapshots, and reports any additional non-generated files it stages.
 
 This ensures the subsequent feature commit introduces zero pre-existing lint findings. This is the initial pass — if you discover additional files to modify during Step 3, the same check applies (see Step 3).
+
+**Warning graduation (edge-react-gui)**: `edge-react-gui` has a suppression list in `eslint.config.mjs` that turns `explicit-function-return-type`, `strict-boolean-expressions`, `use-unknown-in-catch-callback-variable`, and `ban-ts-comment` to warning severity for ~300+ files. When `lint-commit.sh` commits a file, `update-eslint-warnings.ts` removes it from this list — "graduating" the file to full error enforcement. If a graduated file has pre-existing violations on lines you touched, `lint-commit.sh` Step 2b will block the commit. Running `lint-warnings.sh` here in Step 2 catches and fixes these issues before graduation occurs.
 </step>
 
 <step id="3" name="Implementation">