Add code review agents.

Author: paullinator

.cursor/agents/review-async.md

@@ -0,0 +1,68 @@
+---
+name: review-async
+description: Reviews code for async patterns including timers, data loading, and background services. Use when reviewing files with setInterval, async functions, or service components.
+---
+
+Review the branch/pull request in context for async pattern conventions.
+
+## Context Expected
+
+You will receive:
+- Repository name
+- Branch name
+- List of changed files to review
+
+## How to Review
+
+1. Read the changed files provided in context
+2. Look for setInterval, async data loading, background work
+3. Verify async patterns follow conventions
+4. Report findings with specific file:line references
+
+---
+
+## Never Use setInterval
+
+Always use `makePeriodicTask` instead, especially when async work is involved:
+
+```typescript
+// Incorrect
+setInterval(() => fetchData(), 5000)
+
+// Correct
+const task = makePeriodicTask(async () => {
+  await fetchData()
+}, 5000)
+task.start()
+// ... later
+task.stop()
+```
+
+---
+
+## Use TanStack Query or useAsyncValue
+
+For async data loading in components, use TanStack Query:
+
+```typescript
+import { useQuery } from '@tanstack/react-query'
+
+const { data, isLoading } = useQuery({
+  queryKey: ['myData'],
+  queryFn: fetchMyData
+})
+```
+
+Or use existing `useAsyncValue` hook. Don't re-implement async loading patterns.
+
+---
+
+## Background Services
+
+Background services go in `components/services/` directory:
+
+> "If we did want a persistent background service, it would go in components/services. Making it a component means it gets mounted/unmounted cleanly when we log in/out, and we can also see all the background stuff in one place."
+
+Avoid too much background work. Consider:
+- Triggering only when the user has pending items
+- Running only when on the relevant scene

.cursor/agents/review-cleaners.md

@@ -0,0 +1,76 @@
+---
+name: review-cleaners
+description: Reviews code for cleaner library usage and data validation patterns. Use when reviewing files that handle external data (API responses, disk reads).
+---
+
+Review the branch/pull request in context for cleaner usage conventions.
+
+## Context Expected
+
+You will receive:
+- Repository name
+- Branch name
+- List of changed files to review
+
+## How to Review
+
+1. Read the changed files provided in context
+2. Look for `fetch`, API calls, file reads, or external data sources
+3. Verify cleaners are applied before data is used
+4. Check for type/cleaner duplication
+5. Report findings with specific file:line references
+
+---
+
+## Clean All External Data
+
+All network requests and data reads from disk must be cleaned with the cleaners library. Code must access the cleaned values, not the original raw/untyped data object.
+
+---
+
+## Let Cleaners Handle Parsing
+
+Use cleaners for JSON parsing instead of double-parsing:
+
+```typescript
+// Incorrect
+const data = JSON.parse(response)
+const cleaned = asMyType(data)
+
+// Correct - let cleaners handle it
+const asMyResponse = asJSON(asObject({
+  field: asString
+}))
+const cleaned = asMyResponse(response)
+```
+
+---
+
+## No Duplicate Types
+
+Types should be derived from cleaners using `ReturnType` syntax. Do not duplicate type definitions:
+
+```typescript
+// Incorrect - duplicated type
+interface MyData {
+  name: string
+  value: number
+}
+const asMyData = asObject({
+  name: asString,
+  value: asNumber
+})
+
+// Correct - derive type from cleaner
+const asMyData = asObject({
+  name: asString,
+  value: asNumber
+})
+type MyData = ReturnType<typeof asMyData>
+```
+
+---
+
+## Remove Unused Fields
+
+Remove or comment out any fields in a cleaner that are unused in the codebase.

.cursor/agents/review-code-quality.md

@@ -0,0 +1,148 @@
+---
+name: review-code-quality
+description: Reviews code for general quality patterns including naming, dead code, and code organization. Use for general code quality review.
+---
+
+Review the branch/pull request in context for code quality conventions.
+
+## Context Expected
+
+You will receive:
+- Repository name
+- Branch name
+- List of changed files to review
+
+## How to Review
+
+1. Read the changed files provided in context
+2. Check for naming, dead code, organization issues
+3. Verify code quality follows conventions
+4. Report findings with specific file:line references
+
+---
+
+## Delete Unnecessary Code
+
+Don't leave dead or unused code in the codebase:
+
+```typescript
+// Incorrect - leaving unused code "just in case"
+const unusedVariable = calculateSomething()
+// Maybe useful later?
+
+// Correct - delete it
+// (If needed later, git history has it)
+```
+
+---
+
+## Use Meaningful Variable Names
+
+Avoid abbreviations that aren't immediately clear:
+
+```typescript
+// Incorrect - unclear abbreviation
+const kavProps = { ... }
+
+// Correct - descriptive name
+const avoidKeyboard = { ... }
+// or
+const keyboardAvoidingProps = { ... }
+```
+
+---
+
+## Put Parameters Inline
+
+Don't declare variables just to pass them to a function:
+
+```typescript
+// Incorrect - old pattern
+const params = {
+  txid: transaction.txid,
+  tokenId: tokenId,
+  metadata: metadataToSave
+}
+await wallet.saveTxMetadata(params)
+
+// Correct - inline parameters
+await wallet.saveTxMetadata({
+  txid: transaction.txid,
+  tokenId: tokenId,
+  metadata: metadataToSave
+})
+```
+
+Only exception is when calling a function that has unknown type parameters. Use a typed constant to ensure the call provides the correct parameters:
+
+```typescript
+interface CreateUserBody {
+  username: string
+  email: string
+  role: 'admin' | 'user'
+}
+
+// Correct - typed constant ensures body matches expected schema
+const body: CreateUserBody = {
+  username: 'john',
+  email: 'john@example.com',
+  role: 'admin'
+}
+await fetch('/api/users', {
+  method: 'POST',
+  body: JSON.stringify(body)
+})
+```
+
+This pattern catches type errors at compile time when the API contract changes.
+
+---
+
+## Use Existing Helpers
+
+Use existing helper functions instead of creating new ones:
+
+```typescript
+// Incorrect - creating redundant helper
+const getCurrencyCodeMultiplier = (config, code) => { ... }
+
+// Correct - use existing helper
+const { multiplier } = getExchangeDenom(currencyConfig, tokenId)
+```
+
+Before creating a new utility, check if an existing one serves the purpose:
+- `getTokenId` / `getTokenIdForced` instead of `getWalletTokenId`
+- `getExchangeDenom` instead of custom multiplier lookups
+
+---
+
+## Avoid Duplicated Mock Data
+
+Use existing mock data from `src/util/fake/` or consolidate new mocks there:
+
+> "We have been plagued by lots of duplicated, half-baked mock data. This makes it hard to perform core changes without breaking things. Our goal is to reduce the duplication over time, not add to it."
+
+---
+
+## Optimize Search Functions
+
+Move expensive operations outside loops:
+
+```typescript
+// Incorrect - calls normalizeForSearch for each term
+searchTerms.every(term => {
+  const normalCurrencyCode = normalizeForSearch(currencyCode)
+  return normalCurrencyCode.startsWith(term)
+})
+
+// Correct - normalize once outside the loop
+const normalCurrencyCode = normalizeForSearch(currencyCode)
+const normalDisplayName = normalizeForSearch(displayName)
+
+return searchTerms.every(term =>
+  normalCurrencyCode.startsWith(term) ||
+  normalDisplayName.startsWith(term)
+)
+```
+
+Combine conditions into single `||` chains instead of nested `if`/`return` blocks.

.cursor/agents/review-comments.md

@@ -0,0 +1,62 @@
+---
+name: review-comments
+description: Reviews code for comment quality and documentation patterns. Use when reviewing files for documentation accuracy.
+---
+
+Review the branch/pull request in context for comment conventions.
+
+## Context Expected
+
+You will receive:
+- Repository name
+- Branch name
+- List of changed files to review
+
+## How to Review
+
+1. Read the changed files provided in context
+2. Check comments for accuracy and necessity
+3. Look for missing documentation on non-obvious code
+4. Report findings with specific file:line references
+
+---
+
+## Add Non-Obvious Constraints
+
+Document constraints that aren't obvious from the code:
+
+```typescript
+// EVM-only: This conversion assumes EVM contract address format
+const tokenId = contractAddress.toLowerCase()
+```
+
+---
+
+## Remove Stale Comments
+
+Remove comments when the context they describe has changed:
+
+```typescript
+// Incorrect - comment no longer needed after refactor
+// This is a workaround for bug XYZ
+const result = normalFunction()
+
+// Correct - just remove the comment
+const result = normalFunction()
+```
+
+---
+
+## Comments Should Explain Why, Not What
+
+Good comments explain the reasoning, not the mechanics:
+
+```typescript
+// Incorrect - describes what code does (obvious)
+// Loop through items and filter by status
+const filtered = items.filter(item => item.status === 'active')
+
+// Correct - explains why
+// Only active items can be edited; archived items are read-only
+const filtered = items.filter(item => item.status === 'active')
+```

.cursor/agents/review-edge-exchange-plugins.md

@@ -0,0 +1,20 @@
+---
+name: review-edge-exchange-plugins
+description: Reviews edge-exchange-plugins code for compliance with provider API requirements. Use when reviewing exchange plugin implementations.
+---
+
+Review the branch/pull request for compliance with Edge exchange provider API requirements.
+
+## Context Expected
+
+You will receive:
+- Repository name (edge-exchange-plugins)
+- Branch name
+- List of changed files to review
+
+## How to Review
+
+1. Read the API requirements document: `docs/exchange_plugin_api_requirements.md`
+2. Read the changed plugin files provided in context
+3. Verify the plugin implementation meets each applicable requirement
+4. Report findings with specific file:line references