Sync skills and rules from ~/.cursor

Author: j0ntz

.cursor/rules/typescript-standards.mdc

@@ -119,6 +119,17 @@ Exception: Empty handlers are acceptable ONLY when the rejection is an expected
 ✅ `const impact = div(sub(from, to), from, 8)`
 </standard>
 
+<standard id="memoize-derived-collections">When deriving arrays or objects from props/state (e.g. `Object.values()`, `Object.keys()`, `.filter()`, `.map()`), wrap in `React.useMemo` if the result is used in a dependency array or passed as a prop. Bare derivations create new references every render.
+❌ `const wallets = Object.values(currencyWallets)` (used in effect deps)
+✅ `const wallets = React.useMemo(() => Object.values(currencyWallets), [currencyWallets])`
+</standard>
+
+<standard id="guard-on-success-not-existence">When guarding against re-fetching with nullable map lookups, check for the success payload specifically — not just entry existence. Storing error results as non-null entries permanently blocks retry if the guard only checks `== null`.
+❌ `if (resultMap[id] == null) fetchData(id)` (error entries block retry)
+✅ `if (resultMap[id]?.data == null) fetchData(id)` (only skip when data is present)
+Exception: Auto-load effects where infinite retry on persistent failure is undesirable — keep `== null` there and allow retry only via explicit user action.
+</standard>
+
 </standards>
 
 <lint-fix-patterns description="Common ESLint fix recipes for this project's config. Apply directly — do not search node_modules for types. The `rule` attribute maps to ESLint rule IDs for automatic matching by `lint-warnings.sh`.">

.cursor/scripts/pr-watch.sh

@@ -64,7 +64,7 @@ while true; do
   NOW=$(date '+%H:%M:%S')
 
   # Parse recommended interval from script output
-  RECOMMENDED=$(echo "$OUTPUT" | sed -n 's/^# interval:\([0-9][0-9]*\)/\1/p' | head -n 1)
+  RECOMMENDED=$(echo "$OUTPUT" | grep -oP '(?<=^# interval:)\d+' || echo "")
 
   # Determine actual sleep interval
   if [[ -n "$INTERVAL" ]]; then

.cursor/scripts/push-env-key.sh

@@ -0,0 +1,63 @@
+#!/usr/bin/env bash
+# push-env-key.sh — Update a single key in the server's env.json and push
+#
+# Usage: push-env-key.sh <KEY> <VALUE> [-m "commit message"]
+#
+# Examples:
+#   push-env-key.sh EDGE_API_KEY abc123
+#   push-env-key.sh EDGE_API_KEY abc123 -m "Rotate Edge API key"
+
+set -euo pipefail
+
+SERVER="jack"
+REMOTE_REPO="/home/jon/jenkins-files/master"
+
+KEY=""
+VALUE=""
+COMMIT_MSG=""
+
+while [[ $# -gt 0 ]]; do
+  case "$1" in
+    -m) COMMIT_MSG="$2"; shift 2 ;;
+    *)
+      if [[ -z "$KEY" ]]; then KEY="$1"
+      elif [[ -z "$VALUE" ]]; then VALUE="$1"
+      else echo "Unexpected argument: $1" >&2; exit 1
+      fi
+      shift ;;
+  esac
+done
+
+if [[ -z "$KEY" || -z "$VALUE" ]]; then
+  echo "Usage: push-env-key.sh <KEY> <VALUE> [-m \"commit message\"]" >&2
+  exit 1
+fi
+
+if [[ -z "$COMMIT_MSG" ]]; then
+  COMMIT_MSG="Update $KEY in env.json"
+fi
+
+ssh "$SERVER" bash -s -- "$KEY" "$VALUE" "$COMMIT_MSG" "$REMOTE_REPO" <<'REMOTE'
+  set -euo pipefail
+  KEY="$1"
+  VALUE="$2"
+  MSG="$3"
+  REPO="$4"
+
+  cd "$REPO"
+  git pull --ff-only
+
+  CURRENT=$(jq -r --arg k "$KEY" '.[$k] // empty' env.json)
+  if [[ "$CURRENT" == "$VALUE" ]]; then
+    echo "No change: $KEY is already set to that value."
+    exit 0
+  fi
+
+  jq --arg k "$KEY" --arg v "$VALUE" '.[$k] = $v' env.json > env.json.tmp
+  mv env.json.tmp env.json
+
+  git add env.json
+  git commit -m "$MSG"
+  git push
+  echo "Done: $KEY updated and pushed."
+REMOTE

.cursor/skills/asana-task-update/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: asana-task-update
 description: Update Asana tasks via one reusable workflow (attach PRs, assign/unassign, set status, and update task fields). Use when any skill needs to modify Asana task state.
-compatibility: Requires jq. ASANA_TOKEN for Asana API updates. ASANA_GITHUB_SECRET for PR attach operations (obtain via https://github.integrations.asana.plus/auth?domainId=ghactions).
+compatibility: Requires jq. ASANA_TOKEN for Asana API updates. ASANA_GITHUB_SECRET for PR attach operations.
 metadata:
   author: j0ntz
 ---
@@ -11,7 +11,7 @@ metadata:
 <rules description="Non-negotiable constraints.">
 <rule id="use-companion-script">Use `~/.cursor/skills/asana-task-update/scripts/asana-task-update.sh` for all Asana task mutations. Do not call raw Asana APIs directly from skills that can delegate here.</rule>
 <rule id="task-required">Every operation requires `--task <task_gid>`.</rule>
-<rule id="attach-requires-secret">`--attach-pr` requires `ASANA_GITHUB_SECRET` (obtain via OAuth: https://github.integrations.asana.plus/auth?domainId=ghactions). Other operations require `ASANA_TOKEN`.</rule>
+<rule id="attach-requires-secret">`--attach-pr` requires `ASANA_GITHUB_SECRET`. Other operations require `ASANA_TOKEN`.</rule>
 <rule id="prompt-codes">If the script exits code 2 with `PROMPT_REVIEWER` or `PROMPT_IMPLEMENTOR`, ask the user and re-run with explicit `--reviewer` or `--implementor`.</rule>
 <rule id="script-timeouts">Asana updates can take time. Use `block_until_ms: 120000` for script calls.</rule>
 </rules>

.cursor/skills/asana-task-update/scripts/asana-task-update.sh

@@ -69,7 +69,6 @@ fi
 
 if $DO_ATTACH && [[ -z "${ASANA_GITHUB_SECRET:-}" ]]; then
   echo "Error: ASANA_GITHUB_SECRET not set (required for --attach-pr)" >&2
-  echo "Obtain via OAuth: https://github.integrations.asana.plus/auth?domainId=ghactions" >&2
   exit 1
 fi
 
@@ -91,7 +90,6 @@ status_to_gid() {
     "Review Needed") echo "$REVIEW_NEEDED_OPTION" ;;
     "Publish Needed") echo "$PUBLISH_NEEDED_OPTION" ;;
     "Verification Needed") echo "$VERIFICATION_NEEDED_OPTION" ;;
-    # Passthrough: accepts raw GIDs from callers like asana-create-dep-task.sh
     *) echo "$1" ;;
   esac
 }

.cursor/skills/convention-sync/SKILL.md

@@ -10,7 +10,7 @@ metadata:
 
 <rules>
 <rule id="local-is-canonical">`~/.cursor/` is the canonical source. Edits happen locally; the repo is the distribution copy. Default direction is `user-to-repo`. Use `--repo-to-user` only for onboarding or pulling changes authored by others. The script does not detect bidirectional conflicts — whichever direction you run overwrites the other side.</rule>
-<rule id="use-companion-script">Use `scripts/convention-sync.sh` for diffing and syncing. Do NOT manually diff or copy files.</rule>
+<rule id="use-companion-script">Use `~/.cursor/skills/convention-sync/scripts/convention-sync.sh` for diffing and syncing. Do NOT manually diff or copy files.</rule>
 <rule id="dry-run-first">Always run without `--stage` first to show the summary. Only stage/commit after user confirms.</rule>
 <rule id="no-script-bypass">If the script fails, report the error and STOP.</rule>
 <rule id="readme-is-source">`.cursor/README.md` is the source of truth for documentation. The script mirrors it to the PR description automatically.</rule>
@@ -23,7 +23,7 @@ Determine the repo directory — default to the current working directory if it
 Run **in parallel**:
 1. Sync script in dry-run mode:
    ```bash
-   scripts/convention-sync.sh <repo-dir>
+   ~/.cursor/skills/convention-sync/scripts/convention-sync.sh <repo-dir>
    ```
 2. Check for open PR:
    ```bash
@@ -57,7 +57,7 @@ If the user provided a commit message in their prompt, skip the confirmation and
 Run the script with `--commit`:
 
 ```bash
-scripts/convention-sync.sh <repo-dir> --commit -m "<message>"
+~/.cursor/skills/convention-sync/scripts/convention-sync.sh <repo-dir> --commit -m "<message>"
 ```
 
 Then push:

.cursor/skills/one-shot/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: one-shot
 description: End-to-end flow for a task: plan/context, implementation, PR creation, and Asana attach/assign in one command.
-compatibility: Requires git, gh, node, jq. ASANA_TOKEN for Asana integration. ASANA_GITHUB_SECRET for PR attachment (obtain via https://github.integrations.asana.plus/auth?domainId=ghactions).
+compatibility: Requires git, gh, node, jq. ASANA_TOKEN for Asana integration. ASANA_GITHUB_SECRET for PR attachment.
 metadata:
   author: j0ntz
 ---

.cursor/skills/pr-address/SKILL.md

@@ -42,6 +42,14 @@ The `fetch` output contains:
 - **reviewBodies**: Latest review body per non-author reviewer (excludes `prAuthor` and bots)
 - **topLevel**: Top-level comments (excludes `prAuthor` and bots)
 
+To inspect a specific inline thread, including an already-resolved one, use:
+
+```bash
+~/.cursor/skills/pr-address/scripts/pr-address.sh fetch-thread \
+  --owner <OWNER> --repo <REPO> --pr <NUMBER> \
+  --thread-id "<PRRT_threadNodeId>"
+```
+
 The `fetch-pr-body` call writes the current PR body to `/tmp/pr-body.md`. This file is available for editing throughout the session. If you need to update the PR body (e.g. to revise the description after addressing feedback), edit `/tmp/pr-body.md` via the Write tool and push it back:
 
 ```bash
@@ -89,6 +97,16 @@ git push
 After fixing, reply to every processed comment — addressed or rejected — then resolve it.
 
 <sub-step name="Inline threads (reply → resolve)">
+If a later fix may affect an already-addressed inline thread, inspect the thread first:
+
+```bash
+~/.cursor/skills/pr-address/scripts/pr-address.sh fetch-thread \
+  --owner <OWNER> --repo <REPO> --pr <NUMBER> \
+  --thread-id "<PRRT_threadNodeId>"
+```
+
+Use the returned history to decide whether the existing reply still fully reflects the latest fix. If it does not, add one new factual follow-up reply. Multiple replies in the same thread are acceptable when they capture materially new fixes.
+
 1. Reply to the first comment in the thread:
    ```bash
    ~/.cursor/skills/pr-address/scripts/pr-address.sh reply \
@@ -120,6 +138,8 @@ These have no native resolution mechanism. Post a top-level comment with a machi
 ```
 
 The script appends `<!-- addressed:review:ID -->` or `<!-- addressed:comment:ID -->` to the body. Subsequent `fetch` calls detect these markers and exclude already-addressed items.
+
+**Skip bot-only no-op items**: If a review body or top-level comment is from a bot user (e.g., `cursor`, `chatgpt-codex-connector`) AND contains no inline threads with actionable suggestions — only a summary or status message — do NOT post a `mark-addressed` comment. Human reviewer items must always be addressed or rejected, even terse ones like "This needs work".
 </sub-step>
 
 <sub-step name="Reply guidelines">
@@ -175,4 +195,5 @@ Propose modifications to `~/.cursor/rules/typescript-standards.mdc` to prevent s
 <case name="No unresolved feedback">Report "No unresolved comments on this PR" and STOP.</case>
 <case name="External human reviewer comments">Do NOT autosquash when `hasHumanReviewers` is true. Leave fixup commits for the external reviewer to verify, then squash on merge.</case>
 <case name="Comment already addressed in code">If the current code already handles the feedback (e.g., from a previous fixup), still reply explaining this and resolve/mark the comment. Do not leave it unresolved.</case>
+<case name="Already resolved thread needs follow-up">Fetch the thread history first. If the prior reply no longer reflects the latest fix, post one additional factual follow-up reply. Do not edit or delete prior replies in this workflow.</case>
 </edge-cases>

.cursor/skills/pr-address/scripts/pr-address.sh

@@ -5,6 +5,7 @@
 #
 # Subcommands:
 #   fetch          --owner <o> --repo <r> --pr <n>         Fetch all unresolved feedback via GraphQL
+#   fetch-thread   --owner <o> --repo <r> --pr <n> --thread-id <id>
 #   reply          --owner <o> --repo <r> --pr <n> --comment-id <id> --body <text>
 #   resolve-thread --thread-id <node_id>                   Mark inline thread as resolved (GraphQL)
 #   mark-addressed --owner <o> --repo <r> --pr <n> --type <review|comment> --target-id <id> --body <text>
@@ -179,6 +180,61 @@ case "$CMD" in
     "
     ;;
 
+  fetch-thread)
+    require_gh
+    if [[ -z "$OWNER" || -z "$REPO" || -z "$PR" || -z "$THREAD_ID" ]]; then
+      echo "Error: --owner, --repo, --pr, --thread-id required" >&2; exit 1
+    fi
+
+    gh api graphql \
+      -f query='query($owner: String!, $repo: String!, $number: Int!) {
+        repository(owner: $owner, name: $repo) {
+          pullRequest(number: $number) {
+            reviewThreads(first: 100) {
+              nodes {
+                id
+                isResolved
+                comments(first: 50) {
+                  nodes {
+                    databaseId
+                    createdAt
+                    author { login }
+                    path
+                    line
+                    body
+                  }
+                }
+              }
+            }
+          }
+        }
+      }' \
+      -f owner="$OWNER" -f repo="$REPO" -F number="$PR" \
+    | GH_THREAD_ID="$THREAD_ID" node -e "
+      const fs = require('fs')
+      const data = JSON.parse(fs.readFileSync('/dev/stdin', 'utf8'))
+      const threads = data.data.repository.pullRequest.reviewThreads.nodes
+      const thread = threads.find(item => item.id === process.env.GH_THREAD_ID)
+      if (thread == null) {
+        console.error('Thread not found: ' + process.env.GH_THREAD_ID)
+        process.exit(1)
+      }
+
+      console.log(JSON.stringify({
+        threadId: thread.id,
+        isResolved: thread.isResolved,
+        path: thread.comments.nodes[0]?.path ?? null,
+        line: thread.comments.nodes[0]?.line ?? null,
+        comments: thread.comments.nodes.map(comment => ({
+          id: comment.databaseId,
+          user: comment.author?.login ?? null,
+          body: comment.body,
+          createdAt: comment.createdAt
+        }))
+      }, null, 2))
+    "
+    ;;
+
   reply)
     require_gh
     if [[ -z "$OWNER" || -z "$REPO" || -z "$PR" || -z "$COMMENT_ID" || -z "$BODY" ]]; then
@@ -269,7 +325,7 @@ case "$CMD" in
     ;;
 
   *)
-    echo "Usage: pr-address.sh {fetch|reply|resolve-thread|mark-addressed|resolve-id|headline|fetch-pr-body|autosquash} [args]" >&2
+    echo "Usage: pr-address.sh {fetch|fetch-thread|reply|resolve-thread|mark-addressed|resolve-id|headline|fetch-pr-body|autosquash} [args]" >&2
     exit 1
     ;;
 esac

.cursor/skills/pr-create/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: pr-create
 description: Create a pull request from the current branch, with optional Asana attach/assign updates.
-compatibility: Requires git, gh, node, jq. ASANA_TOKEN for Asana updates. ASANA_GITHUB_SECRET for Asana PR attachment (obtain via https://github.integrations.asana.plus/auth?domainId=ghactions).
+compatibility: Requires git, gh, node, jq. ASANA_TOKEN for Asana updates. ASANA_GITHUB_SECRET for Asana PR attachment.
 metadata:
   author: j0ntz
 ---