Update asana scripts, pr-review, fix-workflow-first

Jon-edge · Jon-edge · commit f7946c610b90 · 2026-02-20T17:44:44.000-08:00
diff --git a/.cursor/commands/asana-attach-pr.sh b/.cursor/commands/asana-attach-pr.sh
@@ -124,11 +124,12 @@ if [[ -z "$IMPLEMENTOR_GID" ]]; then
 fi
 
 # --- Step 3: Set Implementor if override was provided ---
+# People fields use array format: {"field_gid": ["user_gid"]}
 if [[ -n "$IMPLEMENTOR_OVERRIDE" ]]; then
   curl -s -X PUT "https://app.asana.com/api/1.0/tasks/$TASK_GID" \
     -H "Authorization: Bearer $ASANA_TOKEN" \
     -H "Content-Type: application/json" \
-    -d "{\"data\":{\"custom_fields\":{\"$IMPLEMENTOR_FIELD\":{\"people_value\":[\"$IMPLEMENTOR_OVERRIDE\"]}}}}" > /dev/null 2>&1 || true
+    -d "{\"data\":{\"custom_fields\":{\"$IMPLEMENTOR_FIELD\":[\"$IMPLEMENTOR_OVERRIDE\"]}}}" > /dev/null 2>&1 || true
   echo ">> Implementor: set"
 fi
 
diff --git a/.cursor/commands/asana-create-dep-task.sh b/.cursor/commands/asana-create-dep-task.sh
@@ -16,7 +16,7 @@
 #   TASK_URL: <url>
 #   CREATED: true|false (false if task already existed)
 #   ASSIGNED_TO: <user_gid>
-#   FIELDS_SET: priority=<val>, status=<val>
+#   FIELDS_SET: priority=<val>, status=<val>, reviewer=<name>, implementor=<name>
 #   DEPENDENCY_SET: <new_gid> blocks <parent_gid>
 #
 # Exit codes: 0 = success, 1 = error
@@ -52,9 +52,12 @@ AUTH="Authorization: Bearer $ASANA_TOKEN"
 
 SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
 
+# Auto-resolve current user GID (used for assignee and implementor)
+CURRENT_USER_GID=$("$SCRIPT_DIR/asana-whoami.sh" 2>/dev/null || true)
+
 # Auto-resolve assignee to current user if not provided
 if [[ -z "$ASSIGNEE_GID" ]]; then
-  ASSIGNEE_GID=$("$SCRIPT_DIR/asana-whoami.sh" 2>/dev/null || true)
+  ASSIGNEE_GID="$CURRENT_USER_GID"
 fi
 
 # Phase 1: Check if a dependency with a matching name already exists
@@ -78,10 +81,10 @@ if [[ -n "$existing" ]]; then
 fi
 
 # Phase 2: Get parent task's project and custom fields to copy
-parent_info=$(curl -s "$API/tasks/$PARENT_GID?opt_fields=workspace.gid,memberships.project.gid,memberships.project.name,custom_fields.gid,custom_fields.enum_value.gid,custom_fields.enum_value.name" \
+parent_info=$(curl -s "$API/tasks/$PARENT_GID?opt_fields=workspace.gid,memberships.project.gid,memberships.project.name,custom_fields.gid,custom_fields.enum_value.gid,custom_fields.enum_value.name,custom_fields.people_value.gid,custom_fields.people_value.name" \
   -H "$AUTH")
 
-read -r WORKSPACE_GID PROJECT_GIDS PRIORITY_GID PRIORITY_VAL STATUS_GID STATUS_VAL < <(echo "$parent_info" | python3 -c "
+read -r WORKSPACE_GID PROJECT_GIDS PRIORITY_INFO STATUS_INFO REVIEWER_INFO < <(echo "$parent_info" | python3 -c "
 import sys, json, re
 data = json.load(sys.stdin)['data']
 ws = data.get('workspace', {}).get('gid', '')
@@ -96,51 +99,70 @@ if not projects and data.get('memberships'):
     projects.append(data['memberships'][0]['project']['gid'])
 proj_str = ','.join(projects)
 
-# Custom fields to copy
-FIELD_MAP = {
+# Field GIDs
+ENUM_FIELDS = {
     '795866930204488': 'priority',
     '1190660107346181': 'status',
 }
-fields = {}
+PEOPLE_FIELDS = {
+    '1203334388004673': 'reviewer',
+}
+
+enum_results = {}
+people_results = {}
+
 for f in data.get('custom_fields', []):
-    label = FIELD_MAP.get(f['gid'])
-    if label and f.get('enum_value'):
-        fields[label + '_gid'] = f['gid']
-        fields[label + '_val'] = f['enum_value']['gid']
-        fields[label + '_name'] = f['enum_value']['name']
-
-pri_gid = fields.get('priority_gid', '')
-pri_val = fields.get('priority_val', '')
-sta_gid = fields.get('status_gid', '')
-sta_val = fields.get('status_val', '')
-
-print(f'{ws} {proj_str} {pri_gid}:{pri_val}:{fields.get(\"priority_name\",\"\")} {sta_gid}:{sta_val}:{fields.get(\"status_name\",\"\")}')
+    fgid = f['gid']
+    if fgid in ENUM_FIELDS and f.get('enum_value'):
+        label = ENUM_FIELDS[fgid]
+        enum_results[label] = (fgid, f['enum_value']['gid'], f['enum_value'].get('name', ''))
+    if fgid in PEOPLE_FIELDS:
+        label = PEOPLE_FIELDS[fgid]
+        pv = f.get('people_value', [])
+        if pv:
+            people_results[label] = (fgid, pv[0]['gid'], pv[0].get('name', ''))
+
+def fmt_enum(key):
+    if key in enum_results:
+        return ':'.join(enum_results[key])
+    return '::'
+
+def fmt_people(key):
+    if key in people_results:
+        return ':'.join(people_results[key])
+    return '::'
+
+print(f\"{ws} {proj_str} {fmt_enum('priority')} {fmt_enum('status')} {fmt_people('reviewer')}\")
 ")
 
-PRIORITY_FIELD=$(echo "$PRIORITY_VAL" | cut -d: -f1)
-PRIORITY_ENUM=$(echo "$PRIORITY_VAL" | cut -d: -f2)
-PRIORITY_NAME=$(echo "$PRIORITY_VAL" | cut -d: -f3)
-STATUS_FIELD=$(echo "$STATUS_VAL" | cut -d: -f1)
-STATUS_ENUM=$(echo "$STATUS_VAL" | cut -d: -f2)
-STATUS_NAME=$(echo "$STATUS_VAL" | cut -d: -f3)
+PRIORITY_FIELD=$(echo "$PRIORITY_INFO" | cut -d: -f1)
+PRIORITY_ENUM=$(echo "$PRIORITY_INFO" | cut -d: -f2)
+PRIORITY_NAME=$(echo "$PRIORITY_INFO" | cut -d: -f3)
+STATUS_FIELD=$(echo "$STATUS_INFO" | cut -d: -f1)
+STATUS_ENUM=$(echo "$STATUS_INFO" | cut -d: -f2)
+STATUS_NAME=$(echo "$STATUS_INFO" | cut -d: -f3)
+REVIEWER_FIELD=$(echo "$REVIEWER_INFO" | cut -d: -f1)
+REVIEWER_GID=$(echo "$REVIEWER_INFO" | cut -d: -f2)
+REVIEWER_NAME=$(echo "$REVIEWER_INFO" | cut -d: -f3)
+
+# Auto-resolve implementor to current user
+IMPLEMENTOR_FIELD="1203334386796983"
+IMPLEMENTOR_GID="$CURRENT_USER_GID"
+IMPLEMENTOR_NAME="current user"
 
 # Phase 3: Create the task
 NOTES_JSON=$(python3 -c "import json; print(json.dumps('''$TASK_NOTES'''))")
 
-custom_fields_json="{}"
-if [[ -n "$PRIORITY_FIELD" && -n "$PRIORITY_ENUM" ]]; then
-  custom_fields_json=$(python3 -c "
+# Build enum custom fields for task creation (people fields set separately after)
+custom_fields_json=$(python3 -c "
 import json
 cf = {}
-pf = '$PRIORITY_FIELD'
-pe = '$PRIORITY_ENUM'
-sf = '$STATUS_FIELD'
-se = '$STATUS_ENUM'
+pf, pe = '$PRIORITY_FIELD', '$PRIORITY_ENUM'
+sf, se = '$STATUS_FIELD', '$STATUS_ENUM'
 if pf and pe: cf[pf] = pe
 if sf and se: cf[sf] = se
 print(json.dumps(cf))
 ")
-fi
 
 # Build projects list from comma-separated GIDs
 IFS=',' read -ra PROJECT_ARR <<< "$PROJECT_GIDS"
@@ -180,6 +202,28 @@ if [[ -z "$NEW_GID" || "$NEW_GID" == "ERROR"* ]]; then
   exit 1
 fi
 
+# Phase 3b: Set people fields (reviewer, implementor) via separate PUT
+# People fields use array format: {"field_gid": ["user_gid"]}
+people_fields_json=$(python3 -c "
+import json
+cf = {}
+rf, rg = '$REVIEWER_FIELD', '$REVIEWER_GID'
+imf, img = '$IMPLEMENTOR_FIELD', '$IMPLEMENTOR_GID'
+if rf and rg: cf[rf] = [rg]
+if imf and img: cf[imf] = [img]
+if cf:
+    print(json.dumps({'data': {'custom_fields': cf}}))
+else:
+    print('')
+")
+
+if [[ -n "$people_fields_json" ]]; then
+  curl -s -X PUT "$API/tasks/$NEW_GID" \
+    -H "$AUTH" \
+    -H "Content-Type: application/json" \
+    -d "$people_fields_json" > /dev/null 2>&1 || true
+fi
+
 FIRST_PROJECT=$(echo "$PROJECT_GIDS" | cut -d, -f1)
 echo "TASK_GID: $NEW_GID"
 echo "TASK_URL: https://app.asana.com/0/$FIRST_PROJECT/$NEW_GID"
@@ -194,9 +238,9 @@ curl -s -X POST "$API/tasks/$PARENT_GID/addDependencies" \
 
 echo "DEPENDENCY_SET: $NEW_GID blocks $PARENT_GID"
 
-if [[ -n "$PRIORITY_NAME" || -n "$STATUS_NAME" ]]; then
-  fields_msg=""
-  [[ -n "$PRIORITY_NAME" ]] && fields_msg="priority=$PRIORITY_NAME"
-  [[ -n "$STATUS_NAME" ]] && fields_msg="${fields_msg:+$fields_msg, }status=$STATUS_NAME"
-  echo "FIELDS_SET: $fields_msg"
-fi
+fields_msg=""
+[[ -n "$PRIORITY_NAME" ]] && fields_msg="priority=$PRIORITY_NAME"
+[[ -n "$STATUS_NAME" ]] && fields_msg="${fields_msg:+$fields_msg, }status=$STATUS_NAME"
+[[ -n "$REVIEWER_NAME" ]] && fields_msg="${fields_msg:+$fields_msg, }reviewer=$REVIEWER_NAME"
+[[ -n "$IMPLEMENTOR_GID" ]] && fields_msg="${fields_msg:+$fields_msg, }implementor=$IMPLEMENTOR_NAME"
+[[ -n "$fields_msg" ]] && echo "FIELDS_SET: $fields_msg"
diff --git a/.cursor/commands/pr-review.md b/.cursor/commands/pr-review.md
@@ -23,14 +23,26 @@ If the script exits code 2 with `PROMPT_GH_AUTH`, prompt: "`gh` CLI is not authe
 Save the output JSON — it contains `number`, `title`, `url`, `headRef`, `baseRef`, `headSha`, `reviews[]`, and `files[]` (with patches).
 </step>
 
-<step id="2" name="Load review standards">
+<step id="2" name="Checkout PR branch">
+Checkout the PR branch to ensure file reads reflect the PR's code, not the current local branch:
+
+```bash
+git fetch origin <headRef> && git checkout <headRef>
+```
+
+Replace `<headRef>` with the branch name from the context output (e.g., `william/fix-eth-sync`).
+
+If checkout fails due to uncommitted changes, prompt the user to stash or commit before proceeding.
+</step>
+
+<step id="3" name="Load review standards">
 Read these files in parallel (skip any already present in `cursor_rules_context`):
 
 - `~/.cursor/rules/review-standards.mdc`
 - `~/.cursor/rules/typescript-standards.mdc`
 </step>
 
-<step id="3" name="Review changed files">
+<step id="4" name="Review changed files">
 For each changed file in the context output:
 
 1. Read the full file to understand surrounding context (batch reads in parallel)
@@ -50,7 +62,7 @@ Categorize findings as:
 Cross-reference findings against `reviews[]` from the context output. Omit any findings already raised by another reviewer.
 </step>
 
-<step id="4" name="Submit review">
+<step id="5" name="Submit review">
 If there are findings to report, prepare a review JSON and submit via the companion script:
 
 ```bash
@@ -87,7 +99,7 @@ Use `"REQUEST_CHANGES"` for critical issues, `"COMMENT"` for suggestions only, `
 </sub-step>
 </step>
 
-<step id="5" name="Summarize">
+<step id="6" name="Summarize">
 After submitting (or if no findings), provide a summary in the chat response:
 - Number of files reviewed
 - Findings by category (critical, warning, suggestion)
diff --git a/.cursor/rules/fix-workflow-first.mdc b/.cursor/rules/fix-workflow-first.mdc
@@ -3,13 +3,20 @@ description: When a workflow issue is identified in a command or skill, fix the
 alwaysApply: true
 ---
 
-# Fix Workflow Definitions First
+<goal>Ensure workflow definitions are fixed at the source before any workarounds are applied.</goal>
 
-When a misbehavior is traced to a command (`.cursor/commands/*.md`) or skill (`.cursor/skills/*/SKILL.md`):
+<rules description="Non-negotiable constraints.">
+<rule id="absolute-priority">Fixing the command/skill takes **absolute priority** over all other actions — including workarounds, continuing the original task, or applying temporary fixes.</rule>
+<rule id="no-workarounds-first">Do NOT apply workarounds or manual fixes before proposing the command/skill update. The correct sequence is: identify gap → propose fix → get approval → apply fix → then resume original task.</rule>
+<rule id="use-author">Always use `/author` to fix commands and skills. It contains current best practices and the mandatory revision checklist.</rule>
+</rules>
 
-1. **Stop** fixing the downstream symptom.
-2. **Identify the root cause** in the command/skill definition.
-3. **Fix the command/skill first** using `/author` (`~/.cursor/skills/author/SKILL.md`), which contains the current best practices and mandatory revision checklist for command/skill authoring.
-4. **Then** fix the immediate misbehavior if still needed.
+<sequence name="When a workflow gap is discovered">
+1. **Stop immediately** — do not continue the current task or apply any workaround.
+2. **Identify the root cause** in the command (`.cursor/commands/*.md`) or skill (`.cursor/skills/*/SKILL.md`) definition.
+3. **Propose the fix** to the user and wait for approval before proceeding.
+4. **Fix the command/skill** using `/author` after approval.
+5. **Resume the original task** only after the command/skill is updated.
+</sequence>
 
-This applies to all workflow issues — missed steps, incorrect output, wrong tool usage, formatting problems, etc. The command/skill is the source of truth; patching around it creates drift.
+<scope>This applies to all workflow issues — missed steps, incorrect output, wrong tool usage, formatting problems, etc. The command/skill is the source of truth; patching around it creates drift.</scope>
