Fix getFreshAddress after creating a wallet

Fix `getFreshAddress` to return a non-empty `publicAddress` when calling
immediately after creating a wallet

Author: Jon-edge

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 # Unreleased
 
+- fixed: Fix `getFreshAddress` to return a non-empty `publicAddress` when calling immediately after creating a wallet.
 - fixed: Handle insufficient funds errors from native library into `InsufficientFundsError`.
 
 ## 1.5.0 (2025-04-21)

src/MoneroEngine.ts

@@ -85,6 +85,7 @@ export class MoneroEngine implements EdgeCurrencyEngine {
   log: EdgeLog
   currencyTools: MoneroTools
   seenTxCheckpoint: number | undefined
+  loginPromise: Promise<void> | null = null
 
   constructor(
     env: EdgeCorePluginOptions,
@@ -174,6 +175,20 @@ export class MoneroEngine implements EdgeCurrencyEngine {
   // Login to mymonero.com server
   // **********************************************
   async loginIfNewAddress(privateKeys: PrivateKeys): Promise<void> {
+    if (this.loginPromise != null) {
+      return await this.loginPromise
+    }
+    this.loginPromise = this.performLogin(privateKeys)
+
+    try {
+      await this.loginPromise
+    } finally {
+      // Clear the promise once completed (success OR failure)
+      this.loginPromise = null
+    }
+  }
+
+  private async performLogin(privateKeys: PrivateKeys): Promise<void> {
     try {
       const result = await this.myMoneroApi.login({
         address: this.walletInfo.keys.moneroAddress,
@@ -578,8 +593,18 @@ export class MoneroEngine implements EdgeCurrencyEngine {
   async getFreshAddress(
     options: EdgeGetReceiveAddressOptions
   ): Promise<EdgeFreshAddress> {
+    // Wait for login to complete if it's in progress
+    if (this.loginPromise != null) {
+      await this.loginPromise
+    }
+
     // Do not show the address before logging into my monero...
-    if (!this.walletLocalData.hasLoggedIn) return { publicAddress: '' }
+    if (!this.walletLocalData.hasLoggedIn) {
+      this.log.warn(
+        'Attempted to retrieve `publicAddress` before successfully logging in'
+      )
+      return { publicAddress: '' }
+    }
     return { publicAddress: this.walletInfo.keys.moneroAddress }
   }