Update eslint-config-standard-kit

Author: peachbits

.eslintignore

@@ -454,7 +454,7 @@ const test4 = {
   ]
 }
 
-const fetchem = async (test: object): Promise<void> => {
+const fetchem = async (test: object): Promise<any> => {
   const response = await fetch('http://127.0.0.1:8087/v3/rates', {
     method: 'POST',
     headers: {
@@ -463,18 +463,18 @@ const fetchem = async (test: object): Promise<void> => {
     body: JSON.stringify(test)
   })
   const json = await response.json()
-  console.log(JSON.stringify(json, null, 2))
+  return json
 }
 
 const main = async (): Promise<void> => {
-  console.log('test1')
-  console.log(JSON.stringify(await fetchem(test1), null, 2))
-  console.log('test2')
-  console.log(JSON.stringify(await fetchem(test2), null, 2))
-  console.log('test3')
-  console.log(JSON.stringify(await fetchem(test3), null, 2))
-  console.log('test4')
-  console.log(JSON.stringify(await fetchem(test4), null, 2))
+  const test1Result = await fetchem(test1)
+  console.log('test1', JSON.stringify(test1Result, null, 2))
+  const test2Result = await fetchem(test2)
+  console.log('test2', JSON.stringify(test2Result, null, 2))
+  const test3Result = await fetchem(test3)
+  console.log('test3', JSON.stringify(test3Result, null, 2))
+  const test4Result = await fetchem(test4)
+  console.log('test4', JSON.stringify(test4Result, null, 2))
 }
 
 main().catch(e => {

.eslintrc.json

@@ -0,0 +1,55 @@
+import standardConfig from 'eslint-config-standard-kit'
+
+export default [
+  ...standardConfig({
+    prettier: true,
+    sortImports: true,
+    node: true,
+    typescript: true
+  }),
+
+  // Turn several TypeScript lint errors into warnings:
+  {
+    files: ['**/*.ts', '**/*.tsx'],
+    languageOptions: {
+      parserOptions: {
+        projectService: true,
+        tsconfigRootDir: import.meta.dirname
+      }
+    },
+    rules: {
+      '@typescript-eslint/ban-ts-comment': 'warn',
+      '@typescript-eslint/default-param-last': 'warn',
+      '@typescript-eslint/explicit-function-return-type': 'warn',
+      '@typescript-eslint/no-dynamic-delete': 'warn',
+      '@typescript-eslint/no-misused-promises': 'warn',
+      '@typescript-eslint/prefer-nullish-coalescing': 'warn',
+      '@typescript-eslint/prefer-optional-chain': 'warn',
+      '@typescript-eslint/require-array-sort-compare': 'warn',
+      '@typescript-eslint/restrict-plus-operands': 'warn',
+      '@typescript-eslint/restrict-template-expressions': 'warn',
+      '@typescript-eslint/strict-boolean-expressions': 'warn',
+      '@typescript-eslint/use-unknown-in-catch-callback-variable': 'warn',
+
+      // Allow snake_case until we remove the legacy code
+      camelcase: 'off',
+      '@typescript-eslint/naming-convention': [
+        'warn',
+        {
+          selector: 'variableLike',
+          format: ['camelCase', 'PascalCase', 'snake_case'], // allow all three
+          leadingUnderscore: 'allow'
+        },
+        {
+          selector: 'typeLike',
+          format: ['PascalCase']
+        }
+      ]
+    }
+  },
+
+  // Global ignores need to be in their own block:
+  {
+    ignores: ['lib/*', 'node_modules/*', '.vscode/*']
+  }
+]

bin/testRates.ts

@@ -44,13 +44,8 @@
     "compression": "^1.7.4",
     "cors": "^2.8.5",
     "edge-server-tools": "^0.2.22",
-    "eslint-config-standard-kit": "0.15.1",
-    "eslint-plugin-import": "^2.22.1",
-    "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-prettier": "^3.1.4",
-    "eslint-plugin-promise": "^4.2.1",
-    "eslint-plugin-simple-import-sort": "^6.0.1",
-    "eslint": "^8.57.0",
+    "eslint": "^9.31.0",
+    "eslint-config-standard-kit": "1.0.0",
     "express": "^4.21.2",
     "husky": "^5.2.0",
     "lint-staged": ">=9.0.0",
@@ -64,7 +59,7 @@
     "redis": "^4.0.4",
     "rimraf": "^6.0.1",
     "serverlet": "^0.1.3",
-    "sucrase": "^3.12.1",
+    "sucrase": "^3.35.0",
     "typescript": "5.0.4"
   },
   "dependencies": {

eslint.config.mjs

@@ -2,7 +2,11 @@ import fetch from 'node-fetch'
 
 import { config } from './config'
 import { REDIS_COINRANK_KEY_PREFIX } from './constants'
-import { asCoingeckoMarkets, CoinrankMarkets, CoinrankRedis } from './types'
+import {
+  asCoingeckoMarkets,
+  type CoinrankMarkets,
+  type CoinrankRedis
+} from './types'
 import { setAsync, slackMessage } from './utils/dbUtils'
 import { getDelay, logger, snooze } from './utils/utils'
 
@@ -65,9 +69,11 @@ export const coinrankEngine = async (): Promise<void> => {
       )
     } catch (e) {
       const err: any = e // Weird TS issue causing :any to get removed from above line
-      // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
+
       const message = `coinrankEngine failure: ${err.message}`
-      slackMessage(message).catch(e => logger(e))
+      slackMessage(message).catch(e => {
+        logger(e)
+      })
       logger(message)
     }
   }

package.json

@@ -1,24 +1,23 @@
 import { mul } from 'biggystring'
-import { asArray, asMaybe, asObject, asOptional, asString } from 'cleaners'
+import { asArray, asMaybe, asObject, asString } from 'cleaners'
 import express from 'express'
 import nano from 'nano'
 import fetch from 'node-fetch'
 import promisify from 'promisify-node'
 
 import { config } from './config'
 import { REDIS_COINRANK_KEY_PREFIX } from './constants'
-import { asReturnGetRate, getExchangeRates } from './rates'
+import { getExchangeRates, type ReturnGetRate } from './rates'
 import {
   asCoinrankAssetReq,
   asCoinrankReq,
   asExchangeRateResponse,
-  CoinrankAssetReq,
-  CoinrankRedis,
-  CoinrankReq
+  type CoinrankAssetReq,
+  type CoinrankRedis,
+  type CoinrankReq
 } from './types'
-import { asExtendedReq } from './utils/asExtendedReq'
 import {
-  DbDoc,
+  type DbDoc,
   getAsync,
   hgetallAsync,
   hmgetAsync,
@@ -87,14 +86,16 @@ const asExchangeRatesReq = asObject({
   data: asArray(asExchangeRateReq)
 })
 
-const asRatesRequest = asExtendedReq({
-  requestedRates: asOptional(asExchangeRatesReq),
-  requestedRatesResult: asOptional(asReturnGetRate)
-})
+interface RatesRequest {
+  requestedRates?: {
+    data: ExchangeRateReq[]
+  }
+  requestedRatesResult?: ReturnGetRate
+}
 
 // Hack to add type definitions for middleware
 // eslint-disable-next-line @typescript-eslint/no-invalid-void-type
-type ExpressRequest = ReturnType<typeof asRatesRequest> | void
+type ExpressRequest = RatesRequest | void
 
 const { couchUri, fiatCurrencyCodes: FIAT_CODES } = config
 const EXCHANGE_RATES_BATCH_LIMIT = 100
@@ -128,7 +129,10 @@ const v1ExchangeRateIsoAdder: express.RequestHandler = (
   next
 ): void => {
   const exReq = req as ExpressRequest
-  if (exReq?.requestedRates == null) return next(500)
+  if (exReq?.requestedRates == null) {
+    next(500)
+    return
+  }
 
   exReq.requestedRates.data = exReq.requestedRates.data.map(req => ({
     currency_pair: maybeAddIsoToPair(req.currency_pair),
@@ -144,7 +148,10 @@ const v1ExchangeRateIsoSubtractor: express.RequestHandler = (
   next
 ): void => {
   const exReq = req as ExpressRequest
-  if (exReq?.requestedRatesResult == null) return next(500)
+  if (exReq?.requestedRatesResult == null) {
+    next(500)
+    return
+  }
 
   exReq.requestedRatesResult.data = exReq.requestedRatesResult.data.map(
     rate => ({
@@ -158,7 +165,10 @@ const v1ExchangeRateIsoSubtractor: express.RequestHandler = (
 
 const v1IsoChecker: express.RequestHandler = (req, res, next): void => {
   const exReq = req as ExpressRequest
-  if (exReq?.requestedRates == null) return next(500)
+  if (exReq?.requestedRates == null) {
+    next(500)
+    return
+  }
 
   if (exReq.requestedRates.data.every(pair => isIsoPair(pair.currency_pair))) {
     res.status(400).send(`Please use v2 of this API to query with ISO codes`)
@@ -174,7 +184,10 @@ const v1IsoChecker: express.RequestHandler = (req, res, next): void => {
 
 const exchangeRateCleaner: express.RequestHandler = (req, res, next): void => {
   const exReq = req as ExpressRequest
-  if (exReq == null) return next(500)
+  if (exReq == null) {
+    next(500)
+    return
+  }
 
   const { currency_pair, date } = req.query
   try {
@@ -196,10 +209,12 @@ const exchangeRateCleaner: express.RequestHandler = (req, res, next): void => {
 
 const exchangeRatesCleaner: express.RequestHandler = (req, res, next): void => {
   const exReq = req as ExpressRequest
-  if (exReq == null) return next(500)
-
+  if (exReq == null) {
+    next(500)
+    return
+  }
   try {
-    exReq.requestedRates = asExchangeRatesReq(exReq.body)
+    exReq.requestedRates = asExchangeRatesReq(req.body)
   } catch (e) {
     res
       .status(400)
@@ -221,13 +236,16 @@ const queryRedis: express.RequestHandler = async (
   next
 ): Promise<void> => {
   const exReq = req as ExpressRequest
-  if (exReq?.requestedRates == null) return next(500)
+  if (exReq?.requestedRates == null) {
+    next(500)
+    return
+  }
 
   // Redis will store all crypto code rates in USD and USD to all fiat codes
   // This middleware splits up incoming pairs into two rates, crypto_USD and USD_fiat,
   // so each unique timestamp only requires a single query to redis to get all applicable rates.
 
-  const reqMap: { [date: string]: string[] } = {}
+  const reqMap: Record<string, string[]> = {}
   for (const req of exReq.requestedRates.data) {
     const [cryptoCode, fiatCode] = req.currency_pair.split('_')
     if (reqMap[req.date] == null) reqMap[req.date] = []
@@ -287,10 +305,14 @@ const queryExchangeRates: express.RequestHandler = async (
   next
 ): Promise<void> => {
   const exReq = req as ExpressRequest
-  if (exReq?.requestedRates == null) return next(500)
+  if (exReq?.requestedRates == null) {
+    next(500)
+    return
+  }
 
   if (exReq.requestedRates.data.length === 0) {
-    return next()
+    next()
+    return
   }
 
   try {
@@ -311,14 +333,20 @@ const queryExchangeRates: express.RequestHandler = async (
 
 const sendExchangeRate: express.RequestHandler = (req, res, next): void => {
   const exReq = req as ExpressRequest
-  if (exReq?.requestedRatesResult == null) return next(500)
+  if (exReq?.requestedRatesResult == null) {
+    next(500)
+    return
+  }
 
   res.json(exReq.requestedRatesResult.data[0])
 }
 
 const sendExchangeRates: express.RequestHandler = (req, res, next): void => {
   const exReq = req as ExpressRequest
-  if (exReq?.requestedRatesResult == null) return next(500)
+  if (exReq?.requestedRatesResult == null) {
+    next(500)
+    return
+  }
 
   res.json({ data: exReq.requestedRatesResult.data })
 }
@@ -456,7 +484,10 @@ const sendCoinrankAsset: express.RequestHandler = async (
   next
 ): Promise<void> => {
   const exReq = req as ExpressRequest
-  if (exReq == null) return next(500)
+  if (exReq == null) {
+    next(500)
+    return
+  }
 
   let query: CoinrankAssetReq
   try {
@@ -499,7 +530,10 @@ const sendCoinranks: express.RequestHandler = async (
   next
 ): Promise<void> => {
   const exReq = req as ExpressRequest
-  if (exReq == null) return next(500)
+  if (exReq == null) {
+    next(500)
+    return
+  }
 
   let query: CoinrankReq
   try {