Change title for WalletDetailsScene

For the TransactionList, keep the same title so the user knows which wallet the transactions are for.

Author: Jon-edge

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased (develop)
 
+- changed: `WalletDetailsScene` title shows the name of the network for most use cases
+
 ## 4.22.0 (staging)
 
 - added: `NotificationCenterScene`

src/actions/WalletListMenuActions.tsx

@@ -295,7 +295,7 @@ export function walletListMenuAction(
         navigation.navigate('walletDetails', {
           walletId,
           tokenId: null,
-          walletName: getWalletName(wallet)
+          sceneTitle: sprintf(lstrings.create_wallet_account_metadata_name, wallet.currencyInfo.displayName)
         })
       }
     }

src/components/Main.tsx

@@ -284,7 +284,7 @@ const EdgeWalletsTabScreen = () => {
         name="walletDetails"
         component={WalletDetails}
         options={{
-          headerTitle: () => <ParamHeaderTitle<'walletDetails'> fromParams={params => params.walletName} />
+          headerTitle: () => <ParamHeaderTitle<'walletDetails'> fromParams={params => params.sceneTitle} />
         }}
       />
     </WalletsStack.Navigator>

src/components/scenes/WalletDetailsScene.tsx

@@ -21,6 +21,7 @@ import { FooterRender } from '../../state/SceneFooterState'
 import { useSceneScrollHandler } from '../../state/SceneScrollState'
 import { useDispatch, useSelector } from '../../types/reactRedux'
 import { NavigationBase, WalletsTabSceneProps } from '../../types/routerTypes'
+import { getWalletName } from '../../util/CurrencyWalletHelpers'
 import { coinrankListData, infoServerData } from '../../util/network'
 import { calculateSpamThreshold, convertNativeToDenomination, darkenHexColor, zeroString } from '../../util/utils'
 import { EdgeCard } from '../cards/EdgeCard'
@@ -42,7 +43,7 @@ import { TransactionListTop } from '../themed/TransactionListTop'
 
 export interface WalletDetailsParams {
   walletId: string
-  walletName: string
+  sceneTitle: string
   tokenId: EdgeTokenId
   countryCode?: string
 }
@@ -174,7 +175,12 @@ function WalletDetailsComponent(props: Props) {
   })
 
   const handlePressSeeAll = useHandler(() => {
-    navigation.navigate('transactionList', route.params)
+    navigation.navigate('transactionList', {
+      walletId: wallet.id,
+      tokenId,
+      walletName: getWalletName(wallet),
+      countryCode: route.params.countryCode
+    })
   })
 
   //

src/components/themed/WalletListSwipeable.tsx

@@ -3,11 +3,13 @@ import * as React from 'react'
 import { useMemo } from 'react'
 import { FlatList, RefreshControl } from 'react-native'
 import Animated from 'react-native-reanimated'
+import { sprintf } from 'sprintf-js'
 
 import { getFirstOpenInfo } from '../../actions/FirstOpenActions'
 import { selectWalletToken } from '../../actions/WalletActions'
 import { SCROLL_INDICATOR_INSET_FIX } from '../../constants/constantSettings'
 import { useHandler } from '../../hooks/useHandler'
+import { lstrings } from '../../locales/strings'
 import { filterWalletCreateItemListBySearchText, getCreateWalletList, WalletCreateItem } from '../../selectors/getCreateWalletList'
 import { useSceneScrollHandler } from '../../state/SceneScrollState'
 import { useDispatch, useSelector } from '../../types/reactRedux'
@@ -90,7 +92,7 @@ function WalletListSwipeableComponent(props: Props) {
           navigation.navigate('walletDetails', {
             walletId,
             tokenId,
-            walletName: wallet.name ?? wallet.currencyInfo.displayName,
+            sceneTitle: sprintf(lstrings.create_wallet_account_metadata_name, wallet.currencyInfo.displayName),
             countryCode
           })
       )

src/components/themed/WalletListSwipeableCurrencyRow.tsx

@@ -2,12 +2,14 @@ import { EdgeCurrencyWallet, EdgeToken, EdgeTokenId } from 'edge-core-js'
 import * as React from 'react'
 import { Text } from 'react-native'
 import { SharedValue } from 'react-native-reanimated'
+import { sprintf } from 'sprintf-js'
 
 import { checkAndShowLightBackupModal } from '../../actions/BackupModalActions'
 import { getFirstOpenInfo } from '../../actions/FirstOpenActions'
 import { selectWalletToken } from '../../actions/WalletActions'
 import { Fontello } from '../../assets/vector/index'
 import { useHandler } from '../../hooks/useHandler'
+import { lstrings } from '../../locales/strings'
 import { useDispatch, useSelector } from '../../types/reactRedux'
 import { NavigationBase, WalletsTabSceneProps } from '../../types/routerTypes'
 import { EdgeTouchableOpacity } from '../common/EdgeTouchableOpacity'
@@ -89,7 +91,7 @@ function WalletListSwipeableCurrencyRowComponent(props: Props) {
           navigation.navigate('walletDetails', {
             tokenId,
             walletId: wallet.id,
-            walletName: wallet.name ?? wallet.currencyInfo.displayName,
+            sceneTitle: sprintf(lstrings.create_wallet_account_metadata_name, wallet.currencyInfo.displayName),
             countryCode
           })
         }