Skip to content

Commit cf4e4fc

Browse files
committed
fixup! fixup! Fix types
1 parent 9e93fde commit cf4e4fc

File tree

2 files changed

+26
-19
lines changed

2 files changed

+26
-19
lines changed

src/plugins/ramps/infinite/infiniteApi.ts

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -668,18 +668,17 @@ export const makeInfiniteApi = (config: InfiniteApiConfig): InfiniteApi => {
668668
accounts: bankAccountCache.map(account => ({
669669
id: account.id,
670670
type: 'EXTERNAL_BANK_ACCOUNT',
671-
status:
672-
account.verificationStatus === 'pending' ? 'PENDING' : 'ACTIVE',
673-
currency: 'USD',
671+
status: account.status === 'PENDING' ? 'PENDING' : 'ACTIVE',
672+
currency: account.currency,
674673
bankName: account.bankName,
675-
accountNumber: `****${account.last4}`,
676-
routingNumber: '****0021',
674+
accountNumber: account.accountNumber,
675+
routingNumber: account.routingNumber,
677676
accountType: 'checking',
678-
holderName: account.accountName,
679-
createdAt: new Date().toISOString(),
677+
holderName: account.holderName,
678+
createdAt: account.createdAt,
680679
metadata: {
681680
externalAccountId: `ext_acct_${Date.now()}`,
682-
verificationStatus: account.verificationStatus
681+
verificationStatus: account.status
683682
}
684683
})),
685684
totalCount: bankAccountCache.length
@@ -710,11 +709,15 @@ export const makeInfiniteApi = (config: InfiniteApiConfig): InfiniteApi => {
710709
id: `acct_bank_${Date.now()}_${Math.random()
711710
.toString(36)
712711
.substring(7)}`,
713-
type: 'bank_account',
712+
type: 'EXTERNAL_BANK',
713+
status: 'PENDING',
714+
currency: 'USD',
714715
bankName: params.bankName,
715-
accountName: params.accountName,
716-
last4: params.accountNumber.slice(-4),
717-
verificationStatus: 'pending'
716+
accountNumber: `****${params.accountNumber.slice(-4)}`,
717+
routingNumber: `****${params.routingNumber.slice(-4)}`,
718+
holderName: params.accountOwnerName,
719+
createdAt: new Date().toISOString(),
720+
metadata: {}
718721
}
719722

720723
// Add to cache

src/plugins/ramps/infinite/infiniteApiTypes.ts

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ export const asInfiniteCustomerResponse = asJSON(
198198
id: asString,
199199
type: asString,
200200
status: asInfiniteCustomerStatus,
201-
countryCode: asString,
201+
countryCode: asEither(asString, asNull),
202202
createdAt: asString
203203
})
204204
})
@@ -231,11 +231,15 @@ export const asInfiniteBankAccountRequest = asObject({
231231
export const asInfiniteBankAccountResponse = asJSON(
232232
asObject({
233233
id: asString,
234-
type: asValue('bank_account'),
234+
type: asString, // 'EXTERNAL_BANK', etc.
235+
status: asString, // 'ACTIVE', 'PENDING', etc.
236+
currency: asString,
235237
bankName: asString,
236-
accountName: asString,
237-
last4: asString,
238-
verificationStatus: asString
238+
accountNumber: asString, // Masked like '****6666'
239+
routingNumber: asString, // Masked like '****6789'
240+
holderName: asString,
241+
createdAt: asString,
242+
metadata: asObject({})
239243
})
240244
)
241245

@@ -255,8 +259,8 @@ export const asInfiniteCustomerAccountsResponse = asJSON(
255259
holderName: asString,
256260
createdAt: asString,
257261
metadata: asObject({
258-
externalAccountId: asEither(asString, asNull),
259-
verificationStatus: asString
262+
externalAccountId: asOptional(asEither(asString, asNull)),
263+
verificationStatus: asOptional(asString)
260264
})
261265
})
262266
),

0 commit comments

Comments
 (0)