fix(f4): limit CRSF external module speed to 3.75Mbps (#6923)

Co-authored-by: elecpower <elecpower@users.noreply.github.com>

Author: 3djc

companion/src/firmwares/boards.h

@@ -859,3 +859,8 @@ inline bool IS_STM32H7(Board::Type board)
          IS_JUMPER_T15PRO(board) ||
          IS_RADIOMASTER_TX15(board);
 }
+
+inline bool IS_STM32F2F4(Board::Type board)
+{
+  return (!IS_STM32H5(board) && !IS_STM32H7(board));
+}

companion/src/firmwares/edgetx/yaml_modeldata.cpp

@@ -1504,6 +1504,12 @@ bool convert<ModelData>::decode(const Node& node, ModelData& rhs)
     rhs.moduleData[i].modelId = modelIds[i];
   }
 
+  // v2.12 CRSF limit external module to 3.75M for older boards
+  if (IS_STM32F2F4(board) &&
+      rhs.moduleData[1].protocol == PULSES_CROSSFIRE &&
+      rhs.moduleData[1].crsf.telemetryBaudrate > 4)
+    rhs.moduleData[1].crsf.telemetryBaudrate = 4;
+
   if (node["failsafeChannels"]) {
     int failsafeChans[CPN_MAX_CHNOUT];
     memset(failsafeChans, 0, sizeof(failsafeChans));

companion/src/firmwares/moduledata.cpp

@@ -641,12 +641,16 @@ AbstractStaticItemModel * ModuleData::protocolItemModel(GeneralSettings & settin
   return mdl;
 }
 
-AbstractStaticItemModel * ModuleData::telemetryBaudrateItemModel(unsigned int  protocol)
+AbstractStaticItemModel * ModuleData::telemetryBaudrateItemModel(unsigned int protocol, int moduleIdx, int board)
 {
   AbstractStaticItemModel * mdl = new AbstractStaticItemModel();
   mdl->setName("moduledata.baudrate");
 
   for (int i = 0; i < moduleBaudratesList.size(); i++) {
+    // CRSF limit external module to 3.75M for older boards
+    if (protocol == PULSES_CROSSFIRE && moduleIdx == 1 &&
+        IS_STM32F2F4((Board::Type)board) && i > 4) break;
+
     if (protocol == PULSES_GHOST && i >= 2) break;
     mdl->appendToItemList(moduleBaudratesList.at(i), i);
   }

companion/src/firmwares/moduledata.h

@@ -235,7 +235,7 @@ class ModuleData {
     static AbstractStaticItemModel * internalModuleItemModel(int board = -1);
     static bool isProtocolAvailable(int moduleidx, unsigned int  protocol, GeneralSettings & generalSettings);
     static AbstractStaticItemModel * protocolItemModel(GeneralSettings & settings);
-    static AbstractStaticItemModel * telemetryBaudrateItemModel(unsigned int protocol);
+    static AbstractStaticItemModel * telemetryBaudrateItemModel(unsigned int protocol, int moduleIdx = -1, int board = 0);
     static bool isAvailable(PulsesProtocol proto, int port = 0);  //  moved from OpenTxFirmware EdgeTX v2.9 - TODO remove and use isProtocolAvailable
 
     QString afhds2aMode1ToString() const;

companion/src/modeledit/setup_module.cpp

@@ -352,7 +352,7 @@ void ModulePanel::update()
       case PULSES_CROSSFIRE:
         mask |= MASK_CHANNELS_RANGE | MASK_RX_NUMBER | MASK_BAUDRATE | MASK_CSRF_ARMING_MODE;
         module.channelsCount = 16;
-        ui->telemetryBaudrate->setModel(ModuleData::telemetryBaudrateItemModel(protocol));
+        ui->telemetryBaudrate->setModel(ModuleData::telemetryBaudrateItemModel(protocol, moduleIdx, board));
         ui->telemetryBaudrate->setField(module.crsf.telemetryBaudrate);
         ui->crsfArmingMode->setCurrentIndex(module.crsf.crsfArmingMode);
         if (module.crsf.crsfArmingMode == ModuleData::CRSF_ARMING_MODE_SWITCH) {
@@ -428,10 +428,13 @@ void ModulePanel::update()
     mask |= MASK_PPM_FIELDS | MASK_CHANNELS_RANGE | MASK_CHANNELS_COUNT;
   }
 
-  if (isExternalModule(moduleIdx))
+  if (isExternalModule(moduleIdx)) {
+    ui->label_baudrate->setVisible(mask & MASK_BAUDRATE);
     ui->telemetryBaudrate->setVisible(mask & MASK_BAUDRATE);
-  else
+  } else {
+    ui->label_baudrate->setVisible(false);
     ui->telemetryBaudrate->setVisible(false);
+  }
 
   ui->label_protocol->setVisible(mask & MASK_PROTOCOL);
   ui->protocol->setVisible(mask & MASK_PROTOCOL);