GPU: Some fixes for char / unsigned char handling

Author: davidrohr

GPU/GPUTracking/DataCompression/GPUTPCCompressionKernels.cxx

@@ -33,7 +33,7 @@ GPUdii() void GPUTPCCompressionKernels::Thread<GPUTPCCompressionKernels::step0at
   GPUTPCCompression& GPUrestrict() compressor = processors.tpcCompressor;
   const GPUParam& GPUrestrict() param = processors.param;
 
-  char lastLeg = 0;
+  unsigned char lastLeg = 0;
   int myTrack = 0;
   for (unsigned int i = get_global_id(0); i < ioPtrs.nMergedTracks; i += get_global_size(0)) {
     GPUbarrierWarp();

GPU/GPUTracking/Definitions/GPUSettingsList.h

@@ -128,7 +128,7 @@ AddOptionRTC(cfInnerThreshold, unsigned char, 0, "", 0, "Cluster Finder extends
 AddOptionRTC(cfMinSplitNum, unsigned char, 1, "", 0, "Minimum number of split charges in a cluster for the cluster to be marked as split")
 AddOptionRTC(cfNoiseSuppressionEpsilon, unsigned char, 10, "", 0, "Cluster Finder: Difference between peak and charge for the charge to count as a minima during noise suppression")
 AddOptionRTC(cfNoiseSuppressionEpsilonRelative, unsigned char, 76, "", 0, "Cluster Finder: Difference between peak and charge for the charge to count as a minima during noise suppression, relative as fraction of 255")
-AddOptionRTC(nWays, signed char, 3, "", 0, "Do N fit passes in final fit of merger")
+AddOptionRTC(nWays, unsigned char, 3, "", 0, "Do N fit passes in final fit of merger")
 AddOptionRTC(nWaysOuter, signed char, 0, "", 0, "Store outer param")
 AddOptionRTC(trackFitRejectMode, signed char, 5, "", 0, "0: no limit on rejection or missed hits, >0: break after n rejected hits, <0: reject at max -n hits")
 AddOptionRTC(dEdxTruncLow, unsigned char, 2, "", 0, "Low truncation threshold, fraction of 128")

GPU/GPUTracking/Merger/GPUTPCGMMerger.cxx

@@ -2089,7 +2089,7 @@ GPUd() void GPUTPCGMMerger::Finalize1(int nBlocks, int nThreads, int iBlock, int
     if (!trk.OK() || trk.NClusters() == 0) {
       continue;
     }
-    char goodLeg = mClusters[trk.FirstClusterRef() + trk.NClusters() - 1].leg;
+    unsigned char goodLeg = mClusters[trk.FirstClusterRef() + trk.NClusters() - 1].leg;
     for (unsigned int j = 0; j < trk.NClusters(); j++) {
       int id = mClusters[trk.FirstClusterRef() + j].num;
       unsigned int weight = mTrackOrderAttach[i] | attachAttached;

GPU/GPUTracking/display/GPUDisplayFrontendGlfw.cxx

@@ -167,7 +167,7 @@ void GPUDisplayFrontendGlfw::GetKey(int key, int scancode, int mods, int& keyOut
   if (specialKey) {
     keyOut = keyPressOut = specialKey;
   } else {
-    keyOut = keyPressOut = localeKey;
+    keyOut = keyPressOut = (unsigned char)localeKey;
     if (keyPressOut >= 'a' && keyPressOut <= 'z') {
       keyPressOut += 'A' - 'a';
     }
@@ -193,7 +193,7 @@ void GPUDisplayFrontendGlfw::key_callback(GLFWwindow* window, int key, int scanc
     if (action == GLFW_PRESS) {
       me->mLastKeyDown = handleKey;
     } else if (action == GLFW_RELEASE) {
-      keyPress = me->mKeyDownMap[handleKey];
+      keyPress = (unsigned char)me->mKeyDownMap[handleKey];
       me->mKeys[keyPress] = false;
       me->mKeysShift[keyPress] = false;
     }

GPU/GPUTracking/display/GPUDisplayFrontendX11.cxx

@@ -147,7 +147,7 @@ void GPUDisplayFrontendX11::GetKey(XEvent& event, int& keyOut, int& keyPressOut)
     tmpString[0] = 0;
   }
   int specialKey = GetKey(sym);
-  int localeKey = tmpString[0];
+  int localeKey = (unsigned char)tmpString[0];
   // GPUInfo("Key: keycode %d -> sym %d (%c) key %d (%c) special %d (%c)", (int)event.xkey.keycode, (int)sym, (char)sym, (int)localeKey, (char)localeKey, (int)specialKey, (char)specialKey);
 
   if (specialKey) {