Skip to content

Commit 5c80405

Browse files
committed
UpdatesFragment: Extract new update dialog msg string to resource
See #348
1 parent 7236456 commit 5c80405

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

app/src/main/java/com/edricchan/studybuddy/ui/modules/updates/UpdatesFragment.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ class UpdatesFragment : ViewBindingFragment<FragUpdatesBinding>(FragUpdatesBindi
262262
requireContext().showMaterialAlertDialog {
263263
setTitle(getString(R.string.update_dialog_title_new, appUpdate.latestVersion))
264264
setIcon(R.drawable.ic_system_update_24dp)
265-
setMessage("What's new:\n${appUpdate.releaseNotes}")
265+
setMessage(getString(R.string.new_update_dialog_msg, appUpdate.releaseNotes))
266266
setNegativeButton(android.R.string.cancel, null)
267267
setPositiveButton(R.string.update_dialog_positive_btn_text) { _, _ ->
268268
// Check if the write external storage permission has been granted

app/src/main/res/values/updates_strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
downloaded</string>
3232
<string name="update_dialog_positive_btn_text">Download build</string>
3333
<string name="update_dialog_title_new">New version (%s) available!</string>
34+
<string name="new_update_dialog_msg">What\'s new:\n%s</string>
3435
<string name="update_perm_rationale_dialog_deny">Deny</string>
3536

3637
<string name="update_perm_rationale_dialog_grant">Grant</string>

0 commit comments

Comments
 (0)