Add help and usage to urldecode

Author: Eetami

README.md

@@ -1,18 +1,25 @@
-# URL Encode
+# URL Encode & Decide
 
-A simple URL encoder written in bash.
+A simple URL encoder and decoder written in bash.
 
-The scripts reads a single line from stdin and applies urlencoding to it.
+The scripts read a single line from stdin and applies URL encoding/decoding to it.
 
-## Arguments
+## urlencode arguments
 
 -h : Print help
 
 -i : Don't URL encode given characters
 
+## urldecode arguments
+
+-h : Print help
+
 ## Example
 
 ```console
 $ urlencode -i 'äö' <<<"pääkkösen paja"
 pääkkösen%20paja
+
+$ urldecode <<<"p%E4%E4kk%F6sen%20paja"
+pääkkösen paja
 ```

urldecode

@@ -1,11 +1,38 @@
 #!/bin/bash
 
+HELP_TEXT="urldecode [-h]
+
+The script reads a single line from stdin and applies URL decoding to it.
+
+Example:
+$ urldecode <<<\"p%E4%E4kk%F6sen%20paja\"
+pääkkösen paja
+"
+
 declare hex_regex='[a-fA-F0-9]{2}'
 
 declare output=""
 
+while getopts 'h' opt; do
+  case $opt in
+    h)
+      echo "${HELP_TEXT}"
+      exit 0
+      ;;
+    ?)
+      echo "Unrecognized option: -${OPTARG}" >&2
+      exit 1
+      ;;
+  esac
+done
+
 read -rt .1 str
 
+if [ -z "$str" ]; then
+  echo "Missing stdin, check usage with urldecode -h" >&2
+  exit 1
+fi
+
 for ((i=0; i < ${#str}; i++)); do
   char="${str:i:1}"
   if [ "$char" = "%" ]; then

urlencode

@@ -2,7 +2,7 @@
 
 HELP_TEXT="urlencode [-h] [-i chars]
 
-The scripts reads single line from stdin and applies URL encoding to it.
+The script reads a single line from stdin and applies URL encoding to it.
 
 URL encoding can be disabled for select characters using the -i option.
 
@@ -14,7 +14,7 @@ pääkkösen%20paja
 declare unreserved_chars_regex='[a-zA-Z0-9\.~_\-]'
 declare -A ignored
 
-while getopts ':i:h' opt; do
+while getopts 'i:h' opt; do
   case $opt in
     i)
       for ((i=0; i < ${#OPTARG}; i++)); do
@@ -26,7 +26,7 @@ while getopts ':i:h' opt; do
       exit 0
       ;;
     ?)
-      echo Unrecognized option: -${OPTARG} >&2
+      echo "Unrecognized option: -${OPTARG}" >&2
       exit 1
       ;;
   esac