fix: handle invalid download paths when removable drives are disconnected

Author: Efeckc17

core/downloader.py

@@ -130,9 +130,22 @@ def run(self):
 
             self.log_signal.emit(f"Starting download to: {self.task.folder}")
 
-            if not os.path.exists(self.task.folder):
-                os.makedirs(self.task.folder, exist_ok=True)
-                self.log_signal.emit(f"Created download directory: {self.task.folder}")
+            try:
+                if not os.path.exists(self.task.folder):
+                    os.makedirs(self.task.folder, exist_ok=True)
+                    self.log_signal.emit(f"Created download directory: {self.task.folder}")
+            except (OSError, PermissionError) as e:
+                self.status_signal.emit(self.row, "Download Error")
+                error_msg = f"Cannot access download directory: {self.task.folder}\n"
+                error_msg += f"Error: {str(e)}\n"
+                error_msg += "Possible causes:\n"
+                error_msg += "- Drive not connected (USB/external drive)\n"
+                error_msg += "- Network drive disconnected\n"
+                error_msg += "- Insufficient permissions\n"
+                error_msg += "- Path no longer exists\n\n"
+                error_msg += "Please select a valid download location in Settings."
+                self.log_signal.emit(error_msg)
+                return
 
             if self.task.playlist:
                 self.status_signal.emit(self.row, "Loading Playlist...")

core/profile.py

@@ -102,7 +102,15 @@ def remove_profile_picture(self):
         self.save_profile()
 
     def get_download_path(self):
-        return self.data.get("download_path", os.getcwd())
+        path = self.data.get("download_path", os.getcwd())
+        if not os.path.exists(path):
+            fallback = os.path.join(os.path.expanduser("~"), "Downloads")
+            if not os.path.exists(fallback):
+                fallback = os.getcwd()
+            self.data["download_path"] = fallback
+            self.save_profile()
+            return fallback
+        return path
 
     def get_proxy(self):
         return self.data.get("proxy", "")

core/version.py

@@ -1,4 +1,4 @@
-VERSION = "v5.0.20"
+VERSION = "v5.0.21"
 VERSION_SHORT = "v5.0"
 
 def get_version(short=False):

ui/main_window.py

@@ -159,6 +159,15 @@ def add_scheduled_dialog(self):
         dialog = ScheduleAddDialog(self)
         dialog.exec_()
     def start_queue(self):
+        download_path = self.user_profile.get_download_path()
+        if not os.path.exists(download_path):
+            QMessageBox.warning(self, "Invalid Download Path",
+                f"Download folder does not exist:\n{download_path}\n\n"
+                "The folder may have been deleted or the drive may be disconnected.\n"
+                "Please select a new download location in Settings.")
+            self.append_log(f"Queue start aborted - invalid path: {download_path}")
+            return
+        
         count_started = 0
         for r in range(self.queue_table.rowCount()):
             st_item = self.queue_table.item(r, 4)
@@ -170,7 +179,7 @@ def start_queue(self):
                     playlist = ("playlist" in typ)
                     current_format = "mp4"
                     row_idx = r
-                    tsk = DownloadTask(url, self.user_profile.get_default_resolution(), self.user_profile.get_download_path(), self.user_profile.get_proxy(), audio_only=audio, playlist=playlist, output_format=current_format, audio_format=self.user_profile.get_audio_format() if audio else None, audio_quality=self.user_profile.get_audio_quality() if audio else "320", from_queue=True)
+                    tsk = DownloadTask(url, self.user_profile.get_default_resolution(), download_path, self.user_profile.get_proxy(), audio_only=audio, playlist=playlist, output_format=current_format, audio_format=self.user_profile.get_audio_format() if audio else None, audio_quality=self.user_profile.get_audio_quality() if audio else "320", from_queue=True)
                     self.run_task(tsk, row_idx)
                     self.queue_table.setItem(r, 4, QTableWidgetItem("Started"))
                     count_started += 1
@@ -182,6 +191,11 @@ def remove_scheduled_item(self):
         for r in sorted(sel, reverse=True):
             self.scheduler_table.removeRow(r)
     def check_scheduled_downloads(self):
+        download_path = self.user_profile.get_download_path()
+        if not os.path.exists(download_path):
+            self.append_log(f"Scheduled download skipped - invalid path: {download_path}")
+            return
+        
         now = QDateTime.currentDateTime()
         for r in range(self.scheduler_table.rowCount()):
             dt_str = self.scheduler_table.item(r, 0).text()
@@ -192,16 +206,25 @@ def check_scheduled_downloads(self):
                 t = self.scheduler_table.item(r, 2).text().lower()
                 s = (self.scheduler_table.item(r, 3).text() == "Yes")
                 audio = ("audio" in t)
-                task = DownloadTask(u, self.user_profile.get_default_resolution(), self.user_profile.get_download_path(), self.user_profile.get_proxy(), audio_only=audio, playlist=False, subtitles=s, audio_format=self.user_profile.get_audio_format() if audio else None, audio_quality=self.user_profile.get_audio_quality() if audio else "320", from_queue=True)
+                task = DownloadTask(u, self.user_profile.get_default_resolution(), download_path, self.user_profile.get_proxy(), audio_only=audio, playlist=False, subtitles=s, audio_format=self.user_profile.get_audio_format() if audio else None, audio_quality=self.user_profile.get_audio_quality() if audio else "320", from_queue=True)
                 self.run_task(task, r)
                 self.scheduler_table.setItem(r, 4, QTableWidgetItem("Started"))
     def start_download_simple(self, url_edit, audio=False, playlist=False):
         link = url_edit.text().strip()
         if not link:
             QMessageBox.warning(self, "Error", "No URL given.")
             return
-        task = DownloadTask(link, self.user_profile.get_default_resolution(), self.user_profile.get_download_path(), self.user_profile.get_proxy(), audio_only=audio, playlist=playlist, audio_format=self.user_profile.get_audio_format() if audio else None, audio_quality=self.user_profile.get_audio_quality() if audio else "320", from_queue=False)
-        # History will be written directly by the downloader
+        
+        download_path = self.user_profile.get_download_path()
+        if not os.path.exists(download_path):
+            QMessageBox.warning(self, "Invalid Download Path",
+                f"Download folder does not exist:\n{download_path}\n\n"
+                "The folder may have been deleted or the drive may be disconnected.\n"
+                "Please select a new download location in Settings.")
+            self.append_log(f"Download aborted - invalid path: {download_path}")
+            return
+        
+        task = DownloadTask(link, self.user_profile.get_default_resolution(), download_path, self.user_profile.get_proxy(), audio_only=audio, playlist=playlist, audio_format=self.user_profile.get_audio_format() if audio else None, audio_quality=self.user_profile.get_audio_quality() if audio else "320", from_queue=False)
         self.run_task(task, None)
     def run_task(self, task, row):
         if task.playlist:
@@ -283,12 +306,20 @@ def update_queue_info(self, row, title, channel):
                 # History will be written directly by the downloader
     def open_download_folder(self):
         folder = self.user_profile.get_download_path()
+        if not os.path.exists(folder):
+            QMessageBox.warning(self, "Folder Not Found", 
+                f"Download folder does not exist:\n{folder}\n\n"
+                "The folder may have been deleted or the drive may be disconnected.\n"
+                "Please select a new download location in Settings.")
+            self.append_log(f"Cannot open folder - path does not exist: {folder}")
+            return
+        
         try:
             if sys.platform.startswith('win'):
                 os.startfile(folder)
-            elif sys.platform.startswith('darwin'):  # macOS
+            elif sys.platform.startswith('darwin'):
                 subprocess.run(['open', folder])
-            else:  # Linux
+            else:
                 subprocess.run(['xdg-open', folder])
         except (OSError, subprocess.SubprocessError, FileNotFoundError) as e:
             QMessageBox.warning(self, "Error", f"Could not open folder: {str(e)}")

ui/pages/settings_page.py

@@ -5,12 +5,17 @@
 from PySide6.QtGui import QFont
 from ui.components.animated_button import AnimatedButton
 from core.version import get_version
+import os
 
 class SettingsPage(QWidget):
     def __init__(self, parent=None):
         super().__init__(parent)
         self.parent = parent
         self.init_ui()
+    
+    def showEvent(self, event):
+        super().showEvent(event)
+        self.check_download_path_validity()
 
     def init_ui(self):
 
@@ -248,14 +253,26 @@ def init_ui(self):
         p_hl.setContentsMargins(10, 10, 10, 10)
         self.download_path_edit = QLineEdit()
         self.download_path_edit.setReadOnly(True)
-        self.download_path_edit.setText(self.parent.user_profile.get_download_path())
-        self.download_path_edit.setToolTip(
-            "Download destination folder:\n"
-            "• All downloads will be saved here\n"
-            "• Playlists create subfolders automatically\n"
-            "• Make sure you have enough disk space\n\n"
-            "Click Browse to change location"
-        )
+        current_path = self.parent.user_profile.get_download_path()
+        self.download_path_edit.setText(current_path)
+        
+        if not os.path.exists(current_path):
+            self.download_path_edit.setStyleSheet("QLineEdit { color: #ff4444; font-weight: bold; }")
+            self.download_path_edit.setToolTip(
+                "⚠️ WARNING: Path does not exist!\n\n"
+                f"Current path: {current_path}\n\n"
+                "This folder may have been deleted or the drive may be disconnected.\n"
+                "Please select a new download location by clicking Browse."
+            )
+        else:
+            self.download_path_edit.setStyleSheet("")
+            self.download_path_edit.setToolTip(
+                "Download destination folder:\n"
+                "• All downloads will be saved here\n"
+                "• Playlists create subfolders automatically\n"
+                "• Make sure you have enough disk space\n\n"
+                "Click Browse to change location"
+            )
 
         b_br = AnimatedButton("Browse")
         b_br.clicked.connect(self.select_download_path)
@@ -428,8 +445,23 @@ def geo_country_changed(self, index):
         self.parent.append_log(f"Geo-bypass country set to: {country_name}")
 
     def select_download_path(self):
-        folder = QFileDialog.getExistingDirectory(self, "Select Download Folder")
+        current_path = self.parent.user_profile.get_download_path()
+        start_dir = current_path if os.path.exists(current_path) else os.path.expanduser("~")
+        
+        folder = QFileDialog.getExistingDirectory(self, "Select Download Folder", start_dir)
         if folder:
+            if not os.path.exists(folder):
+                QMessageBox.warning(self, "Invalid Path", 
+                    f"Selected path does not exist:\n{folder}\n\n"
+                    "Please select a valid directory.")
+                return
+            
+            if not os.access(folder, os.W_OK):
+                QMessageBox.warning(self, "Permission Denied",
+                    f"Cannot write to selected path:\n{folder}\n\n"
+                    "Please select a directory with write permissions.")
+                return
+            
             self.parent.user_profile.set_profile(
                 self.parent.user_profile.data["name"],
                 self.parent.user_profile.data["profile_picture"],
@@ -444,4 +476,34 @@ def toggle_logs(self):
         if self.parent.log_manager.log_dock_visible:
             self.show_logs_btn.setText("Hide Logs")
         else:
-            self.show_logs_btn.setText("Show Logs") 
+            self.show_logs_btn.setText("Show Logs")
+    
+    def check_download_path_validity(self):
+        current_path = self.parent.user_profile.get_download_path()
+        self.download_path_edit.setText(current_path)
+        
+        if not os.path.exists(current_path):
+            self.download_path_edit.setStyleSheet("QLineEdit { color: #ff4444; font-weight: bold; }")
+            self.download_path_edit.setToolTip(
+                "⚠️ WARNING: Path does not exist!\n\n"
+                f"Current path: {current_path}\n\n"
+                "This folder may have been deleted or the drive may be disconnected.\n"
+                "Please select a new download location by clicking Browse."
+            )
+            QMessageBox.warning(self, "Invalid Download Path",
+                f"⚠️ Download folder does not exist:\n{current_path}\n\n"
+                "Possible causes:\n"
+                "• External drive (USB/SD card) was removed\n"
+                "• Network drive disconnected\n"
+                "• Folder was deleted or moved\n\n"
+                "Downloads will fail until you select a valid location.\n"
+                "Click Browse to choose a new download folder.")
+        else:
+            self.download_path_edit.setStyleSheet("")
+            self.download_path_edit.setToolTip(
+                "Download destination folder:\n"
+                "• All downloads will be saved here\n"
+                "• Playlists create subfolders automatically\n"
+                "• Make sure you have enough disk space\n\n"
+                "Click Browse to change location"
+            )