fix(hash/equal): prevent defects with invalid date (#5878)

Author: Hoishin

.changeset/rude-things-carry.md

@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+prevent crash from Hash and Equal with invalid Date object

packages/effect/src/Equal.ts

@@ -52,7 +52,9 @@ function compareBoth(self: unknown, that: unknown): boolean {
             : false
         }
       } else if (self instanceof Date && that instanceof Date) {
-        return self.toISOString() === that.toISOString()
+        const t1 = self.getTime()
+        const t2 = that.getTime()
+        return t1 === t2 || (Number.isNaN(t1) && Number.isNaN(t2))
       } else if (self instanceof URL && that instanceof URL) {
         return self.href === that.href
       }

packages/effect/src/Hash.ts

@@ -53,6 +53,9 @@ export const hash: <A>(self: A) => number = <A>(self: A) => {
       if (self === null) {
         return string("null")
       } else if (self instanceof Date) {
+        if (Number.isNaN(self.getTime())) {
+          return string("Invalid Date")
+        }
         return hash(self.toISOString())
       } else if (self instanceof URL) {
         return hash(self.href)

packages/effect/test/Equal.test.ts

@@ -0,0 +1,17 @@
+import { describe, it } from "@effect/vitest"
+import { assertFalse, assertTrue } from "@effect/vitest/utils"
+import { Equal } from "effect"
+
+describe("Equal", () => {
+  it("invalid Date", () => {
+    const d1 = new Date("invalid")
+    const d2 = new Date("invalid")
+    assertTrue(Equal.equals(d1, d2))
+  })
+
+  it("Date(0) vs invalid Date", () => {
+    const epoch = new Date(0)
+    const invalid = new Date("invalid")
+    assertFalse(Equal.equals(epoch, invalid))
+  })
+})

packages/effect/test/Hash.test.ts

@@ -1,4 +1,4 @@
-import { describe, it } from "@effect/vitest"
+import { describe, expect, it } from "@effect/vitest"
 import { assertFalse, assertTrue, strictEqual } from "@effect/vitest/utils"
 import { absurd, Equal, Hash, HashSet, identity, Option, Utils } from "effect"
 
@@ -72,4 +72,9 @@ describe("Hash", () => {
     assertFalse(Hash.isHash(null))
     assertFalse(Hash.isHash({}))
   })
+
+  it("invalid Date", () => {
+    const invalidDate = new Date("invalid")
+    expect(() => Hash.hash(invalidDate)).not.toThrow()
+  })
 })