Add SafeIntegers support to @effect/sql-sqlite-bun client (#6016)

Co-authored-by: Tim Smart <hello@timsmart.co>

Author: 0xh3x

.changeset/nice-boats-enjoy.md

@@ -0,0 +1,5 @@
+---
+"@effect/sql-sqlite-bun": patch
+---
+
+feat(sql-sqlite-bun): add SafeIntegers support

packages/sql-sqlite-bun/examples/Client.test.ts

@@ -2,6 +2,7 @@ import { Reactivity } from "@effect/experimental"
 import { BunFileSystem } from "@effect/platform-bun"
 import { FileSystem } from "@effect/platform/FileSystem"
 import { SqliteClient } from "@effect/sql-sqlite-bun"
+import * as SqlClient from "@effect/sql/SqlClient"
 import { describe, expect, test } from "bun:test"
 import { Effect, pipe } from "effect"
 
@@ -28,4 +29,40 @@ describe("Client", () => {
         { id: 2, name: "world" }
       ])
     }).pipe(Effect.scoped, Effect.runPromise))
+
+  test("SafeIntegers returns bigint for large integers", () =>
+    Effect.gen(function*() {
+      const sql = yield* makeClient
+      const big = 9007199254740993n // 2^53 + 1
+
+      yield* sql`CREATE TABLE safe_int_test (id BIGINT)`
+      yield* sql`INSERT INTO safe_int_test (id) VALUES (${big})`
+
+      const resultSafe = (yield* sql`SELECT id FROM safe_int_test`.pipe(
+        Effect.provideService(SqlClient.SafeIntegers, true)
+      ))[0]?.id
+      expect(typeof resultSafe).toBe("bigint")
+      expect(resultSafe).toBe(big)
+
+      const resultDefault = (yield* sql`SELECT id FROM safe_int_test`)[0]?.id
+      expect(typeof resultDefault).not.toBe("bigint")
+    }).pipe(Effect.scoped, Effect.runPromise))
+
+  test("SafeIntegers works with values query", () =>
+    Effect.gen(function*() {
+      const sql = yield* makeClient
+      const big = 9007199254740993n // 2^53 + 1
+
+      yield* sql`CREATE TABLE safe_int_values_test (id BIGINT)`
+      yield* sql`INSERT INTO safe_int_values_test (id) VALUES (${big})`
+
+      const resultSafe = (yield* sql`SELECT id FROM safe_int_values_test`.values.pipe(
+        Effect.provideService(SqlClient.SafeIntegers, true)
+      ))[0]?.[0]
+      expect(typeof resultSafe).toBe("bigint")
+      expect(resultSafe).toBe(big)
+
+      const resultDefault = (yield* sql`SELECT id FROM safe_int_values_test`.values)[0]?.[0]
+      expect(typeof resultDefault).not.toBe("bigint")
+    }).pipe(Effect.scoped, Effect.runPromise))
 })

packages/sql-sqlite-bun/src/SqliteClient.ts

@@ -102,18 +102,32 @@ export const make = (
         sql: string,
         params: ReadonlyArray<unknown> = []
       ) =>
-        Effect.try({
-          try: () => (db.query(sql).all(...(params as any)) ?? []) as Array<any>,
-          catch: (cause) => new SqlError({ cause, message: "Failed to execute statement" })
+        Effect.withFiberRuntime<Array<any>, SqlError>((fiber) => {
+          const useSafeIntegers = Context.get(fiber.currentContext, Client.SafeIntegers)
+          const statement = db.query(sql)
+          // @ts-ignore bun-types missing safeIntegers method, fixed in https://github.com/oven-sh/bun/pull/26627
+          statement.safeIntegers(useSafeIntegers)
+          try {
+            return Effect.succeed((statement.all(...(params as any)) ?? []) as Array<any>)
+          } catch (cause) {
+            return Effect.fail(new SqlError({ cause, message: "Failed to execute statement" }))
+          }
         })
 
       const runValues = (
         sql: string,
         params: ReadonlyArray<unknown> = []
       ) =>
-        Effect.try({
-          try: () => (db.query(sql).values(...(params as any)) ?? []) as Array<any>,
-          catch: (cause) => new SqlError({ cause, message: "Failed to execute statement" })
+        Effect.withFiberRuntime<Array<any>, SqlError>((fiber) => {
+          const useSafeIntegers = Context.get(fiber.currentContext, Client.SafeIntegers)
+          const statement = db.query(sql)
+          // @ts-ignore bun-types missing safeIntegers method, fixed in https://github.com/oven-sh/bun/pull/26627
+          statement.safeIntegers(useSafeIntegers)
+          try {
+            return Effect.succeed((statement.values(...(params as any)) ?? []) as Array<any>)
+          } catch (cause) {
+            return Effect.fail(new SqlError({ cause, message: "Failed to execute statement" }))
+          }
         })
 
       return identity<SqliteConnection>({