fix log level cli arg infinite loop (#5677)

Author: nemmtor

.changeset/ten-crabs-serve.md

@@ -0,0 +1,5 @@
+---
+"@effect/cli": patch
+---
+
+fix log level cli arg infinite loop

packages/cli/src/internal/cliApp.ts

@@ -162,7 +162,7 @@ const handleBuiltInOption = <R, E, A>(
       const nextArgs = executable.split(/\s+/)
       // Filter out the log level option before re-executing the command
       for (let i = 0; i < args.length; i++) {
-        if (args[i] === "--log-level" || args[i - 1] === "--log-level") {
+        if (isLogLevelArg(args[i]) || isLogLevelArg(args[i - 1])) {
           continue
         }
         nextArgs.push(args[i])
@@ -356,3 +356,7 @@ const renderWizardArgs = (args: ReadonlyArray<string>) => {
     ))
   ])
 }
+
+const isLogLevelArg = (arg?: string) => {
+  return arg && (arg === "--log-level" || arg.startsWith("--log-level="))
+}

packages/cli/test/CliApp.test.ts

@@ -97,5 +97,21 @@ describe("CliApp", () => {
         yield* cli(["node", "logging.js", "--log-level", "debug"])
         expect(logLevel).toEqual(LogLevel.Debug)
       }).pipe(runEffect))
+
+    it("should set the minimum log level when using equals syntax (--log-level=...)", () =>
+      Effect.gen(function*() {
+        let logLevel: LogLevel.LogLevel | undefined = undefined
+        const logging = Command.make("logging").pipe(Command.withHandler(() =>
+          Effect.gen(function*() {
+            logLevel = yield* FiberRef.get(FiberRef.currentMinimumLogLevel)
+          })
+        ))
+        const cli = Command.run(logging, {
+          name: "Test",
+          version: "1.0.0"
+        })
+        yield* cli(["node", "logging.js", "--log-level=debug"])
+        expect(logLevel).toEqual(LogLevel.Debug)
+      }).pipe(runEffect))
   })
 })