Skip to content

Add @effect/sql-pglite package #4692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
evelant wants to merge 9 commits into
base: next-minor
Choose a base branch
from
Open

Add @effect/sql-pglite package #4692

evelant wants to merge 9 commits into from
+1,318 −308

Conversation

@evelant
Copy link
Contributor

@evelant evelant commented Apr 3, 2025

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Add @effect/sql-pglite package. An @effect/sql driver for PGlite, single user postgresql in the browser or node.

Related

  • Related Issue #
  • Closes #

@github-project-automation github-project-automation bot moved this to Discussion Ongoing in PR Backlog Apr 3, 2025
@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: cb5dfd6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@effect/sql-pglite Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-bot effect-bot force-pushed the next-minor branch 5 times, most recently from 02d328c to 1ea11b9 Compare April 4, 2025 15:48
@evelant
Copy link
Contributor Author

evelant commented Apr 4, 2025 •
edited
Loading

Not sure why the lint and docgen failed, they pass on my branch locally.

@effect-bot effect-bot force-pushed the next-minor branch 19 times, most recently from 4cba33b to 5c9e640 Compare April 14, 2025 00:33
@effect-bot effect-bot force-pushed the next-minor branch 2 times, most recently from f265f41 to 0fd314b Compare April 14, 2025 01:59
@evelant
Copy link
Contributor Author

evelant commented Dec 17, 2025

Sorry for taking forever to get back to this. I've been extremely busy. I cleaned everything up, addressed the review comments, rebased on main, and updated everything to match latest changes in sql. @tim-smart if you would take another look I'd appreciate it!

nikelborm
nikelborm reviewed Dec 17, 2025
View reviewed changes
packages/ai/ai/src/Prompt.ts

This comment was marked as resolved.

Sign in to view

Copy link
Contributor Author

@evelant evelant Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I'm not sure how that happened! Thanks for pointing it out, I'll try to clean it up, although I'm not sure of the best way to do so. Maybe I should copy the pglite changes to a new branch and open a new PR that's clean.

Copy link
Contributor Author

@evelant evelant Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah IDK what happened here. My history looks clean locally. The commits relating to pglite are clean. It seems that the most recent 5 commits from main are somehow included in the PR after I rebased. I'm not sure why.

Copy link
Contributor

@nikelborm nikelborm Dec 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because your PR is opened against next-minor branch, and should have been rebased against it. git rebase -i interactive mode is very helpful in such situations, and you can easily remove a few commits.

Copy link
Contributor Author

@evelant evelant Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I rebased from main but there are commits there that aren't in next-minor yet so they got picked up. I'm not sure what the right thing is here. Should I make a new PR with the pglite stuff on top of next-minor instead of main?

Copy link
Contributor

@nikelborm nikelborm Dec 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to make a new branch. Just make git rebase -i HEAD~12 and inside the interactive editor, delete rows with commits you don't want

Copy link
Contributor Author

@evelant evelant Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah got it, fixed

@effect-bot effect-bot force-pushed the next-minor branch 5 times, most recently from 24ae504 to 6bc6da5 Compare December 23, 2025 17:40
@effect-bot effect-bot force-pushed the next-minor branch 9 times, most recently from a2457a5 to 51a27ea Compare January 4, 2026 06:30
@effect-bot effect-bot force-pushed the next-minor branch 5 times, most recently from 7922be1 to 8fa279a Compare January 6, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tim-smart tim-smart tim-smart requested changes

@IMax153 IMax153 Awaiting requested review from IMax153

@gcanti gcanti Awaiting requested review from gcanti

@mikearnaldi mikearnaldi Awaiting requested review from mikearnaldi mikearnaldi is a code owner

+2 more reviewers

@ooga ooga ooga left review comments

@nikelborm nikelborm nikelborm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

PR Backlog
Status: Waiting on Author

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@evelant @caubut-charter @nikelborm @bwbuchanan @thewilkybarkid @tim-smart @ooga @mikearnaldi @schickling