Merge pull request #468 from Efficy/main

Fix: Missing exposed methods using script setup

Author: mariusa

src/App.vue

@@ -2091,11 +2091,11 @@ export default defineComponent({
       tag === tag.toLowerCase() && tag.length > 2 && tag.length < 6
 
     function onTagState(valid: string[], invalid: string[], duplicate: string[]) {
-      // console.log({
-      //   valid,
-      //   invalid,
-      //   duplicate,
-      // })
+      console.log({
+        valid,
+        invalid,
+        duplicate,
+      })
     }
 
     return {

src/components/BAvatar/BAvatar.vue

@@ -148,13 +148,6 @@ const textClasses = computed<string>(() => {
   return `text-${textVariant}`
 })
 
-const iconName = computed<string | undefined>(() => {
-  // TODO this should work with any icon font, eg icon="fa fa-cogs"
-  if (props.icon) return props.icon
-  if (!props.text && !props.src) return 'person-fill'
-  return undefined
-})
-
 const badgeStyle = computed<StyleValue>(() => {
   const offset = props.badgeOffset || '0px'
   const fontSize =
@@ -200,7 +193,6 @@ const onImgError = (e: Event): void => emit('img-error', e)
 </script>
 
 <script lang="ts">
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export const computeSize = (value: any): string | null => {
   const calcValue = isString(value) && isNumeric(value) ? toFloat(value, 0) : value
   return isNumber(calcValue) ? `${calcValue}px` : calcValue || null

src/components/BDropdown/BDropdown.vue

@@ -196,4 +196,8 @@ onMounted((): void => {
     },
   })
 })
+
+defineExpose({
+  hide,
+})
 </script>

src/components/BFormCheckbox/BFormCheckbox.vue

@@ -60,7 +60,7 @@ interface BFormCheckboxProps {
     | Record<string, unknown>
     | number
   value?: Array<unknown> | Set<unknown> | boolean | string | Record<string, unknown> | number
-  modelValue?: Array<unknown> | Set<unknown> | boolean
+  modelValue?: Array<unknown> | Set<unknown> | boolean | string | Record<string, unknown> | number
 }
 
 const props = withDefaults(defineProps<BFormCheckboxProps>(), {
@@ -93,14 +93,14 @@ const input = ref<HTMLElement>(null as unknown as HTMLElement)
 const isFocused = ref<boolean>(false)
 
 const localValue = computed({
-  get: () => {
+  get: (): unknown[] | Set<unknown> | boolean | undefined => {
     if (props.uncheckedValue) {
       if (!Array.isArray(props.modelValue)) {
         return props.modelValue === props.value
       }
       return props.modelValue.indexOf(props.value) > -1
     }
-    return props.modelValue
+    return props.modelValue as unknown[] | Set<unknown> | boolean | undefined
   },
   set: (newValue: any) => {
     let emitValue = newValue

src/components/BFormRadio/form-radio.spec.js

@@ -795,7 +795,7 @@ describe('form-radio', () => {
     expect(label.classes()).toContain('btn-secondary')
     await input.setValue(true)
     //await input.trigger('click')
-    console.log(label.classes(), wrapper.vm.modelValue)
+    //console.log(label.classes(), wrapper.vm.modelValue)
     expect(label.classes().length).toEqual(3)
     expect(label.classes()).toContain('active')
     expect(label.classes()).toContain('btn')

src/components/BFormSelect/BFormSelect.vue

@@ -109,6 +109,7 @@ onActivated(handleAutofocus)
 // /lifecycle events
 
 // computed
+// noinspection PointlessBooleanExpressionJS
 const classes = computed(() => ({
   'form-control': props.plain,
   [`form-control-${props.size}`]: props.size && props.plain,
@@ -126,14 +127,15 @@ const computedSelectSize = computed<number | undefined>(() => {
 })
 
 const computedAriaInvalid = computed<'grammar' | 'spelling' | boolean | undefined>(() => {
-  if (props.state === false) {
-    return true
-  }
-  if (props.state === true) {
+  // noinspection SuspiciousTypeOfGuard
+  if (typeof props.state === 'boolean') {
+    if (!props.state) {
+      return true
+    }
     return undefined
   }
   if (typeof props.ariaInvalid === 'boolean') {
-    if (props.ariaInvalid === false) {
+    if (!props.ariaInvalid) {
       return undefined
     }
     return props.ariaInvalid
@@ -169,4 +171,9 @@ const blur = () => {
   }
 }
 // /methods
+
+defineExpose({
+  blur,
+  focus,
+})
 </script>

src/components/BFormSelect/form-select-option.spec.js

@@ -1,6 +1,6 @@
 import {mount} from '@vue/test-utils'
 import BFormSelectOption from './BFormSelectOption.vue'
-import {describe, expect, it, vitest} from 'vitest'
+import {describe, expect, it} from 'vitest'
 
 describe('form-select-option', () => {
   it('has expected default structure', async () => {

src/components/BFormTags/form-tag.spec.js

@@ -1,6 +1,6 @@
 import {mount} from '@vue/test-utils'
 import BFormTag from './BFormTag.vue'
-import {describe, expect, it, vitest} from 'vitest'
+import {describe, expect, it} from 'vitest'
 
 describe('form-tag', () => {
   it('has expected structure', async () => {

src/components/BLink/link.spec.js

@@ -1,5 +1,5 @@
 import {mount} from '@vue/test-utils'
-import {createContainer} from '../../../tests/utils'
+//import {createContainer} from '../../../tests/utils'
 import BLink from './BLink.vue'
 import {describe, expect, it, vitest} from 'vitest'
 

src/components/BListGroup/list-group-item.spec.js

@@ -1,7 +1,7 @@
 import {mount} from '@vue/test-utils'
 import BListGroup from './BListGroup.vue'
 import BListGroupItem from './BListGroupItem.vue'
-import {describe, expect, it, vitest} from 'vitest'
+import {describe, expect, it} from 'vitest'
 
 describe('list-group > list-group-item', () => {
   it('default should have tag div', async () => {