Skip to content

Commit eeb0157

Browse files
committed
revert: remove booleanish
I added booleanish in a previous commit thinking about replacing boolean with booleanish. I think this is a good idea, but is best left for the future
1 parent ecba1b9 commit eeb0157

File tree

7 files changed

+0
-23
lines changed

7 files changed

+0
-23
lines changed

packages/bootstrap-vue-3/src/BootstrapVue.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,6 @@ export {
217217
export type {
218218
InputSize,
219219
ColorVariant,
220-
Booleanish,
221220
BreadcrumbItem,
222221
LinkTarget,
223222
ButtonVariant,

packages/bootstrap-vue-3/src/composables/index.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import useAlignment from './useAlignment'
2-
import useBooleanish from './useBooleanish'
32
import {createBreadcrumb, useBreadcrumb} from './useBreadcrumb'
43
import useEventListener from './useEventListener'
54
import {
@@ -18,7 +17,6 @@ import useId from './useId'
1817

1918
export {
2019
useAlignment,
21-
useBooleanish,
2220
createBreadcrumb,
2321
useBreadcrumb,
2422
useEventListener,
@@ -38,7 +36,6 @@ export {
3836

3937
export default {
4038
useAlignment,
41-
useBooleanish,
4239
createBreadcrumb,
4340
useBreadcrumb,
4441
useEventListener,
@@ -55,6 +52,3 @@ export default {
5552
normalizeOptions,
5653
useId,
5754
}
58-
59-
// Export only the types that are classified by props. Export that the type even if it's complex counterpart uses inline type
60-
// Finally, for props, add booleanish as an option, and create a util that resolves it. Or possibly a composable with computed to cache it?

packages/bootstrap-vue-3/src/composables/useBooleanish.ts

Lines changed: 0 additions & 5 deletions
This file was deleted.

packages/bootstrap-vue-3/src/types/Booleanish.d.ts

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/bootstrap-vue-3/src/types/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
export type {default as Alignment} from './Alignment'
22
export type {default as Animation} from './Animation'
3-
export type {default as Booleanish} from './Booleanish'
43
export type {default as BootstrapVueOptions} from './BootstrapVueOptions'
54
export type {default as BreadcrumbItem} from './BreadcrumbItem'
65
export type {BreadcrumbItemObject} from './BreadcrumbItem'

packages/bootstrap-vue-3/src/utils/index.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ import normalizeSlot from './normalizeSlot'
4545
import {stringToInteger, toFloat, toInteger, toPercison} from './number'
4646
import {assign, defineProperties, defineProperty, omit, readonlyDescriptor} from './object'
4747
import {pluckProps, suffixPropName} from './props'
48-
import resolveBooleanish from './resolveBooleanish'
4948
import {isLink} from './router'
5049
import {startCase, toString, upperFirst} from './stringUtils'
5150

@@ -59,7 +58,6 @@ export {
5958
startCase,
6059
toString,
6160
upperFirst,
62-
resolveBooleanish,
6361
attemptFocus,
6462
contains,
6563
stringToInteger,
@@ -134,7 +132,6 @@ export default {
134132
suffixPropName,
135133
toPercison,
136134
assign,
137-
resolveBooleanish,
138135
defineProperties,
139136
defineProperty,
140137
omit,

packages/bootstrap-vue-3/src/utils/resolveBooleanish.ts

Lines changed: 0 additions & 4 deletions
This file was deleted.

0 commit comments

Comments
 (0)