Clean up code.

Early return vs variable creation and return.
Avoid commented code to don't report parameters as not used

Author: sfe-efficy

src/App.vue

@@ -2091,11 +2091,11 @@ export default defineComponent({
       tag === tag.toLowerCase() && tag.length > 2 && tag.length < 6
 
     function onTagState(valid: string[], invalid: string[], duplicate: string[]) {
-      // console.log({
-      //   valid,
-      //   invalid,
-      //   duplicate,
-      // })
+      console.log({
+        valid,
+        invalid,
+        duplicate,
+      })
     }
 
     return {

src/components/BAvatar/BAvatar.vue

@@ -200,7 +200,6 @@ const onImgError = (e: Event): void => emit('img-error', e)
 </script>
 
 <script lang="ts">
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export const computeSize = (value: any): string | null => {
   const calcValue = isString(value) && isNumeric(value) ? toFloat(value, 0) : value
   return isNumber(calcValue) ? `${calcValue}px` : calcValue || null

src/components/BPagination/BPagination.vue

@@ -75,7 +75,7 @@ export default defineComponent({
     )
 
     const startNumber = computed(() => {
-      let lStartNumber = 1
+      let lStartNumber: number
       const pagesLeft: number = numberOfPages.value - props.modelValue
 
       if (pagesLeft + 2 < props.limit && props.limit > ELLIPSIS_THRESHOLD) {
@@ -156,21 +156,6 @@ export default defineComponent({
       return n
     })
 
-    const pageNumberfinal = computed(() => {
-      let n: number = numberOfLinks.value
-
-      if (showFirstDots.value && props.firstNumber && startNumber.value < 4) {
-        n = n + 2
-      }
-      const lastPageNumber = startNumber.value + n - 1
-
-      if (showLastDots.value && props.lastNumber && lastPageNumber > numberOfPages.value - 3) {
-        n = n + (lastPageNumber === numberOfPages.value - 2 ? 2 : 3)
-      }
-      n = Math.min(n, numberOfPages.value - startNumber.value + 1)
-      return n
-    })
-
     const showLastDots = computed(() => {
       const paginationWindowEnd = numberOfPages.value - numberOfLinks.value // The start of the last window of page links
 
@@ -474,7 +459,8 @@ export default defineComponent({
         buttons.push(gotoLastPageButton)
       }
 
-      const $pagination = h(
+      //pagination
+      return h(
         'ul',
         {
           'class': ['pagination', btnSize.value, alignment.value, styleClass.value],
@@ -484,7 +470,6 @@ export default defineComponent({
         },
         buttons
       )
-      return $pagination
     }
   },
 })

src/components/BToast/BToast.vue

@@ -64,7 +64,7 @@ export default defineComponent({
     let resumeDismiss: number
 
     const clearDismissTimer = () => {
-      if (dismissTimer === undefined) return
+      if (typeof dismissTimer === 'undefined') return
       clearTimeout(dismissTimer)
       dismissTimer = undefined
     }
@@ -121,14 +121,6 @@ export default defineComponent({
       startDismissTimer()
     }
 
-    const toggle = () => {
-      if (props.modelValue) {
-        hide()
-      } else {
-        show()
-      }
-    }
-
     watch(
       () => props.modelValue,
       (newValue) => {
@@ -165,15 +157,8 @@ export default defineComponent({
       emit('update:modelValue', false)
     }
 
-    const transitionHandlers = computed(() => ({
-      OnBeforeEnter,
-      OnAfterEnter,
-      OnBeforeLeave,
-      OnAfterLeave,
-    }))
-
     onUnmounted(() => {
-      //if there is time left on autohide or no autohide then keep toast alive
+      //if there is time left on autoHide or no autoHide then keep toast alive
       clearDismissTimer()
       if (!props.autoHide) {
         return
@@ -255,7 +240,8 @@ export default defineComponent({
           $innertoast
         )
       }
-      const $toast = h(
+      //toast
+      return h(
         'div',
         {
           'class': ['b-toast'],
@@ -280,8 +266,6 @@ export default defineComponent({
           ),
         ]
       )
-
-      return $toast
     }
   },
 })