fix: run all preflight:package steps before failing (#48)

* fix: run all preflight:package steps before failing

Previously, the first package failure would stop all remaining
preflight checks. Now all crates are attempted and the first error
is returned after all steps complete.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: collapse nested if to satisfy clippy::collapsible-if

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ci: trigger CI re-run

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: EffortlessSteven

xtask/src/main.rs

@@ -426,9 +426,10 @@ fn publish_preflight() -> Result<()> {
 
 fn run_publish_preflight(runner: &mut receipt::Runner) -> Result<()> {
     runner.step("preflight:metadata", None, check_crate_metadata)?;
+    let mut first_err: Option<anyhow::Error> = None;
     for name in PUBLISH_CRATES {
         let step_name = format!("preflight:package:{name}");
-        runner.step(&step_name, None, || {
+        if let Err(e) = runner.step(&step_name, None, || {
             let output = Command::new("cargo")
                 .args(["package", "--no-verify", "-p", name])
                 .output()
@@ -444,9 +445,15 @@ fn run_publish_preflight(runner: &mut receipt::Runner) -> Result<()> {
                 return Ok(());
             }
             bail!("cargo package -p {name} failed:\n{stderr}");
-        })?;
+        }) && first_err.is_none()
+        {
+            first_err = Some(e);
+        }
+    }
+    match first_err {
+        Some(e) => Err(e),
+        None => Ok(()),
     }
-    Ok(())
 }
 
 fn check_crate_metadata() -> Result<()> {