Removed pallet:getter from XCM pallets (paritytech#7916)

# Description

Part of paritytech#3326 

As per title, the `pallet:getter` usage has been removed from:
- `pallet-xcm`
- `xcm-simulator-fuzzer`

Getters have been implemented manually for all storage items where an
auto-generated one has been removed.

polkadot address: 12poSUQPtcF1HUPQGY3zZu2P8emuW9YnsPduA4XG3oCEfJVp

---------

Co-authored-by: Branislav Kontur <[email protected]>

Author: muraca

polkadot/xcm/pallet-xcm/src/lib.rs

@@ -46,6 +46,7 @@ use frame_support::{
 use frame_system::pallet_prelude::{BlockNumberFor, *};
 pub use pallet::*;
 use scale_info::TypeInfo;
+use sp_core::H256;
 use sp_runtime::{
 	traits::{
 		AccountIdConversion, BadOrigin, BlakeTwo256, BlockNumberProvider, Dispatchable, Hash,
@@ -192,7 +193,6 @@ pub mod pallet {
 		parameter_types,
 	};
 	use frame_system::Config as SysConfig;
-	use sp_core::H256;
 	use sp_runtime::traits::Dispatchable;
 	use xcm_executor::traits::{MatchesFungible, WeightBounds};
 
@@ -698,7 +698,6 @@ pub mod pallet {
 
 	/// The ongoing queries.
 	#[pallet::storage]
-	#[pallet::getter(fn query)]
 	pub(super) type Queries<T: Config> =
 		StorageMap<_, Blake2_128Concat, QueryId, QueryStatus<BlockNumberFor<T>>, OptionQuery>;
 
@@ -707,7 +706,6 @@ pub mod pallet {
 	/// Key is the blake2 256 hash of (origin, versioned `Assets`) pair. Value is the number of
 	/// times this pair has been trapped (usually just 1 if it exists at all).
 	#[pallet::storage]
-	#[pallet::getter(fn asset_trap)]
 	pub(super) type AssetTraps<T: Config> = StorageMap<_, Identity, H256, u32, ValueQuery>;
 
 	/// Default version to encode XCM when latest version of destination is unknown. If `None`,
@@ -1565,6 +1563,20 @@ impl<T: Config> QueryHandler for Pallet<T> {
 }
 
 impl<T: Config> Pallet<T> {
+	/// The ongoing queries.
+	pub fn query(query_id: &QueryId) -> Option<QueryStatus<BlockNumberFor<T>>> {
+		Queries::<T>::get(query_id)
+	}
+
+	/// The existing asset traps.
+	///
+	/// Key is the blake2 256 hash of (origin, versioned `Assets`) pair.
+	/// Value is the number of times this pair has been trapped
+	/// (usually just 1 if it exists at all).
+	pub fn asset_trap(trap_id: &H256) -> u32 {
+		AssetTraps::<T>::get(trap_id)
+	}
+
 	/// Find `TransferType`s for `assets` and fee identified through `fee_asset_item`, when
 	/// transferring to `dest`.
 	///

polkadot/xcm/xcm-executor/integration-tests/src/lib.rs

@@ -239,7 +239,7 @@ fn query_response_fires() {
 			}) if q == query_id,
 		)));
 		assert_eq!(
-			polkadot_test_runtime::Xcm::query(query_id),
+			polkadot_test_runtime::Xcm::query(&query_id),
 			Some(QueryStatus::Ready {
 				response: VersionedResponse::from(Response::ExecutionResult(None)),
 				at: 2u32.into()

polkadot/xcm/xcm-simulator/fuzzer/src/parachain.rs

@@ -169,11 +169,9 @@ pub mod mock_msg_queue {
 	impl<T: Config> Pallet<T> {}
 
 	#[pallet::storage]
-	#[pallet::getter(fn parachain_id)]
 	pub(super) type ParachainId<T: Config> = StorageValue<_, ParaId, ValueQuery>;
 
 	#[pallet::storage]
-	#[pallet::getter(fn received_dmp)]
 	/// A queue of received DMP messages
 	pub(super) type ReceivedDmp<T: Config> = StorageValue<_, Vec<Xcm<T::RuntimeCall>>, ValueQuery>;
 
@@ -208,6 +206,14 @@ pub mod mock_msg_queue {
 	}
 
 	impl<T: Config> Pallet<T> {
+		pub fn parachain_id() -> ParaId {
+			ParachainId::<T>::get()
+		}
+
+		pub fn received_dmp() -> Vec<Xcm<T::RuntimeCall>> {
+			ReceivedDmp::<T>::get()
+		}
+
 		pub fn set_para_id(para_id: ParaId) {
 			ParachainId::<T>::put(para_id);
 		}

prdoc/pr_7916.prdoc

@@ -0,0 +1,11 @@
+title: Removed pallet::getter from XCM pallets
+doc:
+  - audience: Runtime Dev
+    description: |
+        This pr removes all pallet::getter occurrences from XCM pallets, replacing them with explicit implementations.
+
+crates:
+  - name: pallet-xcm
+    bump: patch
+  - name: xcm-simulator-fuzzer
+    bump: patch