Skip to content

Commit 9c7e29b

Browse files
jvelillajocelyn
authored andcommitted
Added descriptions and comments
1 parent a0e9a41 commit 9c7e29b

File tree

4 files changed

+24
-5
lines changed

4 files changed

+24
-5
lines changed

library/server/ewsgi/connectors/standalone/src/httpd/configuration/httpd_configuration_i.e

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ feature -- Access: SSL
6060
-- the signed certificate.
6161

6262
ca_key: STRING
63-
-- private key to the sertificate.
63+
-- private key to the certificate.
6464

6565
ssl_protocol: NATURAL
6666
-- By default protocol is tls 1.2.
@@ -75,6 +75,7 @@ feature -- Element change
7575
else
7676
create {IMMUTABLE_STRING_8} http_server_name.make_from_separate (v)
7777
end
78+
--| Missing postcondition.
7879
end
7980

8081
unset_http_server_name
@@ -201,31 +202,43 @@ feature -- SSL Helpers
201202
set_ssl_protocol_to_ssl_2_or_3
202203
-- Set `ssl_protocol' with `Ssl_23'.
203204
deferred
205+
ensure
206+
ssl_protocol_set: ssl_protocol = {SSL_PROTOCOL}.Ssl_23
204207
end
205208

206209
set_ssl_protocol_to_ssl_3
207210
-- Set `ssl_protocol' with `Ssl_3'.
208211
deferred
212+
ensure
213+
ssl_protocol_set: ssl_protocol = {SSL_PROTOCOL}.Ssl_3
209214
end
210215

211216
set_ssl_protocol_to_tls_1_0
212217
-- Set `ssl_protocol' with `Tls_1_0'.
213218
deferred
219+
ensure
220+
ssl_protocol_set: ssl_protocol = {SSL_PROTOCOL}.Tls_1_0
214221
end
215222

216223
set_ssl_protocol_to_tls_1_1
217224
-- Set `ssl_protocol' with `Tls_1_1'.
218225
deferred
226+
ensure
227+
ssl_protocol_set: ssl_protocol = {SSL_PROTOCOL}.Tls_1_1
219228
end
220229

221230
set_ssl_protocol_to_tls_1_2
222231
-- Set `ssl_protocol' with `Tls_1_2'.
223232
deferred
233+
ensure
234+
ssl_protocol_set: ssl_protocol = {SSL_PROTOCOL}.Tls_1_2
224235
end
225236

226237
set_ssl_protocol_to_dtls_1_0
227238
-- Set `ssl_protocol' with `Dtls_1_0'.
228239
deferred
240+
ensure
241+
ssl_protocol_set: ssl_protocol = {SSL_PROTOCOL}.Dtls_1_0
229242
end
230243

231244
note

library/server/ewsgi/connectors/standalone/src/httpd/httpd_server_i.e

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
note
2-
description: "Summary description for {HTTPD_SERVER_I}."
2+
description: "HTTPD server interface"
33
date: "$Date$"
44
revision: "$Revision$"
55

@@ -14,7 +14,6 @@ inherit
1414
feature {NONE} -- Initialization
1515

1616
make (a_factory: like factory)
17-
-- `a_cfg': server configuration
1817
-- `a_factory': connection handler builder
1918
require
2019
fac_is_separated: {PLATFORM}.is_scoop_capable implies not attached {HTTPD_REQUEST_HANDLER_FACTORY} a_factory
@@ -67,6 +66,7 @@ feature -- Callbacks
6766
observer: detachable separate HTTPD_SERVER_OBSERVER
6867

6968
set_observer (obs: like observer)
69+
-- Set `observer' with `obs'
7070
do
7171
observer := obs
7272
end
@@ -320,8 +320,11 @@ feature -- Output
320320
output: detachable FILE
321321

322322
set_log_output (f: FILE)
323+
-- Set `output' with `f'.
323324
do
324325
output := f
326+
ensure
327+
output_set: output = f
325328
end
326329

327330
log (a_message: separate READABLE_STRING_8)

library/server/ewsgi/connectors/standalone/src/httpd/ssl/httpd_configuration.e

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,12 @@ create
1818
feature {NONE} -- Initialization
1919

2020
make
21+
-- Create a new instance and set ssl protocol to tls_1_2.
2122
do
2223
Precursor
23-
ssl_protocol := {SSL_PROTOCOL}.tls_1_2
24+
set_ssl_protocol_to_tls_1_2
25+
ensure then
26+
ssl_protocol_set: ssl_protocol = {SSL_PROTOCOL}.tls_1_2
2427
end
2528

2629
feature -- Access

library/server/ewsgi/connectors/standalone/src/implementation/wgi_httpd_request_handler_factory.e

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
note
2-
description: "Summary description for {WGI_HTTPD_REQUEST_HANDLER_FACTORY}."
2+
description: "Implementation of WGI request handler factory for WGI_STANDALOE_CONNECTOR."
33
date: "$Date$"
44
revision: "$Revision$"
55

0 commit comments

Comments
 (0)