Skip to content

Commit 5cbfb35

Browse files
author
Björn Ekryd
committed
Fixing some sonar warnings
1 parent 93d6365 commit 5cbfb35

File tree

6 files changed

+288
-265
lines changed

6 files changed

+288
-265
lines changed

sorter/src/test/java/sortpom/output/PatchedXMLWriterTest.java

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,20 @@ class PatchedXMLWriterTest {
1414
@Test
1515
void writeXmlWithDocType() throws Exception {
1616
var xml =
17-
"<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n"
18-
+ "<!DOCTYPE xml [\n"
19-
+ " <!ENTITY copy \"©\">\n"
20-
+ " <!ENTITY trade \"\">\n"
21-
+ " <!ENTITY deg \"°\">\n"
22-
+ " <!ENTITY gt \"&#62;\">\n"
23-
+ " <!ENTITY sup2 \"²\">\n"
24-
+ " <!ENTITY frac14 \"¼\">\n"
25-
+ " <!ENTITY quot \"&#34;\">\n"
26-
+ " <!ENTITY frac12 \"½\">\n"
27-
+ " <!ENTITY euro \"\">\n"
28-
+ " <!ENTITY Omega \"Ω\">\n"
29-
+ "]><root/>";
17+
"""
18+
<?xml version="1.0" encoding="UTF-8"?>
19+
<!DOCTYPE xml [
20+
<!ENTITY copy "©">
21+
<!ENTITY trade "™">
22+
<!ENTITY deg "°">
23+
<!ENTITY gt "&#62;">
24+
<!ENTITY sup2 "²">
25+
<!ENTITY frac14 "¼">
26+
<!ENTITY quot "&#34;">
27+
<!ENTITY frac12 "½">
28+
<!ENTITY euro "€">
29+
<!ENTITY Omega "Ω">
30+
]><root/>""";
3031

3132
var reader = new SAXReader();
3233
reader.setIncludeInternalDTDDeclarations(true);

sorter/src/test/java/sortpom/output/XmlOutputGeneratorTest.java

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,12 @@ void definedParentNamespaceShouldBeReused() {
7070
sortedXml,
7171
is(
7272
equalTo(
73-
"<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Gurka xmlns:namespace=\"this is a uri\">\n"
74-
+ "<child namespace:attr1=\"value\"></child>\n</Gurka>\n")));
73+
"""
74+
<?xml version="1.0" encoding="UTF-8"?>
75+
<Gurka xmlns:namespace="this is a uri">
76+
<child namespace:attr1="value"></child>
77+
</Gurka>
78+
""")));
7579
}
7680

7781
@Test
@@ -95,8 +99,12 @@ void redefinedParentNamespaceShouldBeWrittenAgain() {
9599
sortedXml,
96100
is(
97101
equalTo(
98-
"<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Gurka xmlns:namespace=\"this is a uri\">\n"
99-
+ "<child xmlns:namespace=\"another uri\" namespace:attr1=\"value\"></child>\n</Gurka>\n")));
102+
"""
103+
<?xml version="1.0" encoding="UTF-8"?>
104+
<Gurka xmlns:namespace="this is a uri">
105+
<child xmlns:namespace="another uri" namespace:attr1="value"></child>
106+
</Gurka>
107+
""")));
100108
}
101109

102110
@Test

0 commit comments

Comments
 (0)