Potential upcoming breakages with rolldown-vite

[KieranP]

Vite is going to replace their core system with rolldown in an upcoming version. They released a preview version last week, but there are issue with vite-plugin-ruby.

I filed an issue with Rolldown-vite team incase they want to investigate something on their end and thought I should mention it here as well.

vitejs/rolldown-vite#235

[sapphi-red]

I guess it's because rolldown does not support the deprecated name property.

vite_ruby/vite-plugin-ruby/src/index.ts

Lines 103 to 104 in d4bd2ef

	const outputFileName = (ext: string) => ({ name }: { name: string }) => {
	const shortName = basename(name).split('.')[0]

[zainudinsainal]

yes it seems the name property is causing the error. by adding the code below in vite.config.js file, i was able to run rails assets:precompile with rolldown-vite package.

export default defineConfig({
  build: {
    rollupOptions: {
      output: {
        assetFileNames: () => {
          return 'assets/[name]-[hash][extname]';
        },
      },
    },
  },

[gurgeous]

Thanks for the tip @zainudinsainal. I did not find this to be sufficient, at least with the latest version of rolldown. After some investigation I ended up adding a custom plugin to fix the issue. Thanks all, we love vite ruby!

//
// The purpose of this plugin is to fix the vite ruby config that doesn't work
// with rolldown. It's not enough to populate the `build:` property in
// defineConfig, because there is some confusion about rollup vs. rolldown
// options. The config below is deeply merged into the vite config, so the
// `input` property setup by vite ruby gets correctly passed through.
//
// https://github.com/ElMassimo/vite_ruby/issues/557#issuecomment-2989633811
//

const ViteRubyHack = () => {
  const output = { assetFileNames: "assets/[name]-[hash][extname]" };
  return {
    config: () => ({
      build: {
        rolldownOptions: { output },
        rollupOptions: { output },
      },
    }),
  };
};

and add it after vite ruby:

export default defineConfig({
  plugins: [
    ...
    VitePluginRuby(),
    ViteRubyHack(),
    ...

[BilalBudhani]

thanks for sharing the workaround @gurgeous, it works!

[zainudinsainal]

thanks for the update @gurgeous. Yes, the latest version of rolldown-vite has breaking changes as mentioned in this PR #571. This gem need to be updated with rolldownOptions to use with rolldown-vite.