Skip to content

Commit 4f11020

Browse files
authored
Make webdriver version optional (#299)
1 parent 17110df commit 4f11020

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

pylenium.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"page_load_wait_time": 0,
77
"options": [],
88
"capabilities": {},
9-
"version": "",
9+
"version": null,
1010
"experimental_options": null,
1111
"extension_paths": [],
1212
"webdriver_kwargs": {},

pylenium/config.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from pathlib import Path
2-
from typing import List, Dict
2+
from typing import List, Dict, Optional
33

44
from pydantic import BaseModel
55

@@ -14,11 +14,11 @@ class DriverConfig(BaseModel):
1414
page_load_wait_time: int = 0
1515
options: List[str] = []
1616
capabilities: Dict = {}
17-
experimental_options: List[Dict] = None
17+
experimental_options: Optional[List[Dict]] = None
1818
seleniumwire_options: Dict = {}
19-
extension_paths: List[str] = None
20-
webdriver_kwargs: Dict = None
21-
version: str = "latest"
19+
extension_paths: Optional[List[str]] = None
20+
webdriver_kwargs: Optional[Dict] = None
21+
version: Optional[str] = None
2222
local_path: str = ""
2323

2424

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Faker = "8.16.0"
1919
selenium = "4.1.0"
2020
python-dotenv = "^0.20.0"
2121
rich-click = "^1.5.1"
22-
webdriver-manager = "^3.8.4"
22+
webdriver-manager = "^3.8.6"
2323
selenium-wire = "^5.1.0"
2424
allure-pytest = "^2.11.1"
2525

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"pytest-reportportal>=5.1.0",
2424
"Faker>=8.16.0",
2525
"requests>=2.27.1",
26-
"webdriver-manager>=3.5.4",
26+
"webdriver-manager>=3.8.6",
2727
"pyfiglet>=0.8.post1",
2828
"axe-selenium-python>=2.1.6",
2929
"selenium-wire>=4.6.3",

tests/unit/test_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ def test_py_config_defaults(py_config):
55
assert py_config.driver.wait_time == 10
66
assert py_config.driver.page_load_wait_time == 0
77
assert py_config.driver.options == []
8-
assert py_config.driver.version == ""
8+
assert py_config.driver.version is None
99
assert py_config.driver.capabilities == {}
1010
assert py_config.driver.experimental_options is None
1111
assert py_config.driver.webdriver_kwargs == {}

0 commit comments

Comments
 (0)