Skip to content

Commit 74f6ffb

Browse files
fix the serialization names (#299)
1 parent 5180c1b commit 74f6ffb

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

bindings/netstandard/ElectionGuard/ElectionGuard.Encryption.Tests/TestEncrypt.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,16 @@ public void Test_Device_Serialization_Succeeds()
2121
Assert.True(deviceCreatedFromJson.ToJson().Contains("Brazil"));
2222

2323
}
24+
[Test]
25+
public void Test_Device_Serialization_From_JSON_Succeeds()
26+
{
27+
string deviceJson = "{ \"device_id\": 91755434160, \"session_id\": 12345, \"launch_code\": 45678, \"location\": \"polling-place\" }";
28+
var device = new EncryptionDevice(deviceJson);
29+
30+
var json = device.ToJson();
31+
32+
Assert.True(json.Contains("polling-place"));
33+
}
2434

2535
[Test]
2636
public void Test_Encrypt_Ballot_Simple_Succeeds()

src/electionguard/serialize.hpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -937,9 +937,9 @@ namespace electionguard
937937
{
938938

939939
json j = {
940-
{"deviceUuid", serializable.getDeviceUuid()},
941-
{"sessionUuid", serializable.getSessionUuid()},
942-
{"launchCode", serializable.getLaunchCode()},
940+
{"device_id", serializable.getDeviceUuid()},
941+
{"session_id", serializable.getSessionUuid()},
942+
{"launch_code", serializable.getLaunchCode()},
943943
{"location", serializable.getLocation()},
944944
};
945945

@@ -948,9 +948,9 @@ namespace electionguard
948948

949949
static unique_ptr<electionguard::EncryptionDevice> toObject(json j)
950950
{
951-
auto deviceUuid = j["deviceUuid"].get<uint64_t>();
952-
auto sessionUuid = j["sessionUuid"].get<uint64_t>();
953-
auto launchCode = j["launchCode"].get<uint64_t>();
951+
auto deviceUuid = j["device_id"].get<uint64_t>();
952+
auto sessionUuid = j["session_id"].get<uint64_t>();
953+
auto launchCode = j["launch_code"].get<uint64_t>();
954954
auto location = j["location"].get<string>();
955955

956956
return make_unique<electionguard::EncryptionDevice>(deviceUuid, sessionUuid,

0 commit comments

Comments
 (0)