Modify encrypt_ballot to pass on should_verify_proofs (#460)

* Modify encrypt_ballot to pass on should_verify_proofs

* Update test_encrypt.py

Fix linting in test

* Run black lint

Co-authored-by: Keith Fung <[email protected]>

Author: shepherdjay

src/electionguard/encrypt.py

@@ -309,6 +309,7 @@ def encrypt_contest(
                     elgamal_public_key,
                     crypto_extended_base_hash,
                     contest_nonce,
+                    should_verify_proofs=should_verify_proofs,
                 )
                 break
 
@@ -321,6 +322,7 @@ def encrypt_contest(
                 elgamal_public_key,
                 crypto_extended_base_hash,
                 contest_nonce,
+                should_verify_proofs=should_verify_proofs,
             )
 
         if encrypted_selection is None:
@@ -352,7 +354,7 @@ def encrypt_contest(
             crypto_extended_base_hash=crypto_extended_base_hash,
             nonce_seed=contest_nonce,
             is_placeholder=True,
-            should_verify_proofs=True,
+            should_verify_proofs=should_verify_proofs,
         )
         if encrypted_selection is None:
             return None  # log will have happened earlier
@@ -451,7 +453,11 @@ def encrypt_ballot(
     log_info(f": encryption_seed : {encryption_seed.to_hex()}")
 
     encrypted_contests = encrypt_ballot_contests(
-        ballot, internal_manifest, context, nonce_seed
+        ballot,
+        internal_manifest,
+        context,
+        nonce_seed,
+        should_verify_proofs=should_verify_proofs,
     )
     if encrypted_contests is None:
         return None
@@ -487,6 +493,7 @@ def encrypt_ballot_contests(
     description: InternalManifest,
     context: CiphertextElectionContext,
     nonce_seed: ElementModQ,
+    should_verify_proofs: bool = True,
 ) -> Optional[List[CiphertextBallotContest]]:
     """Encrypt contests from a plaintext ballot with a specific style"""
     encrypted_contests: List[CiphertextBallotContest] = []
@@ -509,6 +516,7 @@ def encrypt_ballot_contests(
             context.elgamal_public_key,
             context.crypto_extended_base_hash,
             nonce_seed,
+            should_verify_proofs=should_verify_proofs,
         )
 
         if encrypted_contest is None:

tests/property/test_encrypt.py

@@ -1,4 +1,5 @@
 from unittest import skip
+from unittest.mock import patch
 from copy import deepcopy
 from datetime import timedelta
 from random import Random
@@ -750,3 +751,35 @@ def test_encrypt_ballot_with_derivative_nonces_regenerates_valid_proofs(
                         context.crypto_extended_base_hash,
                     )
                 )
+
+    def test_encrypt_ballot_with_verify_proofs_false_passed_on(self):
+        """
+        This test is for https://github.com/microsoft/electionguard-python/issues/459
+        """
+        with patch("electionguard.encrypt.encrypt_contest") as patched_contest, patch(
+            "electionguard.encrypt.encrypt_selection"
+        ) as patched_selection:
+            # Arrange
+            keypair = elgamal_keypair_from_secret(int_to_q(2))
+            manifest = election_factory.get_fake_manifest()
+            internal_manifest, context = election_factory.get_fake_ciphertext_election(
+                manifest, keypair.public_key
+            )
+            subject = election_factory.get_fake_ballot(internal_manifest)
+            self.assertTrue(
+                subject.is_valid(internal_manifest.ballot_styles[0].object_id)
+            )
+
+            patched_contest.side_effect = encrypt_contest
+            patched_selection.side_effect = encrypt_selection
+
+            # Act
+            encrypt_ballot(
+                subject, internal_manifest, context, SEED, should_verify_proofs=False
+            )
+
+            # Assert
+            for call in patched_contest.call_args_list:
+                self.assertFalse(call.kwargs.get("should_verify_proofs"))
+            for call in patched_selection.call_args_list:
+                self.assertFalse(call.kwargs.get("should_verify_proofs"))