Remove Optional on Ciphertext Ballot Code (#357)

keithrfung · web-flow · commit fe668a410efb · 2021-04-21T14:51:11.000-04:00
The ballot code can not be optional for the CiphertextBallot
diff --git a/src/electionguard/ballot.py b/src/electionguard/ballot.py
@@ -672,7 +672,7 @@ class CiphertextBallot(ElectionObjectBase, CryptoHashCheckable):
     contests: List[CiphertextBallotContest]
     """List of contests for this ballot"""
 
-    code: Optional[ElementModQ]
+    code: ElementModQ
     """Unique ballot code for this ballot"""
 
     timestamp: int
diff --git a/src/electionguard/ballot_compact.py b/src/electionguard/ballot_compact.py
@@ -67,7 +67,7 @@ def compress_submitted_ballot(
         ballot.timestamp,
         ballot_nonce,
         ballot.code_seed,
-        get_optional(ballot.code),
+        ballot.code,
         ballot.state,
     )
 

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ def compress_submitted_ballot(`
`67`	`67`	`ballot.timestamp,`
`68`	`68`	`ballot_nonce,`
`69`	`69`	`ballot.code_seed,`
`70`		`- get_optional(ballot.code),`
	`70`	`+ ballot.code,`
`71`	`71`	`ballot.state,`
`72`	`72`	`)`
`73`	`73`