improve

Author: jayvdb

Cargo.lock

@@ -28,6 +28,7 @@ path = "common/mod.rs"
 
 [dependencies]
 butane = { workspace = true }
+butane_codegen.workspace = true
 butane_core = { workspace = true }
 butane_test_helper = { workspace = true, default-features = false, features = ["pg", "sqlite", "turso"] }
 butane_test_macros = { workspace = true }
@@ -52,6 +53,7 @@ sqlparser = { workspace = true }
 tokio = { workspace = true, features = ["macros"] }
 tokio-postgres = { features = ["with-geo-types-0_7"], workspace = true }
 tokio-test = { workspace = true }
+trybuild = "1.0"
 uuid_for_test = { package = "uuid", version = "1.2", features = ["v4"] }
 
 [[test]]

butane/tests/Cargo.toml

@@ -3,6 +3,6 @@
 #[test]
 fn compile_tests() {
     let t = trybuild::TestCases::new();
-    t.pass("tests/trybuild/pass/*.rs");
-    t.compile_fail("tests/trybuild/fail/*.rs");
+    t.pass("trybuild/pass/*.rs");
+    t.compile_fail("trybuild/fail/*.rs");
 }

butane/tests/trybuild.rs

@@ -0,0 +1,13 @@
+use butane::filter;
+use butane_codegen::model;
+
+#[model]
+struct Post {
+    id: i64,
+    title: String,
+}
+
+fn main() {
+    // This should fail - like expects a string literal, not a binary expression
+    let _f = filter!(Post, title.like(1 + 2));
+}

butane/tests/trybuild/fail/complex_enum_without_json.rs

@@ -0,0 +1,16 @@
+error: Unexpected binary expression as parameter to like
+  --> trybuild/fail/filter_like_invalid_param.rs:12:14
+   |
+12 |     let _f = filter!(Post, title.like(1 + 2));
+   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = note: this error originates in the macro `filter` (in Nightly builds, run with -Z macro-backtrace for more info)
+
+error[E0046]: not all trait items implemented, missing: `save_many_to_many_async`
+ --> trybuild/fail/filter_like_invalid_param.rs:4:1
+  |
+4 | #[model]
+  | ^^^^^^^^ missing `save_many_to_many_async` in implementation
+  |
+  = note: this error originates in the attribute macro `model` (in Nightly builds, run with -Z macro-backtrace for more info)
+  = help: implement the missing item: `async fn save_many_to_many_async(&mut self, _: &impl ConnectionMethodsAsync) -> Result<(), butane::Error> { todo!() }`

butane/tests/trybuild/fail/complex_enum_without_json.stderr

@@ -0,0 +1,13 @@
+use butane::filter;
+use butane_codegen::model;
+
+#[model]
+struct Post {
+    id: i64,
+    title: String,
+}
+
+fn main() {
+    // This should fail - unsupported binary operator
+    let _f = filter!(Post, title ^ "test");
+}

butane/tests/trybuild/fail/filter_like_invalid_param.rs

@@ -0,0 +1,16 @@
+error: Unsupported binary operator
+  --> trybuild/fail/filter_unsupported_operator.rs:12:14
+   |
+12 |     let _f = filter!(Post, title ^ "test");
+   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+   = note: this error originates in the macro `filter` (in Nightly builds, run with -Z macro-backtrace for more info)
+
+error[E0046]: not all trait items implemented, missing: `save_many_to_many_async`
+ --> trybuild/fail/filter_unsupported_operator.rs:4:1
+  |
+4 | #[model]
+  | ^^^^^^^^ missing `save_many_to_many_async` in implementation
+  |
+  = note: this error originates in the attribute macro `model` (in Nightly builds, run with -Z macro-backtrace for more info)
+  = help: implement the missing item: `async fn save_many_to_many_async(&mut self, _: &impl ConnectionMethodsAsync) -> Result<(), butane::Error> { todo!() }`