.NET code no longer compiles after PR merge.

[agracio]

#893 was merged into main however it appears something went wrong and the code in main no longer compiles.

develop branch also no longer compiles with different exception than main.

PR origin https://github.com/softworkz/ElectronNET/tree/electronnet_core works perfectly fine.

[FlorianRappl]

Yes, the Process class has been updated and brought back. It was one of the classes missing in the referenced origin.

[agracio]

@FlorianRappl not sure why you closed it as completed, current code in main does not compile. Is there a pending PR to fix it?

I performed fresh checkouts on both main and develop branches just in case there were some merge issues.

[FlorianRappl]

1. main is the release branch. There is no release for the 0.1.0 yet. Right now its a preview.
2. develop works - if in doubt look at the action

In general build failures are not for the issue tracker (esp. labelled as "bugs", which are issues with the lib - a build failure does not trigger a build). So a bit odd to open a bug for it - but at least it acted as a reminder.

[agracio]

1. This is my mistake as I though that final changes have been merged from develop to main.
2. It appears there is a fresh commit to develop - it was failing when I opened this issue.

Yes a 'bug' might have been a mistake but as for issue tracker it does make sense to open an issue if there is a problem with the code. Thank you for taking care of the compile error.

[FlorianRappl]

It appears there is a fresh commit to develop - it was failing when I opened this issue.

Yes I know. But when I closed it the build was running again. (2) was a response to your last comment, not the OP.

[agracio]

What is the current status of develop branch, I mentioned in another issue that the code can benefit from refactoring shaving 1.5k-2k lines of code, but do not want to make changes while the branch is still unstable should I wait for a merge to main first?

[FlorianRappl]

You can always make a PR.

Target for any PRs should be develop.

[agracio]

Unfortunately develop branch is still broken. Both test projects ElectronNET.ConsoleApp and ElectronNET.WenApp have incorrect nuget dependencies.
This results in solution build errors and inability to launch local test app.

I was able to resolve issue locally by updating ElectronNET.Core and ElectronNET.Core.AspNet nuget package references to 0.0.18.

PR #904

[FlorianRappl]

Unfortunately develop branch is still broken. Both test projects ElectronNET.ConsoleApp and ElectronNET.WenApp have incorrect nuget dependencies.

Nope - they are set to what main will be. For these projects you should always either change locally or use main.