FileExtractor#initialize(int): sanity-check the stream provider handler for other routines - apply the close() routine on failure

Author: pavly-gerges

snaploader/src/main/java/electrostatic4j/snaploader/filesystem/FileExtractor.java

@@ -86,7 +86,12 @@ protected FileExtractor() {
     }
 
     @Override
-    public void initialize(int size) {
+    public void initialize(int size) throws Exception {
+        // 1) sanity-check for double initializing
+        // 2) sanity-check for pre-initialization using other routines
+        if (this.fileOutputStream != null) {
+            return;
+        }
         try {
             if (size > 0) {
                 this.fileOutputStream = new BufferedOutputStream(
@@ -98,7 +103,8 @@ public void initialize(int size) {
             this.fileOutputStream = new FileOutputStream(destination);
             SnapLoaderLogger.log(Level.INFO, getClass().getName(), "initialize(int)",
                     "File extractor initialized with hash key #" + getHashKey());
-        } catch (FileNotFoundException e) {
+        } catch (Exception e) {
+            close();
             throw new FilesystemResourceInitializationException(
                     "Failed to initialize the file extractor handler #" + getHashKey(), e);
         }