Make sure to trim values before comparison #19

Author: Mathis Koblin

Classes/Metadata/MetadataUpdateObject.php

@@ -74,8 +74,13 @@ private function clearMetadataRecord(array $metadata): array
     {
         // unset all fields that are not in $this->fieldsToCheck
         foreach ($metadata as $key => $value) {
+            if (is_string($value)) {
+                $value = trim($value);
+            }
             if (!in_array($key, $this->fieldsToCheck) || empty($value)) {
                 unset($metadata[$key]);
+            } else {
+                $metadata[$key] = $value;
             }
         }
         return $metadata;

Tests/Functional/Command/DataSet/sys_file_duplicates_with_metadata.csv

@@ -20,7 +20,7 @@
 ,"507cf53279411321324cd2f424e0688e","sys_file_metadata","8","","","sys_file","8"
 "sys_file_metadata",,,
 ,"uid","file","description"
-,1,1,"ABC"
+,1,1,"ABC "
 ,2,2,"ABC"
 ,3,3,"ABCD"
 ,4,4,"ABC"

Tests/Functional/Command/DataSet/sys_file_duplicates_with_metadata_oldest_RESULT.csv

@@ -14,7 +14,7 @@
 ,"507cf53279411321324cd2f424e0687e","sys_file_metadata","7","","","sys_file","7"
 "sys_file_metadata",,,
 ,"uid","file","description","sys_language_uid"
-,1,1,"ABC",0
+,1,1,"ABC ",0
 ,3,3,"ABCD",0
 ,4,4,"ABC",0
 ,5,5,"ABC",0