Merge #1072: Remove redundant log message in IsValidPeginWitness

stevenroose · stevenroose · commit fec996403aa8 · 2021-11-25T17:01:37.000Z
b2dd758 Remove redundant log message in IsValidPeginWitness (Glenn Willen) Pull request description: The value it logs, very frequently, is essentially static, coming straight from the chainparams, and should never change during runtime anyway. (With a small exception that doesn't really matter and is probably not the reason for the log.) Top commit has no ACKs. Tree-SHA512: 5cda28c850a808a8a0d43bd3369a0a18817e774d35e4c7605e3e4ffe7746f192a603c031413286a9b5c8d557f9b1807ba5ac236d8ecef9f9b64517446b788f80
diff --git a/src/pegins.cpp b/src/pegins.cpp
@@ -373,7 +373,6 @@ bool IsValidPeginWitness(const CScriptWitness& pegin_witness, const std::vector<
         if (tx_index == 0) {
             required_depth = std::max(required_depth, (unsigned int)COINBASE_MATURITY);
         }
-        LogPrintf("Required depth: %d\n", required_depth);
         if (!IsConfirmedBitcoinBlock(block_hash, required_depth, num_txs)) {
             err_msg = "Needs more confirmations.";
             if (depth_failed) {

Original file line number	Diff line number	Diff line change
`@@ -373,7 +373,6 @@ bool IsValidPeginWitness(const CScriptWitness& pegin_witness, const std::vector<`
`373`	`373`	`if (tx_index == 0) {`
`374`	`374`	`required_depth = std::max(required_depth, (unsigned int)COINBASE_MATURITY);`
`375`	`375`	`}`
`376`		`- LogPrintf("Required depth: %d\n", required_depth);`
`377`	`376`	`if (!IsConfirmedBitcoinBlock(block_hash, required_depth, num_txs)) {`
`378`	`377`	`err_msg = "Needs more confirmations.";`
`379`	`378`	`if (depth_failed) {`