python: tests: fix linter issues

Author: jgriffiths

src/test/test_aes.py

@@ -93,7 +93,7 @@ def test_aes_cbc(self):
                 self.assertEqual(h(out_buf), h(o))
 
     def test_aes_cbc_with_ecdh_key(self):
-        ENCRYPT, DECRYPT, PUBKEY_LEN, _ = 1, 2, 33, True
+        ENCRYPT, DECRYPT, _ = 1, 2, True
         a_priv = make_cbuffer('1c6a837d1ac663fdc7f1002327ca38452766eaf4fe3b80ce620bf7cd3f584cf6')[0]
         a_pub = make_cbuffer('03e581be89d1ef8ce11d60746d08e4f8aedf934d1d861dd436042ee2e3b16db918')[0]
         b_priv = make_cbuffer('0b6b3dc90d203d854100110788ac87d43aa00620c9cdb361b281b09022ef4b53')[0]

src/test/test_anti_exfil.py

@@ -16,7 +16,7 @@ def test_anti_exfil(self):
 
         flags = FLAG_ECDSA
 
-        ret = wally_ec_public_key_from_private_key(priv_key, 32, pub_key, 33);
+        ret = wally_ec_public_key_from_private_key(priv_key, 32, pub_key, 33)
         self.assertEqual(WALLY_OK, ret)
 
         ret = wally_ae_host_commit_from_bytes(entropy, 32, flags, host_commitment, 32)

src/test/test_elements.py

@@ -202,7 +202,7 @@ def test_blinding(self):
         SCALAR_OFFSET_LEN = 32
         offset, offset_len = make_cbuffer('00' * SCALAR_OFFSET_LEN)
         ret = wally_asset_scalar_offset(value, UNBLINDED_ABF, UNBLINDED_ABF_LEN,
-                                        UNBLINDED_VBF, UNBLINDED_VBF_LEN, offset, offset_len);
+                                        UNBLINDED_VBF, UNBLINDED_VBF_LEN, offset, offset_len)
         self.assertEqual(ret, WALLY_OK)
         self.assertEqual(h(offset),
                          utf8('4e5f3ca8aa2048eeacc8c300e3d63ca92048f407264352bee2fb15bd44349c45'))

src/test/test_map.py

@@ -162,7 +162,7 @@ def test_map(self):
         self.assertEqual(wally_map_find(clone, new_key, new_key_len), (WALLY_OK, 0))
 
         # Re-create clone to test combining
-        self.assertEqual(wally_map_free(clone), WALLY_OK);
+        self.assertEqual(wally_map_free(clone), WALLY_OK)
         self.assertEqual(wally_map_init_alloc(0, None, clone), WALLY_OK)
         self.assertEqual(wally_map_add(clone, new_key, new_key_len, v, vl), WALLY_OK)
 
@@ -246,7 +246,7 @@ def test_keypath_map(self):
         self.assertEqual(wally_map_add(m, bip32, bip32_len, kp_path, len(kp_path)), WALLY_OK)
 
         # Fingerprint/Path
-        out, out_len = (c_ubyte * (FP_LEN + 5 * 4))(), 24
+        out = (c_ubyte * (FP_LEN + 5 * 4))()
         cases = [
             (None,  0, out,  FP_LEN),   # NULL key
             (m,     1, out,  FP_LEN),   # Bad index
@@ -255,7 +255,6 @@ def test_keypath_map(self):
         ]
         for args in cases:
             self.assertEqual(wally_map_keypath_get_item_fingerprint(*args), WALLY_EINVAL)
-            plen = out_len - 4 if args[3] == FP_LEN else out_len - 5
             if args[0] is None or args[1] != 0:
                 ret = wally_map_keypath_get_item_path_len(args[0], args[1])
                 self.assertEqual(ret, (WALLY_EINVAL, 0))

src/test/test_sign.py

@@ -188,7 +188,7 @@ def test_invalid_inputs(self):
                  (priv_key, len(priv_key),   out_buf, 10)]           # Wrong out len
 
         for pk, pk_len, o, o_len in cases:
-            ret = wally_ec_public_key_from_private_key(pk, pk_len, o, o_len);
+            ret = wally_ec_public_key_from_private_key(pk, pk_len, o, o_len)
             self.assertEqual(ret, WALLY_EINVAL)
 
 

src/test/test_transaction.py

@@ -484,7 +484,6 @@ def test_get_taproot_signature_hash(self):
             annex = None
             annex_len = 0
 
-            fn = wally_tx_get_btc_taproot_signature_hash
             args = [tx, index, scripts, values, num_values, tapleaf_script, tapleaf_script_len,
                     key_version, codesep_pos, annex, annex_len, sighash, flags, bytes_out, out_len]
 

src/test/util.py

@@ -3,7 +3,6 @@
 from os.path import isfile, abspath
 from os import urandom
 import platform
-import sys
 
 # Allow to run from any sub dir
 SO_EXT = 'dylib' if platform.system() == 'Darwin' else 'dll' if platform.system() == 'Windows' else 'so'