address_to_scriptpubkey: correctly handle WALLY_NETWORK_BITCOIN_REGTEST

Account for regtest using the same (non-segwit) address prefix as testnet.

Author: jgriffiths

src/address.c

@@ -139,6 +139,8 @@ int wally_address_to_scriptpubkey(const char *addr, uint32_t network, unsigned c
     version = decoded[0];
     if (network_from_addr_version(version, &addr_network) != WALLY_OK)
         return WALLY_EINVAL;
+    if (network == WALLY_NETWORK_BITCOIN_REGTEST)
+        network = WALLY_NETWORK_BITCOIN_TESTNET; /* regtest uses testnet prefix */
     if (network != addr_network)
         return WALLY_EINVAL;
 

src/test/test_address.py

@@ -17,6 +17,7 @@
 
 NETWORK_BITCOIN_MAINNET = 0x01
 NETWORK_BITCOIN_TESTNET = 0x02
+NETWORK_BITCOIN_REGTEST = 0xff
 NETWORK_LIQUID_MAINNET  = 0x03
 NETWORK_LIQUID_REGTEST  = 0x04
 NETWORK_LIQUID_TESTNET  = 0x05
@@ -96,6 +97,7 @@ def get_test_key(self, vec, path):
     def test_address_vectors(self):
         self.do_test_vector(vec, 'm/0H/1', NETWORK_BITCOIN_MAINNET)
         self.do_test_vector(vec, 'm/1H/1', NETWORK_BITCOIN_TESTNET) # Testnet
+        self.do_test_vector(vec, 'm/1H/1', NETWORK_BITCOIN_REGTEST) # Testnet
 
     def do_test_vector(self, vec, path, network):
         key = self.get_test_key(vec, path)