Add TODOs [skip ci]

Author: Claudio Raimondi

Dockerfile

@@ -77,7 +77,8 @@ RUN apt-get update -qq && \
         jq \
         libtool \
         gettext \
-        protobuf-compiler
+        protobuf-compiler \
+        qemu-user-static
 
 ARG ZLIB_URL=https://github.com/madler/zlib/releases/download
 ARG ZLIB_VERSION=1.2.13
@@ -137,38 +138,22 @@ FROM base-builder AS base-builder-linux-amd64
 
 ARG target_host=x86_64-linux-gnu
 ARG target_host_rust=x86_64-unknown-linux-gnu
-ARG target_host_libc=amd64
-ARG target_host_gcc=x86-64-linux-gnu
 
 FROM base-builder AS base-builder-linux-arm64
 
 ARG target_host=aarch64-linux-gnu
 ARG target_host_rust=aarch64-unknown-linux-gnu
-ARG target_host_libc=arm64
-ARG target_host_gcc=aarch64-linux-gnu
 
 FROM base-builder AS base-builder-linux-arm
 
 ARG target_host=arm-linux-gnueabihf
 ARG target_host_rust=armv7-unknown-linux-gnueabihf
-ARG target_host_libc=armhf
-ARG target_host_gcc=arm-linux-gnueabihf
 
 FROM base-builder-${TARGETOS}-${TARGETARCH} AS builder
 
 ENV RUST_PROFILE=release
 ENV LIGHTNINGD_VERSION=master
 
-WORKDIR /opt
-
-RUN ./install-poetry.py
-RUN ./install-rust.sh -y --target ${target_host_rust} --profile minimal
-
-ARG POETRY_VIRTUALENVS_CREATE=false
-ENV PATH="/root/.cargo/bin:/root/.local/bin:${PATH}"
-
-RUN rustup toolchain install stable --component rustfmt --allow-downgrade
-
 ARG AR=${target_host}-ar
 ARG AS=${target_host}-as
 ARG CC=${target_host}-gcc
@@ -179,12 +164,12 @@ ARG QEMU_LD_PREFIX=/usr/${target_host}
 ARG TARGET=${target_host_rust}
 ARG PKG_CONFIG_PATH=${QEMU_LD_PREFIX}/lib/pkgconfig
 
-RUN apt-get install -qq -y --no-install-recommends \
-        libc6-${target_host_libc}-cross \
-        gcc-${target_host_gcc} \
-        g++-${target_host_gcc}
+WORKDIR /opt
+
+RUN ./install-poetry.py
+RUN ./install-rust.sh -y --target ${target_host_rust} --profile minimal --component rustfmt
 
-#TODO: speedup, anything below this is super slow.
+ENV PATH="/root/.cargo/bin:/root/.local/bin:${PATH}"
 
 WORKDIR /opt/zlib
 
@@ -217,6 +202,8 @@ RUN mkdir -p .cargo && tee .cargo/config.toml <<-EOF
   linker = "${target_host}-gcc"
 EOF
 
+ARG POETRY_VIRTUALENVS_CREATE=false
+
 RUN poetry lock && \
     poetry install --no-root --no-interaction --no-ansi
 
@@ -239,11 +226,7 @@ RUN apt-get update -qq && \
     apt-get clean && \
     rm -rf /var/lib/apt/lists/*
 
-ENV LIGHTNINGD_DATA=/root/.lightning
-ENV LIGHTNINGD_RPC_PORT=9835
-ENV LIGHTNINGD_PORT=9735
-ENV LIGHTNINGD_NETWORK=bitcoin
-
+#TODO: only copy necessary bitcoin/litecoin binaries.
 COPY --from=downloader    /opt/bitcoin/bin/             /usr/bin/
 COPY --from=downloader    /opt/litecoin/bin/            /usr/bin/
 COPY --from=builder       /tmp/lightning_install/       /usr/local/
@@ -253,6 +236,11 @@ COPY tools/docker-entrypoint.sh    /entrypoint.sh
 
 #TODO: user creation. user permissions on volume.
 
+ENV LIGHTNINGD_DATA=/root/.lightning
+ENV LIGHTNINGD_RPC_PORT=9835
+ENV LIGHTNINGD_PORT=9735
+ENV LIGHTNINGD_NETWORK=bitcoin
+
 EXPOSE 9735 9835
 VOLUME ["/root/.lightning"]
 ENTRYPOINT ["/entrypoint.sh"]