lightningd: fix overzealous memleak report.

rustyrussell · rustyrussell · commit 04b21c34d396 · 2025-03-24T13:59:58.000+10:30
Found by CI, not a real leak.

Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
diff --git a/lightningd/peer_control.c b/lightningd/peer_control.c
@@ -2332,7 +2332,7 @@ static void json_add_peer(struct lightningd *ld,
 		/* If peer reports our IP remote_addr, add that here */
 		if (p->remote_addr)
 			json_add_string(response, "remote_addr",
-					fmt_wireaddr(response, p->remote_addr));
+					fmt_wireaddr(tmpctx, p->remote_addr));
 	}
 
 	/* Note: If !PEER_CONNECTED, peer may use different features on reconnect */

Original file line number	Diff line number	Diff line change
`@@ -2332,7 +2332,7 @@ static void json_add_peer(struct lightningd *ld,`
`2332`	`2332`	`/* If peer reports our IP remote_addr, add that here */`
`2333`	`2333`	`if (p->remote_addr)`
`2334`	`2334`	`json_add_string(response, "remote_addr",`
`2335`		`- fmt_wireaddr(response, p->remote_addr));`
	`2335`	`+ fmt_wireaddr(tmpctx, p->remote_addr));`
`2336`	`2336`	`}`
`2337`	`2337`
`2338`	`2338`	`/* Note: If !PEER_CONNECTED, peer may use different features on reconnect */`