Skip to content

Commit 0c8304b

Browse files
Lagrang3Lagrang3
committed
askrene: add algorithm for single path routing
Changelog-Added: askrene: an optimal single-path solver has been added, it can be called using the developer option --dev_algorithm=single-path or by adding the layer "auto.no_mpp_support" Signed-off-by: Lagrang3 <[email protected]>
1 parent f9d8bd2 commit 0c8304b

File tree

3 files changed

+77
-50
lines changed

3 files changed

+77
-50
lines changed

‎plugins/askrene/askrene.c‎

Lines changed: 26 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,11 @@ const char *fmt_flow_full(const tal_t *ctx,
332332
}
333333

334334
enum algorithm {
335+
/* Min. Cost Flow by successive shortests paths. */
335336
ALGO_DEFAULT,
337+
/* Algorithm that finds the optimal routing solution constrained to a
338+
* single path. */
339+
ALGO_SINGLE_PATH,
336340
};
337341

338342
static struct command_result *
@@ -343,6 +347,8 @@ param_algorithm(struct command *cmd, const char *name, const char *buffer,
343347
*algo = tal(cmd, enum algorithm);
344348
if (streq(algo_str, "default"))
345349
**algo = ALGO_DEFAULT;
350+
else if (streq(algo_str, "single-path"))
351+
**algo = ALGO_SINGLE_PATH;
346352
else
347353
return command_fail_badparam(cmd, name, buffer, tok,
348354
"unknown algorithm");
@@ -581,15 +587,29 @@ static struct command_result *do_getroutes(struct command *cmd,
581587
goto fail;
582588
}
583589

590+
/* auto.no_mpp_support layer overrides any choice of algorithm. */
591+
if (have_layer(info->layers, "auto.no_mpp_support") &&
592+
*info->dev_algo != ALGO_SINGLE_PATH) {
593+
*info->dev_algo = ALGO_SINGLE_PATH;
594+
rq_log(tmpctx, rq, LOG_DBG,
595+
"Layer no_mpp_support is active we switch to a "
596+
"single path algorithm.");
597+
}
598+
584599
/* Compute the routes. At this point we might select between multiple
585600
* algorithms. Right now there is only one algorithm available. */
586601
struct timemono time_start = time_mono();
587-
assert(*info->dev_algo == ALGO_DEFAULT);
588-
err = default_routes(rq, rq, srcnode, dstnode, *info->amount,
589-
/* only one path? = */
590-
have_layer(info->layers, "auto.no_mpp_support"),
591-
*info->maxfee, *info->finalcltv, *info->maxdelay,
592-
&flows, &probability);
602+
if (*info->dev_algo == ALGO_SINGLE_PATH){
603+
err = single_path_routes(
604+
rq, rq, srcnode, dstnode, *info->amount,
605+
*info->maxfee, *info->finalcltv, *info->maxdelay, &flows,
606+
&probability);
607+
} else {
608+
assert(*info->dev_algo == ALGO_DEFAULT);
609+
err = default_routes(rq, rq, srcnode, dstnode, *info->amount,
610+
*info->maxfee, *info->finalcltv,
611+
*info->maxdelay, &flows, &probability);
612+
}
593613
struct timerel time_delta = timemono_between(time_mono(), time_start);
594614

595615
/* log the time of computation */

‎plugins/askrene/mcf.c‎

Lines changed: 40 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -974,8 +974,7 @@ struct flow **minflow(const tal_t *ctx,
974974
const struct gossmap_node *target,
975975
struct amount_msat amount,
976976
u32 mu,
977-
double delay_feefactor,
978-
bool single_part)
977+
double delay_feefactor)
979978
{
980979
struct flow **flow_paths;
981980
/* We allocate everything off this, and free it at the end,
@@ -1068,31 +1067,6 @@ struct flow **minflow(const tal_t *ctx,
10681067
goto fail;
10691068
}
10701069
tal_free(working_ctx);
1071-
1072-
/* This is dumb, but if you don't support MPP you don't deserve any
1073-
* better. Pile it into the largest part if not already. */
1074-
if (single_part) {
1075-
struct flow *best = flow_paths[0];
1076-
for (size_t i = 1; i < tal_count(flow_paths); i++) {
1077-
if (amount_msat_greater(flow_paths[i]->delivers, best->delivers))
1078-
best = flow_paths[i];
1079-
}
1080-
for (size_t i = 0; i < tal_count(flow_paths); i++) {
1081-
if (flow_paths[i] == best)
1082-
continue;
1083-
if (!amount_msat_accumulate(&best->delivers,
1084-
flow_paths[i]->delivers)) {
1085-
rq_log(tmpctx, rq, LOG_BROKEN,
1086-
"%s: failed to extract accumulate flow paths %s+%s",
1087-
__func__,
1088-
fmt_amount_msat(tmpctx, best->delivers),
1089-
fmt_amount_msat(tmpctx, flow_paths[i]->delivers));
1090-
goto fail;
1091-
}
1092-
}
1093-
flow_paths[0] = best;
1094-
tal_resize(&flow_paths, 1);
1095-
}
10961070
return flow_paths;
10971071

10981072
fail:
@@ -1286,21 +1260,23 @@ struct flow **single_path_flow(const tal_t *ctx, const struct route_query *rq,
12861260
return NULL;
12871261
}
12881262

1289-
const char *default_routes(const tal_t *ctx, struct route_query *rq,
1290-
const struct gossmap_node *srcnode,
1291-
const struct gossmap_node *dstnode,
1292-
struct amount_msat amount, bool single_path,
1293-
struct amount_msat maxfee, u32 finalcltv,
1294-
u32 maxdelay, struct flow ***flows,
1295-
double *probability)
1263+
static const char *
1264+
linear_routes(const tal_t *ctx, struct route_query *rq,
1265+
const struct gossmap_node *srcnode,
1266+
const struct gossmap_node *dstnode, struct amount_msat amount,
1267+
struct amount_msat maxfee, u32 finalcltv, u32 maxdelay,
1268+
struct flow ***flows, double *probability,
1269+
struct flow **(*solver)(const tal_t *, const struct route_query *,
1270+
const struct gossmap_node *,
1271+
const struct gossmap_node *,
1272+
struct amount_msat, u32, double))
12961273
{
12971274
const char *ret;
12981275
double delay_feefactor = 1.0 / 1000000;
12991276

13001277
/* First up, don't care about fees (well, just enough to tiebreak!) */
13011278
u32 mu = 1;
1302-
*flows = minflow(ctx, rq, srcnode, dstnode, amount, mu, delay_feefactor,
1303-
single_path);
1279+
*flows = solver(ctx, rq, srcnode, dstnode, amount, mu, delay_feefactor);
13041280
if (!*flows) {
13051281
ret = explain_failure(ctx, rq, srcnode, dstnode, amount);
13061282
goto fail;
@@ -1314,8 +1290,8 @@ const char *default_routes(const tal_t *ctx, struct route_query *rq,
13141290
" (> %i), retrying with delay_feefactor %f...",
13151291
flows_worst_delay(*flows), maxdelay - finalcltv,
13161292
delay_feefactor);
1317-
*flows = minflow(ctx, rq, srcnode, dstnode, amount, mu,
1318-
delay_feefactor, single_path);
1293+
*flows = solver(ctx, rq, srcnode, dstnode, amount, mu,
1294+
delay_feefactor);
13191295
if (!*flows || delay_feefactor > 10) {
13201296
ret = rq_log(
13211297
ctx, rq, LOG_UNUSUAL,
@@ -1338,9 +1314,8 @@ const char *default_routes(const tal_t *ctx, struct route_query *rq,
13381314
"retrying with mu of %u%%...",
13391315
fmt_amount_msat(tmpctx, flowset_fee(rq->plugin, *flows)),
13401316
fmt_amount_msat(tmpctx, maxfee), mu);
1341-
new_flows =
1342-
minflow(ctx, rq, srcnode, dstnode, amount,
1343-
mu > 100 ? 100 : mu, delay_feefactor, single_path);
1317+
new_flows = solver(ctx, rq, srcnode, dstnode, amount,
1318+
mu > 100 ? 100 : mu, delay_feefactor);
13441319
if (!*flows || mu >= 100) {
13451320
ret = rq_log(
13461321
ctx, rq, LOG_UNUSUAL,
@@ -1421,3 +1396,27 @@ const char *default_routes(const tal_t *ctx, struct route_query *rq,
14211396
assert(ret != NULL);
14221397
return ret;
14231398
}
1399+
1400+
const char *default_routes(const tal_t *ctx, struct route_query *rq,
1401+
const struct gossmap_node *srcnode,
1402+
const struct gossmap_node *dstnode,
1403+
struct amount_msat amount, struct amount_msat maxfee,
1404+
u32 finalcltv, u32 maxdelay, struct flow ***flows,
1405+
double *probability)
1406+
{
1407+
return linear_routes(ctx, rq, srcnode, dstnode, amount, maxfee,
1408+
finalcltv, maxdelay, flows, probability, minflow);
1409+
}
1410+
1411+
const char *single_path_routes(const tal_t *ctx, struct route_query *rq,
1412+
const struct gossmap_node *srcnode,
1413+
const struct gossmap_node *dstnode,
1414+
struct amount_msat amount,
1415+
struct amount_msat maxfee, u32 finalcltv,
1416+
u32 maxdelay, struct flow ***flows,
1417+
double *probability)
1418+
{
1419+
return linear_routes(ctx, rq, srcnode, dstnode, amount, maxfee,
1420+
finalcltv, maxdelay, flows, probability,
1421+
single_path_flow);
1422+
}

‎plugins/askrene/mcf.h‎

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ struct flow **minflow(const tal_t *ctx,
3131
const struct gossmap_node *target,
3232
struct amount_msat amount,
3333
u32 mu,
34-
double delay_feefactor,
35-
bool single_part);
34+
double delay_feefactor);
3635

3736
/**
3837
* API for min cost single path.
@@ -67,9 +66,18 @@ struct amount_msat linear_flow_cost(const struct flow *flow,
6766
const char *default_routes(const tal_t *ctx, struct route_query *rq,
6867
const struct gossmap_node *srcnode,
6968
const struct gossmap_node *dstnode,
70-
struct amount_msat amount, bool single_path,
69+
struct amount_msat amount,
7170
struct amount_msat maxfee, u32 finalcltv,
7271
u32 maxdelay, struct flow ***flows,
7372
double *probability);
7473

74+
/* A wrapper to the single-path constrained solver. */
75+
const char *single_path_routes(const tal_t *ctx, struct route_query *rq,
76+
const struct gossmap_node *srcnode,
77+
const struct gossmap_node *dstnode,
78+
struct amount_msat amount,
79+
struct amount_msat maxfee, u32 finalcltv,
80+
u32 maxdelay, struct flow ***flows,
81+
double *probability);
82+
7583
#endif /* LIGHTNING_PLUGINS_ASKRENE_MCF_H */

0 commit comments

Comments
 (0)