renepay: fix plugin bugs

- remove unused local_gossmods
- fix failed RPC call to askrene-age when RENEPAY_LAYER does not yet
  exist
- fix plugin hanging if there are no routehints in the invoice

Signed-off-by: Lagrang3 <[email protected]>

Author: Lagrang3

plugins/renepay/mods.c

@@ -337,7 +337,6 @@ static struct command_result *refreshgossmap_cb(struct payment *payment)
 {
 	assert(pay_plugin->gossmap); // gossmap must be already initialized
 	assert(payment);
-	assert(payment->local_gossmods);
 
 	size_t num_channel_updates_rejected = 0;
 	bool gossmap_changed =
@@ -451,7 +450,7 @@ static struct command_result *routehints_cb(struct payment *payment)
 			end = &r[j].pubkey;
 		}
 	}
-	return command_still_pending(cmd);
+	return payment_continue(payment);
 }
 
 REGISTER_PAYMENT_MODIFIER(routehints, routehints_cb);
@@ -1216,10 +1215,11 @@ static struct command_result *knowledgerelax_cb(struct payment *payment)
 	struct command *cmd = payment_command(payment);
 	assert(cmd);
 
-	// FIXME: should relax other layers too?
+	/* askrene-age may fail if the layer has not yet been created, in that
+	 * case we do nothing. */
 	struct out_req *req = jsonrpc_request_start(
 	    cmd->plugin, cmd, "askrene-age", askreneage_success,
-	    payment_rpc_failure, payment);
+	    askreneage_success, payment);
 
 	json_add_string(req->js, "layer", RENEPAY_LAYER);
 	json_add_u64(req->js, "cutoff", cutoff);

plugins/renepay/payment.c

@@ -103,7 +103,6 @@ struct payment *payment_new(
 	p->pending_rpcs = 0;
 	p->next_partid = 1;
 	p->cmd_array = tal_arr(p, struct command *, 0);
-	p->local_gossmods = NULL;
 
 	p->exclusions =
 	    tal_arr(p, struct route_exclusion, tal_count(exclusions));
@@ -135,7 +134,6 @@ static void payment_cleanup(struct payment *p)
 	p->exec_state = INVALID_STATE;
 	p->pending_rpcs = 0;
 	tal_resize(&p->cmd_array, 0);
-	p->local_gossmods = tal_free(p->local_gossmods);
 	p->exclusions = tal_free(p->exclusions);
 	p->waitresult_timer = tal_free(p->waitresult_timer);
 	routetracker_cleanup(p->routetracker);
@@ -206,8 +204,6 @@ bool payment_update(
 	assert(p->cmd_array);
 	assert(tal_count(p->cmd_array) == 0);
 
-	p->local_gossmods = tal_free(p->local_gossmods);
-
 	p->exclusions = tal_free(p->exclusions);
 	p->exclusions =
 	    tal_arr(p, struct route_exclusion, tal_count(exclusions));

plugins/renepay/payment.h

@@ -55,9 +55,6 @@ struct payment {
 	/* Running commands that want this payment */
 	struct command **cmd_array;
 
-	/* Localmods to apply to gossip_map for our own use. */
-	struct gossmap_localmods *local_gossmods;
-
 	/* Here we queue channel and node disabling orders. */
 	struct route_exclusion *exclusions;