fetchinvoice: don't abort() if we try to fetch an invoice from ourselves.

rustyrussell · cdecker · commit 1be4d42ca3e1 · 2021-01-14T11:12:11.000+01:00
blindedpath.c does:

```
	size_t num = tal_count(route);

	if (!num)
		abort();
```

Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
diff --git a/plugins/fetchinvoice.c b/plugins/fetchinvoice.c
@@ -602,6 +602,11 @@ static struct command_result *send_message(struct command *cmd,
 		}
 	}
 
+	/* FIXME: Maybe we should allow this? */
+	if (tal_bytelen(backwards) == 0)
+		return command_fail(cmd, PAY_ROUTE_NOT_FOUND,
+				    "Refusing to talk to ourselves");
+
 	/* Ok, now make reply for onion_message */
 	path = make_blindedpath(tmpctx, backwards, &blinding,
 				&sent->reply_blinding);

Original file line number	Diff line number	Diff line change
`@@ -602,6 +602,11 @@ static struct command_result send_message(struct command cmd,`
`602`	`602`	`}`
`603`	`603`	`}`
`604`	`604`
	`605`	`+ /* FIXME: Maybe we should allow this? */`
	`606`	`+ if (tal_bytelen(backwards) == 0)`
	`607`	`+ return command_fail(cmd, PAY_ROUTE_NOT_FOUND,`
	`608`	`+ "Refusing to talk to ourselves");`
	`609`	`+`
`605`	`610`	`/* Ok, now make reply for onion_message */`
`606`	`611`	`path = make_blindedpath(tmpctx, backwards, &blinding,`
`607`	`612`	`&sent->reply_blinding);`